Re: [Intel-gfx] [PATCH resend 0/9] drm: Add privacy-screen class and connector properties

2021-04-14 Thread Rajat Jain
upport > drm/connector: Add a drm_connector privacy-screen helper functions > platform/x86: thinkpad_acpi: Add hotkey_notify_extended_hotkey() > helper > platform/x86: thinkpad_acpi: Get privacy-screen / lcdshadow ACPI > handles only once > platform/x86: thinkpad_acp

[Intel-gfx] [PATCH v9 4/5] drm/i915: Add helper code for ACPI privacy screen

2020-03-12 Thread Rajat Jain
Add helper functions that can allow i915 to detect and control an integrated privacy screen via ACPI methods. These shall be used in the next patch. Signed-off-by: Rajat Jain --- v9: same as v8 v8: Initial version. formed by refactoring the previous patch 4. print the connector name

Re: [Intel-gfx] [PATCH v7 4/4] drm/i915: Add support for integrated privacy screen

2020-03-12 Thread Rajat Jain
Hi Jani, On Mon, Mar 9, 2020 at 5:18 PM Rajat Jain wrote: > > Hi Jani, > > I have 1 question / need 1 help about this patch: Kind ignore, I found the answer, and posted my new patchset here: https://patchwork.freedesktop.org/series/74607/ I got a "failed to apply" email f

[Intel-gfx] [PATCH v8 4/5] drm/i915: Add helper code for ACPI privacy screen

2020-03-11 Thread Rajat Jain
Add helper functions that can allow i915 to detect and control an integrated privacy screen via ACPI methods. These shall be used in the next patch. Signed-off-by: Rajat Jain --- v8: Initial version. formed by refactoring the previous patch 4. print the connector name in the debug messages

Re: [Intel-gfx] [PATCH v7 4/4] drm/i915: Add support for integrated privacy screen

2020-03-09 Thread Rajat Jain
Hi Jani, I have 1 question / need 1 help about this patch: On Mon, Mar 9, 2020 at 5:06 PM Rajat Jain wrote: > > Add support for an ACPI based integrated privacy screen that is > available on some systems. > > Signed-off-by: Rajat Jain > --- > v7: * Move the privacy

[Intel-gfx] [PATCH v7 4/4] drm/i915: Add support for integrated privacy screen

2020-03-09 Thread Rajat Jain
Add support for an ACPI based integrated privacy screen that is available on some systems. Signed-off-by: Rajat Jain --- v7: * Move the privacy-screen property back into drm core. * Do the actual HW EPS toggling at commit time. * Provide a sample ACPI node for reference in comments. v6

Re: [Intel-gfx] [PATCH v6 3/3] drm/i915: Add support for integrated privacy screens

2020-03-05 Thread Rajat Jain
Hi Jani, Thank you for the comments. Please see my responses inline. On Thu, Mar 5, 2020 at 2:02 AM Jani Nikula wrote: > > On Wed, 04 Mar 2020, Rajat Jain wrote: > > Certain laptops now come with panels that have integrated privacy > > screens on them. This patch adds suppo

[Intel-gfx] [PATCH v6 3/3] drm/i915: Add support for integrated privacy screens

2020-03-04 Thread Rajat Jain
screen, and controlling it, is done via ACPI _DSM methods. Currently, this is done only for the Intel display ports. But in future, this can be done for any other ports if the hardware becomes available (e.g. external monitors supporting integrated privacy screens?). Signed-off-by: Rajat Jain

[Intel-gfx] [PATCH v6 3/3] drm/i915: Add support for integrated privacy screens

2020-03-04 Thread Rajat Jain
screen, and controlling it, is done via ACPI _DSM methods. Currently, this is done only for the Intel display ports. But in future, this can be done for any other ports if the hardware becomes available (e.g. external monitors supporting integrated privacy screens?). Signed-off-by: Rajat Jain

Re: [Intel-gfx] [v5, 3/3] drm/i915: Add support for integrated privacy screens

2020-01-27 Thread Rajat Jain
On Fri, Jan 24, 2020 at 4:11 PM Guenter Roeck wrote: > > On Fri, Dec 20, 2019 at 12:03:53PM -0800, Rajat Jain wrote: > > Certain laptops now come with panels that have integrated privacy > > screens on them. This patch adds support for such panels by adding > > a

Re: [Intel-gfx] [PATCH v5 3/3] drm/i915: Add support for integrated privacy screens

2020-01-20 Thread Rajat Jain
Hello Jani, On Fri, Dec 20, 2019 at 12:04 PM Rajat Jain wrote: > > Certain laptops now come with panels that have integrated privacy > screens on them. This patch adds support for such panels by adding > a privacy-screen property to the intel_connector for the panel, that > th

Re: [Intel-gfx] [PATCH v2 3/3] drm/i915: Add support for integrated privacy screens

2019-12-20 Thread Rajat Jain
HI Jani, On Thu, Dec 5, 2019 at 1:34 AM Rajat Jain wrote: > > On Wed, Nov 20, 2019 at 7:04 AM Jani Nikula > wrote: > > > > On Mon, 04 Nov 2019, Rajat Jain wrote: > > > Certain laptops now come with panels that have integrated privacy > > > s

[Intel-gfx] [PATCH v5 3/3] drm/i915: Add support for integrated privacy screens

2019-12-20 Thread Rajat Jain
screen, and controlling it, is done via ACPI _DSM methods. Currently, this is done only for the Intel display ports. But in future, this can be done for any other ports if the hardware becomes available (e.g. external monitors supporting integrated privacy screens?). Signed-off-by: Rajat Jain

[Intel-gfx] [PATCH v4 1/3] drm/i915: Move the code to populate ACPI device ID into intel_acpi

2019-12-18 Thread Rajat Jain
Move the code that populates the ACPI device ID for devices, into more appripriate intel_acpi.c. This is done in preparation for more users of this code (in next patch). Signed-off-by: Rajat Jain --- v4: Same as v3 v3: * Renamed the function to intel_acpi_* * Used forward declaration

[Intel-gfx] [PATCH v4 3/3] drm/i915: Add support for integrated privacy screens

2019-12-18 Thread Rajat Jain
screen, and controlling it, is done via ACPI _DSM methods. Currently, this is done only for the Intel display ports. But in future, this can be done for any other ports if the hardware becomes available (e.g. external monitors supporting integrated privacy screens?). Signed-off-by: Rajat Jain

[Intel-gfx] [PATCH RESEND v4 3/3] drm/i915: Add support for integrated privacy screens

2019-12-18 Thread Rajat Jain
screen, and controlling it, is done via ACPI _DSM methods. Currently, this is done only for the Intel display ports. But in future, this can be done for any other ports if the hardware becomes available (e.g. external monitors supporting integrated privacy screens?). Signed-off-by: Rajat Jain

Re: [Intel-gfx] [PATCH v3 3/3] drm/i915: Add support for integrated privacy screens

2019-12-16 Thread Rajat Jain
On Thu, Dec 5, 2019 at 1:34 AM Rajat Jain wrote: > > Certain laptops now come with panels that have integrated privacy > screens on them. This patch adds support for such panels by adding > a privacy-screen property to the intel_connector for the panel, that > the userspa

[Intel-gfx] [PATCH v3 1/3] drm/i915: Move the code to populate ACPI device ID into intel_acpi

2019-12-05 Thread Rajat Jain
Move the code that populates the ACPI device ID for devices, into more appripriate intel_acpi.c. This is done in preparation for more users of this code (in next patch). Signed-off-by: Rajat Jain --- v3: * Renamed the function to intel_acpi_* * Used forward declaration for structure instead

[Intel-gfx] [PATCH v3 3/3] drm/i915: Add support for integrated privacy screens

2019-12-05 Thread Rajat Jain
screen, and controlling it, is done via ACPI _DSM methods. Currently, this is done only for the Intel display ports. But in future, this can be done for any other ports if the hardware becomes available (e.g. external monitors supporting integrated privacy screens?). Signed-off-by: Rajat Jain

Re: [Intel-gfx] [PATCH v2 1/3] drm/i915: Move the code to populate ACPI device ID into intel_acpi

2019-12-05 Thread Rajat Jain
Hi Jani, Thanks for the review. On Wed, Nov 20, 2019 at 6:41 AM Jani Nikula wrote: > > On Mon, 04 Nov 2019, Rajat Jain wrote: > > Move the code that populates the ACPI device ID for devices, into > > more appripriate intel_acpi.c. This is done in preparation for more >

Re: [Intel-gfx] [PATCH v2 2/3] drm/i915: Lookup and attach ACPI device node for connectors

2019-12-05 Thread Rajat Jain
On Wed, Nov 20, 2019 at 6:51 AM Jani Nikula wrote: > > On Mon, 04 Nov 2019, Rajat Jain wrote: > > Lookup and attach ACPI nodes for intel connectors. The lookup is done > > in compliance with ACPI Spec 6.3 > > https://uefi.org/sites/default/files/resources/ACPI_6_3_final_J

[Intel-gfx] [PATCH v3 2/3] drm/i915: Lookup and attach ACPI device node for connectors

2019-12-05 Thread Rajat Jain
for privacy screen in next patch). Signed-off-by: Rajat Jain --- v3: fold the code into existing acpi_device_id_update() function v2: formed by splitting the original patch into ACPI lookup, and privacy screen property. Also move it into i915 now that I found existing code in i915 that can be re

Re: [Intel-gfx] [PATCH v2 3/3] drm/i915: Add support for integrated privacy screens

2019-12-05 Thread Rajat Jain
On Wed, Nov 20, 2019 at 7:04 AM Jani Nikula wrote: > > On Mon, 04 Nov 2019, Rajat Jain wrote: > > Certain laptops now come with panels that have integrated privacy > > screens on them. This patch adds support for such panels by adding > > a privacy-screen propert

Re: [Intel-gfx] [PATCH v2 3/3] drm/i915: Add support for integrated privacy screens

2019-11-20 Thread Rajat Jain
Hi Jani, On Wed, Nov 20, 2019 at 7:11 AM Jani Nikula wrote: > > On Tue, 12 Nov 2019, Rajat Jain wrote: > > On Mon, Nov 4, 2019 at 11:41 AM Rajat Jain wrote: > >> > >> Certain laptops now come with panels that have integrated privacy > >> screens on them.

Re: [Intel-gfx] [PATCH v2 3/3] drm/i915: Add support for integrated privacy screens

2019-11-12 Thread Rajat Jain
On Mon, Nov 4, 2019 at 11:41 AM Rajat Jain wrote: > > Certain laptops now come with panels that have integrated privacy > screens on them. This patch adds support for such panels by adding > a privacy-screen property to the intel_connector for the panel, that > the userspa

[Intel-gfx] [PATCH v2 2/3] drm/i915: Lookup and attach ACPI device node for connectors

2019-11-05 Thread Rajat Jain
for privacy screen in next patch). Signed-off-by: Rajat Jain Change-Id: I798e70714a4402554c8cd2a8e58268353f75814f --- v2: formed by splitting the original patch into ACPI lookup, and privacy screen property. Also move it into i915 now that I found existing code in i915 that can be re-used. drivers

[Intel-gfx] [PATCH v2 1/3] drm/i915: Move the code to populate ACPI device ID into intel_acpi

2019-11-05 Thread Rajat Jain
Move the code that populates the ACPI device ID for devices, into more appripriate intel_acpi.c. This is done in preparation for more users of this code (in next patch). Signed-off-by: Rajat Jain Change-Id: Ifb3bd458734985c2a78ba682e6f0a2e63e0626ca --- v2: v1 doesn't exist. Found existing code

[Intel-gfx] [PATCH v2 3/3] drm/i915: Add support for integrated privacy screens

2019-11-05 Thread Rajat Jain
screen, and controlling it, is done via ACPI _DSM methods. Currently, this is done only for the Intel display ports. But in future, this can be done for any other ports if the hardware becomes available (e.g. external monitors supporting integrated privacy screens?). Signed-off-by: Rajat Jain

Re: [Intel-gfx] [PATCH] drm: Add support for integrated privacy screens

2019-10-28 Thread Rajat Jain
On Fri, Oct 25, 2019 at 4:36 AM Thierry Reding wrote: > > On Thu, Oct 24, 2019 at 01:45:16PM -0700, Rajat Jain wrote: > > Hi, > > > > Thanks for your review and comments. Please see inline below. > > > > On Thu, Oct 24, 2019 at 4:20 AM Thierry Reding > &g

Re: [Intel-gfx] ✗ Fi.CI.BUILD: failure for drm: Add support for integrated privacy screens

2019-10-24 Thread Rajat Jain
On Thu, Oct 24, 2019 at 12:01 AM Jani Nikula wrote: > > On Thu, 24 Oct 2019, Patchwork wrote: > > == Series Details == > > > > Series: drm: Add support for integrated privacy screens > > URL : https://patchwork.freedesktop.org/series/68472/ > > State : failure > > > > == Summary == > > > >

[Intel-gfx] [PATCH] drm: Add support for integrated privacy screens

2019-10-23 Thread Rajat Jain
cy screens?). Also, this code can be extended in future to support non-ACPI methods (e.g. using a kernel GPIO driver to toggle a gpio that controls the privacy-screen). Signed-off-by: Rajat Jain --- drivers/gpu/drm/Makefile| 1 + drivers/gpu/drm/drm_atomic_uapi.c | 5 + drive