Re: [Intel-gfx] [PATCH i-g-t] tests/gem_lmem_swapping: add some coverage for big objects

2022-08-07 Thread Ramalingam C
d > Cc: Thomas Hellström > Cc: Ramalingam C > --- > tests/i915/gem_lmem_swapping.c | 16 +++- > 1 file changed, 15 insertions(+), 1 deletion(-) > > diff --git a/tests/i915/gem_lmem_swapping.c b/tests/i915/gem_lmem_swapping.c > index 1a4f4ca5..67e95cea 100644

Re: [Intel-gfx] [PATCH 2/2] drm/i915/ttm: fix CCS handling

2022-08-07 Thread Ramalingam C
; lmem obj") > Testcase: igt@gem_lmem_swapping@basic-big > Testcase: igt@gem_lmem_swapping@verify-ccs-big > Signed-off-by: Matthew Auld > Cc: Thomas Hellström > Cc: Ramalingam C > --- > drivers/gpu/drm/i915/gt/intel_migrate.c | 44 - > 1

Re: [Intel-gfx] [PATCH 1/2] drm/i915/ttm: remove calc_ctrl_surf_instr_size

2022-08-07 Thread Ramalingam C
On 2022-08-05 at 14:22:39 +0100, Matthew Auld wrote: > We only ever need to emit one ccs block copy command. Since max size we handle at a time is CHUNK_SZ, we will need only one cmd. Reviewed-by: Ramalingam C > > Signed-off-by: Matthew Auld > Cc: Thomas Hellström > C

Re: [Intel-gfx] [RFC 10/10] drm/i915/vm_bind: Fix vm->vm_bind_mutex and vm->mutex nesting

2022-07-06 Thread Ramalingam C
On 2022-07-05 at 10:40:56 +0200, Thomas Hellström wrote: > On Fri, 2022-07-01 at 15:50 -0700, Niranjana Vishwanathapura wrote: > > VM_BIND functionality maintain that vm->vm_bind_mutex will never be > > taken > > while holding vm->mutex. > > However, while closing 'vm', vma is destroyed while holdi

Re: [Intel-gfx] [RFC 05/10] drm/i915/vm_bind: Handle persistent vmas

2022-07-05 Thread Ramalingam C
On 2022-07-04 at 17:05:38 +, Zeng, Oak wrote: > > > Thanks, > Oak > > > -Original Message- > > From: Intel-gfx On Behalf Of > > Niranjana Vishwanathapura > > Sent: July 1, 2022 6:51 PM > > To: intel-gfx@lists.freedesktop.org; dri-de...@lists.freedesktop.org > > Cc: Zanoni, Paulo R ;

Re: [Intel-gfx] [PATCH v3 12/13] drm/i915/ttm: disallow CPU fallback mode for ccs pages

2022-06-29 Thread Ramalingam C
leak. > > Fixes: 48760ffe923a ("drm/i915/gt: Clear compress metadata for Flat-ccs > objects") Looks good to me. Reviewed-by: Ramalingam C > Signed-off-by: Matthew Auld > Cc: Thomas Hellström > Cc: Lionel Landwerlin > Cc: Tvrtko Ursulin > Cc: Jon Bloomfield >

Re: [Intel-gfx] [PATCH] drm/i915/gt: handle null ptr at sg traversing

2022-06-28 Thread Ramalingam C
On 2022-06-28 at 10:40:56 +0100, Matthew Auld wrote: > On 27/06/2022 18:35, Ramalingam C wrote: > > When calculating the starting address for ccs data in smem scatterlist, > > handle the NULL pointer returned from sg_next, incase of scatterlist > > less than required size..

[Intel-gfx] [PATCH] drm/i915/gt: handle null ptr at sg traversing

2022-06-27 Thread Ramalingam C
When calculating the starting address for ccs data in smem scatterlist, handle the NULL pointer returned from sg_next, incase of scatterlist less than required size.. Signed-off-by: Ramalingam C --- drivers/gpu/drm/i915/gt/intel_migrate.c | 13 ++--- 1 file changed, 10 insertions(+), 3

Re: [Intel-gfx] [PATCH 3/3] drm/i915: Do not use reserved requests for virtual engines

2022-06-27 Thread Ramalingam C
On 2022-06-27 at 10:18:59 -0700, Matthew Brost wrote: > On Wed, Jun 15, 2022 at 12:13:48AM +0530, Ramalingam C wrote: > > Do not use reserved requests for virtual engines as this is only > > needed for kernel contexts. > > > > Signed-off-by: Ramalingam C >

[Intel-gfx] [PATCH 3/3] drm/i915: Do not use reserved requests for virtual engines

2022-06-14 Thread Ramalingam C
Do not use reserved requests for virtual engines as this is only needed for kernel contexts. Signed-off-by: Ramalingam C Suggested-by: Matthew Brost --- drivers/gpu/drm/i915/i915_request.c | 5 - 1 file changed, 4 insertions(+), 1 deletion(-) diff --git a/drivers/gpu/drm/i915

[Intel-gfx] [PATCH 2/3] Revert "drm/i915: Hold reference to intel_context over life of i915_request"

2022-06-14 Thread Ramalingam C
ff-by: Ramalingam C Suggested-by: Matthew Brost --- drivers/gpu/drm/i915/i915_request.c | 55 + 1 file changed, 32 insertions(+), 23 deletions(-) diff --git a/drivers/gpu/drm/i915/i915_request.c b/drivers/gpu/drm/i915/i915_request.c index 7f6998bf390c..c71905d8e154 100644

[Intel-gfx] [PATCH 1/3] drm/i915: Do not access rq->engine without a reference

2022-06-14 Thread Ramalingam C
From: Niranjana Vishwanathapura In i915_fence_get_driver_name(), user may not hold a reference to rq->engine. Hence do not access it. Instead, store required device private pointer in 'rq->i915' and use it. Signed-off-by: Niranjana Vishwanathapura Suggested-by: Matthew Brost --- drivers/gpu/d

[Intel-gfx] [PATCH 0/3] Break VM to rq reference loop

2022-06-14 Thread Ramalingam C
ce Revert "drm/i915: Hold reference to intel_context over life of i915_request" Ramalingam C (1): drm/i915: Do not use reserved requests for virtual engines drivers/gpu/drm/i915/i915_request.c | 55 ++--- drivers/gpu/drm/i915/i915_request.h | 2 ++

Re: [Intel-gfx] [PATCH v3] uapi/drm/i915: Document memory residency and Flat-CCS capability of obj

2022-05-17 Thread Ramalingam C
On 2022-05-13 at 14:06:11 -0700, Jordan Justen wrote: > On 2022-05-13 05:31:00, Lionel Landwerlin wrote: > > On 02/05/2022 17:15, Ramalingam C wrote: > > > Capture the impact of memory region preference list of the objects, on > > > their memory residency and Flat-CCS

Re: [Intel-gfx] ✗ Fi.CI.IGT: failure for Flat-CCS eviction enhancements (rev4)

2022-05-02 Thread Ramalingam C
On 2022-05-02 at 21:39:56 +, Patchwork wrote: > == Series Details == > > Series: Flat-CCS eviction enhancements (rev4) > URL : https://patchwork.freedesktop.org/series/102916/ > State : failure > > == Summary == > > CI Bug Log - changes from CI_DRM_11588_full -> Patchwork_102916v4_full > =

[Intel-gfx] [PATCH v3 3/3] drm/i915/gt: Document the eviction of the Flat-CCS objects

2022-05-02 Thread Ramalingam C
Capture the eviction details for Flat-CCS capable, lmem objects. v2: Fix the Flat-ccs capbility of lmem obj with smem residency possibility [Thomas] v3: Fixed the suggestions [Matt] Signed-off-by: Ramalingam C cc: Thomas Hellstrom cc: Matthew Auld Reviewed-by: Matthew Auld --- drivers

[Intel-gfx] [PATCH v3 2/3] drm/i915/gt: optimize the ccs_sz calculation per chunk

2022-05-02 Thread Ramalingam C
Calculate the ccs_sz that needs to be emitted based on the src and dst pages emitted per chunk. And handle the return value of emit_pte for the ccs pages. v2: ccs_sz moved to the reduced scope [Matt] Signed-off-by: Ramalingam C Reviewed-by: Matthew Auld --- drivers/gpu/drm/i915/gt

[Intel-gfx] [PATCH v3 1/3] drm/i915/gt: BUG_ON unexpected NULL at scatterlist walking

2022-05-02 Thread Ramalingam C
documentation [Matt] Signed-off-by: Ramalingam C Reviewed-by: Matthew Auld (v1) --- drivers/gpu/drm/i915/gt/intel_migrate.c | 14 +- 1 file changed, 13 insertions(+), 1 deletion(-) diff --git a/drivers/gpu/drm/i915/gt/intel_migrate.c b/drivers/gpu/drm/i915/gt/intel_migrate.c index

[Intel-gfx] [PATCH v3 0/3] Flat-CCS eviction enhancements

2022-05-02 Thread Ramalingam C
Flat-CCS eviction enhancements v3: Incorporated the review suggestions [Matt] Ramalingam C (3): drm/i915/gt: BUG_ON unexpected NULL at scatterlist walking drm/i915/gt: optimize the ccs_sz calculation per chunk drm/i915/gt: Document the eviction of the Flat-CCS objects drivers/gpu/drm

[Intel-gfx] [PATCH v3] uapi/drm/i915: Document memory residency and Flat-CCS capability of obj

2022-05-02 Thread Ramalingam C
Capture the impact of memory region preference list of the objects, on their memory residency and Flat-CCS capability. v2: Fix the Flat-CCS capability of an obj with {lmem, smem} preference list [Thomas] v3: Reworded the doc [Matt] Signed-off-by: Ramalingam C cc: Matthew Auld cc: Thomas

Re: [Intel-gfx] [PATCH v4 1/4] drm/i915/gt: Explicitly clear BB_OFFSET for new contexts

2022-05-02 Thread Ramalingam C
On 2022-05-02 at 16:40:00 +0530, Ramalingam C wrote: > From: Chris Wilson > > Even though the initial protocontext we load onto HW has the register > cleared, by the time we save it into the default image, BB_OFFSET has > had the enable bit set. Reclear BB_OFFSET for e

[Intel-gfx] [PATCH v4 3/4] drm/i915/selftest: Always cancel semaphore on error

2022-05-02 Thread Ramalingam C
-by: Ramalingam C Reviewed-by: Thomas Hellstrom --- drivers/gpu/drm/i915/gt/selftest_lrc.c | 17 - 1 file changed, 8 insertions(+), 9 deletions(-) diff --git a/drivers/gpu/drm/i915/gt/selftest_lrc.c b/drivers/gpu/drm/i915/gt/selftest_lrc.c index 3271f01fe7db..e4d5d74489bf 100644

[Intel-gfx] [PATCH v4 4/4] drm/i915/selftest: Clear the output buffers before GPU writes

2022-05-02 Thread Ramalingam C
POISON_INUSE (0x5a) so that is both non-zero and distinct from the poison values used during the test. v2: Use i915_gem_object_pin_map_unlocked Reported-by: CQ Tang Signed-off-by: Chris Wilson Cc: CQ Tang cc: Joonas Lahtinen Signed-off-by: Ramalingam C Reviewed-by: Thomas Hellstrom --- drivers/gpu

[Intel-gfx] [PATCH v4 2/4] drm/i915/selftests: Check for incomplete LRI from the context image

2022-05-02 Thread Ramalingam C
emit an invalid zero-length LRI. Reported-by: Daniele Ceraolo Spurio Signed-off-by: Chris Wilson Cc: Daniele Ceraolo Spurio Signed-off-by: Ramalingam C Acked-by: Thomas Hellstrom --- drivers/gpu/drm/i915/gt/selftest_lrc.c | 61 +++--- 1 file changed, 54 insertions(+), 7

[Intel-gfx] [PATCH v4 1/4] drm/i915/gt: Explicitly clear BB_OFFSET for new contexts

2022-05-02 Thread Ramalingam C
: BB_OFFSET is recorded per engine from Gen9 onwards Signed-off-by: Chris Wilson Cc: Mika Kuoppala Signed-off-by: Ramalingam C Reviewed-by: Thomas Hellstrom --- drivers/gpu/drm/i915/gt/intel_engine_regs.h | 1 + drivers/gpu/drm/i915/gt/intel_lrc.c | 20 drivers/gpu/drm

[Intel-gfx] [PATCH v4 0/4] lrc selftest fixes

2022-05-02 Thread Ramalingam C
Few bug fixes for lrc selftest. v4: Gen8 don't have per engine recording of BB_OFFSET [Chris] Chris Wilson (4): drm/i915/gt: Explicitly clear BB_OFFSET for new contexts drm/i915/selftests: Check for incomplete LRI from the context image drm/i915/selftest: Always cancel semaphore on error

[Intel-gfx] [PATCH v3 4/4] drm/i915/selftest: Clear the output buffers before GPU writes

2022-04-29 Thread Ramalingam C
POISON_INUSE (0x5a) so that is both non-zero and distinct from the poison values used during the test. v2: Use i915_gem_object_pin_map_unlocked Reported-by: CQ Tang Signed-off-by: Chris Wilson Cc: CQ Tang cc: Joonas Lahtinen Signed-off-by: Ramalingam C Reviewed-by: Thomas Hellstrom --- drivers/gpu

[Intel-gfx] [PATCH v3 3/4] drm/i915/selftest: Always cancel semaphore on error

2022-04-29 Thread Ramalingam C
-by: Ramalingam C Reviewed-by: Thomas Hellstrom --- drivers/gpu/drm/i915/gt/selftest_lrc.c | 17 - 1 file changed, 8 insertions(+), 9 deletions(-) diff --git a/drivers/gpu/drm/i915/gt/selftest_lrc.c b/drivers/gpu/drm/i915/gt/selftest_lrc.c index 684a63de156a..51e4b7092d4f 100644

[Intel-gfx] [PATCH v3 2/4] drm/i915/selftests: Check for incomplete LRI from the context image

2022-04-29 Thread Ramalingam C
emit an invalid zero-length LRI. Reported-by: Daniele Ceraolo Spurio Signed-off-by: Chris Wilson Cc: Daniele Ceraolo Spurio Signed-off-by: Ramalingam C Acked-by: Thomas Hellstrom --- drivers/gpu/drm/i915/gt/selftest_lrc.c | 61 +++--- 1 file changed, 54 insertions(+), 7

[Intel-gfx] [PATCH v3 1/4] drm/i915/gt: Explicitly clear BB_OFFSET for new contexts

2022-04-29 Thread Ramalingam C
-off-by: Chris Wilson Cc: Mika Kuoppala Signed-off-by: Ramalingam C Reviewed-by: Thomas Hellstrom --- drivers/gpu/drm/i915/gt/intel_engine_regs.h | 1 + drivers/gpu/drm/i915/gt/intel_lrc.c | 19 +++ drivers/gpu/drm/i915/gt/selftest_lrc.c | 5 + 3 files changed

[Intel-gfx] [PATCH v3 0/4] lrc selftest fixes

2022-04-29 Thread Ramalingam C
Few bug fixes for lrc selftest. v3: Extending the first patch for gen8 Chris Wilson (4): drm/i915/gt: Explicitly clear BB_OFFSET for new contexts drm/i915/selftests: Check for incomplete LRI from the context image drm/i915/selftest: Always cancel semaphore on error drm/i915/selftest: Cl

Re: [Intel-gfx] ✗ Fi.CI.BAT: failure for Handle predicate programming

2022-04-29 Thread Ramalingam C
On 2022-04-25 at 16:44:14 +, Patchwork wrote: > == Series Details == > > Series: Handle predicate programming > URL : https://patchwork.freedesktop.org/series/103084/ > State : failure > > == Summary == > > CI Bug Log - changes from CI_DRM_11550 -> Patchwork_103084v1 >

[Intel-gfx] [PATCH v2 4/4] uapi/drm/i915: Document memory residency and Flat-CCS capability of obj

2022-04-25 Thread Ramalingam C
Capture the impact of memory region preference list of an object, on their memory residency and Flat-CCS capability of the objects. v2: Fix the Flat-CCS capability of an obj with {lmem, smem} preference list [Thomas] Signed-off-by: Ramalingam C cc: Matthew Auld cc: Thomas Hellstrom

[Intel-gfx] [PATCH v2 1/4] drm/i915/gt: GEM_BUG_ON unexpected NULL at scatterlist walking

2022-04-25 Thread Ramalingam C
While locating the start of ccs scatterlist in smem scatterlist, that has to be the size of lmem obj size + corresponding ccs data size. Report bug if scatterlist terminate before that length. Signed-off-by: Ramalingam C --- drivers/gpu/drm/i915/gt/intel_migrate.c | 6 ++ 1 file changed, 6

[Intel-gfx] [PATCH v2 3/4] drm/i915/gt: Document the eviction of the Flat-CCS objects

2022-04-25 Thread Ramalingam C
Capture the eviction details for Flat-CCS capable, lmem objects. v2: Fix the Flat-ccs capbility of lmem obj with smem residency possibility [Thomas] Signed-off-by: Ramalingam C cc: Thomas Hellstrom cc: Matthew Auld --- drivers/gpu/drm/i915/gt/intel_migrate.c | 23

[Intel-gfx] [PATCH v2 2/4] drm/i915/gt: optimize the ccs_sz calculation per chunk

2022-04-25 Thread Ramalingam C
Calculate the ccs_sz that needs to be emitted based on the src and dst pages emitted per chunk. And handle the return value of emit_pte for the ccs pages. Signed-off-by: Ramalingam C --- drivers/gpu/drm/i915/gt/intel_migrate.c | 36 + 1 file changed, 12 insertions(+), 24

[Intel-gfx] [PATCH v2 0/4] Flat-CCS eviction enhancements

2022-04-25 Thread Ramalingam C
Flat-CCS eviction enhancements v2: Correcting the memory residency requirement for flat-ccs capability [Thomas] Ramalingam C (4): drm/i915/gt: GEM_BUG_ON unexpected NULL at scatterlist walking drm/i915/gt: optimize the ccs_sz calculation per chunk drm/i915/gt: Document the eviction of

[Intel-gfx] [PATCH 3/3] drm/i915/gt: Clear SET_PREDICATE_RESULT prior to executing the ring

2022-04-25 Thread Ramalingam C
ned-off-by: Chris Wilson Cc: Zbigniew Kempczynski Cc: Thomas Hellstrom Signed-off-by: Ramalingam C --- drivers/gpu/drm/i915/gt/gen8_engine_cs.c | 54 + drivers/gpu/drm/i915/gt/gen8_engine_cs.h | 7 ++ drivers/gpu/drm/i915/gt/intel_engine_regs.h | 1 + .../d

[Intel-gfx] [PATCH 2/3] drm/i915/selftests: Skip poisoning SET_PREDICATE_RESULT on dg2

2022-04-25 Thread Ramalingam C
quest are nop'ed. Not only do we then not signal the waiting context, but we even prevent re-enabling arbitration and the GPU will not perform a context switch at the end of the request. Cc: Joonas Lahtinen Suggested-by: CQ Tang Signed-off-by: Chris Wilson Signed-off-by: Ramalingam C --- d

[Intel-gfx] [PATCH 1/3] drm/i915/xehpsdv/dg1/tgl: Fix issue with LRI relative addressing

2022-04-25 Thread Ramalingam C
-off-by: Akeem G Abodunrin cc: Prathap Kumar Valsan Signed-off-by: Ramalingam C --- drivers/gpu/drm/i915/gt/selftest_lrc.c | 36 +- 1 file changed, 35 insertions(+), 1 deletion(-) diff --git a/drivers/gpu/drm/i915/gt/selftest_lrc.c b/drivers/gpu/drm/i915/gt/selftest_lrc.c in

[Intel-gfx] [PATCH 0/3] Handle predicate programming

2022-04-25 Thread Ramalingam C
Userspace can leave SET_PREDICATE_RESULT active at the end of their batch, causing all the kernel operations from the ring to be noop'ed. This includes workarounds for memory corruption on dg2, as well as the usual synchronisation, arbitration, coherency and signaling. The latter can be used to cau

[Intel-gfx] [PATCH v2 4/4] drm/i915/selftest: Clear the output buffers before GPU writes

2022-04-25 Thread Ramalingam C
POISON_INUSE (0x5a) so that is both non-zero and distinct from the poison values used during the test. v2: Use i915_gem_object_pin_map_unlocked Reported-by: CQ Tang Signed-off-by: Chris Wilson Cc: CQ Tang cc: Joonas Lahtinen Signed-off-by: Ramalingam C Reviewed-by: Thomas Hellstrom --- drivers/gpu

[Intel-gfx] [PATCH v2 3/4] drm/i915/selftest: Always cancel semaphore on error

2022-04-25 Thread Ramalingam C
-by: Ramalingam C Reviewed-by: Thomas Hellstrom --- drivers/gpu/drm/i915/gt/selftest_lrc.c | 17 - 1 file changed, 8 insertions(+), 9 deletions(-) diff --git a/drivers/gpu/drm/i915/gt/selftest_lrc.c b/drivers/gpu/drm/i915/gt/selftest_lrc.c index 684a63de156a..51e4b7092d4f 100644

[Intel-gfx] [PATCH v2 2/4] drm/i915/selftests: Check for incomplete LRI from the context image

2022-04-25 Thread Ramalingam C
emit an invalid zero-length LRI. Reported-by: Daniele Ceraolo Spurio Signed-off-by: Chris Wilson Cc: Daniele Ceraolo Spurio Signed-off-by: Ramalingam C Acked-by: Thomas Hellstrom --- drivers/gpu/drm/i915/gt/selftest_lrc.c | 61 +++--- 1 file changed, 54 insertions(+), 7

[Intel-gfx] [PATCH v2 1/4] drm/i915/gt: Explicitly clear BB_OFFSET for new contexts

2022-04-25 Thread Ramalingam C
: Mika Kuoppala Signed-off-by: Ramalingam C Reviewed-by: Thomas Hellstrom --- drivers/gpu/drm/i915/gt/intel_engine_regs.h | 1 + drivers/gpu/drm/i915/gt/intel_lrc.c | 17 + drivers/gpu/drm/i915/gt/selftest_lrc.c | 5 + 3 files changed, 23 insertions(+) diff --git

[Intel-gfx] [PATCH v2 0/4] lrc selftest fixes

2022-04-25 Thread Ramalingam C
Few bug fixes for lrc selftest. Resending the reviewed patches for CI feedback. Chris Wilson (4): drm/i915/gt: Explicitly clear BB_OFFSET for new contexts drm/i915/selftests: Check for incomplete LRI from the context image drm/i915/selftest: Always cancel semaphore on error drm/i915/selft

Re: [Intel-gfx] [PATCH 3/4] drm/i915/gt: Extend doc on Flat-CCS obj eviction

2022-04-22 Thread Ramalingam C
On 2022-04-21 at 19:07:29 +0530, Hellstrom, Thomas wrote: > On Thu, 2022-04-21 at 17:08 +0530, Ramalingam C wrote: > > Capture the eviction details for Flat-CCS capable lmem only objects > > and > > lmem objects with smem residency. This also captures the impact of > > e

Re: [Intel-gfx] [PATCH 1/4] drm/i915/gt: GEM_BUG_ON unexpected NULL at scatterlist walking

2022-04-21 Thread Ramalingam C
On 2022-04-21 at 18:57:59 +0530, Hellstrom, Thomas wrote: > On Thu, 2022-04-21 at 17:08 +0530, Ramalingam C wrote: > > While locating the start of ccs scatterlist in smem scatterlist, that > > has > > to be the size of lmem obj size + corresponding ccs data size. Report >

[Intel-gfx] [PATCH 4/4] uapi/drm/i915: Update the placement list impact on obj residency

2022-04-21 Thread Ramalingam C
ression is supported only on objects of I915_MEMORY_CLASS_DEVICE. When the Flat-CCS compressed objects migrates out of I915_MEMORY_CLASS_DEVICE, due to memory constrain, content will be decompressed without notifying the userpsace. Record these details in Kernel documentation. Signed-off-by: Ra

[Intel-gfx] [PATCH 3/4] drm/i915/gt: Extend doc on Flat-CCS obj eviction

2022-04-21 Thread Ramalingam C
Capture the eviction details for Flat-CCS capable lmem only objects and lmem objects with smem residency. This also captures the impact of eviction on object's memory residency and Flat-CCS compression state. Signed-off-by: Ramalingam C --- drivers/gpu/drm/i915/gt/intel_migrate.c

[Intel-gfx] [PATCH 2/4] drm/i915/gt: optimize the ccs_sz calculation per chunk

2022-04-21 Thread Ramalingam C
Calculate the ccs_sz that needs to be emitted based on the src and dst pages emitted per chunk. And handle the return value of emit_pte for the ccs pages. Signed-off-by: Ramalingam C --- drivers/gpu/drm/i915/gt/intel_migrate.c | 36 + 1 file changed, 12 insertions(+), 24

[Intel-gfx] [PATCH 0/4] Flat-CCS eviction enhancements

2022-04-21 Thread Ramalingam C
Flat-CCS eviction enhancements. Ramalingam C (4): drm/i915/gt: GEM_BUG_ON unexpected NULL at scatterlist walking drm/i915/gt: optimize the ccs_sz calculation per chunk drm/i915/gt: Extend doc on Flat-CCS obj eviction uapi/drm/i915: Update the placement list impact on obj residency

[Intel-gfx] [PATCH 1/4] drm/i915/gt: GEM_BUG_ON unexpected NULL at scatterlist walking

2022-04-21 Thread Ramalingam C
While locating the start of ccs scatterlist in smem scatterlist, that has to be the size of lmem obj size + corresponding ccs data size. Report bug if scatterlist terminate before that length. Signed-off-by: Ramalingam C --- drivers/gpu/drm/i915/gt/intel_migrate.c | 6 ++ 1 file changed, 6

[Intel-gfx] [PATCH 0/4] Flat-CCS eviction enhancements

2022-04-21 Thread Ramalingam C
Flat-CCS eviction enhancements. Ramalingam C (4): drm/i915/gt: GEM_BUG_ON unexpected NULL at scatterlist walking drm/i915/gt: optimize the ccs_sz calculation per chunk drm/i915/gt: Extend doc on Flat-CCS obj eviction uapi/drm/i915: Update the placement list impact on obj residency

Re: [Intel-gfx] [CI 4/4] drm/i915/selftests: tweak the misaligned_case

2022-04-21 Thread Ramalingam C
as Hellström > Cc: Nirmoy Das > Cc: Ramalingam C Looks good to me. Reviewed-by: Ramalingam C > --- > drivers/gpu/drm/i915/selftests/i915_gem_gtt.c | 12 +--- > 1 file changed, 9 insertions(+), 3 deletions(-) > > diff --git a/drivers/gpu/drm/i915/selftests/i

Re: [Intel-gfx] [CI 3/4] drm/i915/selftests: fixup min_alignment usage

2022-04-21 Thread Ramalingam C
good to me. Reviewed-by: Ramalingam C > Cc: Thomas Hellström > Cc: Nirmoy Das > Cc: Ramalingam C > --- > drivers/gpu/drm/i915/selftests/i915_gem_gtt.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/drivers/gpu/drm/i915/selftests/i915_gem_gtt.c

Re: [Intel-gfx] [PATCH v7 7/9] drm/ttm: Add a parameter to add extra pages into ttm_tt

2022-04-13 Thread Ramalingam C
On 2022-04-13 at 11:28:28 +0300, Joonas Lahtinen wrote: > (+ Tvrtko and Jani) > > Quoting Ramalingam C (2022-04-02 06:02:38) > > On 2022-04-01 at 16:31:19 +0200, Christian König wrote: > > > I would be nicer to push this through drm-misc-next, but the intel branch &g

[Intel-gfx] [PATCH v9 7/9] drm/i915/selftest_migrate: Check CCS meta data clear

2022-04-05 Thread Ramalingam C
Extend the live migrate selftest, to verify the ccs surface clearing during the Flat-CCS capable lmem obj clear. v2: Look at right places for ccs data [Thomas] Signed-off-by: Ramalingam C Reviewed-by: Thomas Hellstrom --- drivers/gpu/drm/i915/gt/selftest_migrate.c | 250

[Intel-gfx] [PATCH v9 8/9] drm/i915/gem: Add extra pages in ttm_tt for ccs data

2022-04-05 Thread Ramalingam C
when obj's placement is lmem only v4: GEM_BUG_ON if the ttm->num_pages > obj page size [Thomas] Signed-off-by: Ramalingam C cc: Christian Koenig cc: Hellstrom Thomas Reviewed-by: Thomas Hellstrom Reviewed-by: Nirmoy Das --- drivers/gpu/drm/i915/gem/i915_gem

[Intel-gfx] [PATCH v9 9/9] drm/i915/migrate: Evict and restore the flatccs capable lmem obj

2022-04-05 Thread Ramalingam C
op as main memory [Thomas] v4: changes for emit_copy_ccs v5: handle non-flat-ccs scenario Signed-off-by: Ramalingam C Reviewed-by: Thomas Hellstrom --- drivers/gpu/drm/i915/gt/intel_migrate.c | 164 +++- 1 file changed, 160 insertions(+), 4 deletions(-) diff --git a/drivers/gp

[Intel-gfx] [PATCH v9 6/9] drm/i915/selftest_migrate: Consider the possible roundup of size

2022-04-05 Thread Ramalingam C
Consider the possible round up happened at obj size alignment to min_page_size during the obj allocation. Signed-off-by: Ramalingam C Reviewed-by: Thomas Hellstrom --- drivers/gpu/drm/i915/gt/selftest_migrate.c | 3 +++ 1 file changed, 3 insertions(+) diff --git a/drivers/gpu/drm/i915/gt

[Intel-gfx] [PATCH v9 5/9] drm/i915/gt: Clear compress metadata for Flat-ccs objects

2022-04-05 Thread Ramalingam C
] only one ctrl surf cmd is used as size of lmem is <=8M [Thomas] Signed-off-by: Ramalingam C Signed-off-by: Ayaz A Siddiqui Reviewed-by: Thomas Hellstrom --- drivers/gpu/drm/i915/gt/intel_gpu_commands.h | 16 +++ drivers/gpu/drm/i915/gt/intel_migrate.c | 137 ++-

[Intel-gfx] [PATCH v9 3/9] drm/i915/gt: Optimize the migration and clear loop

2022-04-05 Thread Ramalingam C
Move the static calculations out of the loops for copy and clear. v2: Fix the loss of proper error code on emit_pte Signed-off-by: Ramalingam C Reviewed-by: Thomas Hellstrom (v1) --- drivers/gpu/drm/i915/gt/intel_migrate.c | 34 - 1 file changed, 17 insertions(+), 17

[Intel-gfx] [PATCH v9 4/9] drm/i915/gt: Pass the -EINVAL when emit_pte doesn't update any PTE

2022-04-05 Thread Ramalingam C
When emit_pte doesn't update any PTE with return value as 0, interpret it as -EINVAL. v2: Add missing goto [Thomas] Signed-off-by: Ramalingam C --- drivers/gpu/drm/i915/gt/intel_migrate.c | 6 +- 1 file changed, 5 insertions(+), 1 deletion(-) diff --git a/drivers/gpu/drm/i9

[Intel-gfx] [PATCH v9 2/9] drm/i915/gt: Use XY_FAST_COLOR_BLT to clear obj on graphics ver 12+

2022-04-05 Thread Ramalingam C
-off-by: Ramalingam C Signed-off-by: Chris Wilson Reviewed-by: Thomas Hellstrom --- drivers/gpu/drm/i915/gt/intel_gpu_commands.h | 5 +++ drivers/gpu/drm/i915/gt/intel_migrate.c | 43 +--- 2 files changed, 43 insertions(+), 5 deletions(-) diff --git a/drivers/gpu/drm/i915

[Intel-gfx] [PATCH v9 1/9] drm/i915/gt: use engine instance directly for offset

2022-04-05 Thread Ramalingam C
To make it uniform across copy and clear, use the engine offset directly to calculate the offset in the cmd forming for emit_clear. Signed-off-by: Ramalingam C Reviewed-by: Thomas Hellstrom --- drivers/gpu/drm/i915/gt/intel_migrate.c | 11 --- 1 file changed, 4 insertions(+), 7

[Intel-gfx] [PATCH v9 0/9] drm/i915/ttm: Evict and restore of compressed object

2022-04-05 Thread Ramalingam C
ta is done through a special cmd called XY_CTRL_SURF_COPY_BLT v8 and v9: New patch for return value fix Fix a return error code Test-with: 20220405141050.16037-1-ramalinga...@intel.com Ramalingam C (9): drm/i915/gt: use engine instance directly for offset drm/i915/gt: Use XY_FAST_COLOR_B

[Intel-gfx] [PATCH v8 9/9] drm/i915/migrate: Evict and restore the flatccs capable lmem obj

2022-04-05 Thread Ramalingam C
op as main memory [Thomas] v4: changes for emit_copy_ccs v5: handle non-flat-ccs scenario Signed-off-by: Ramalingam C Reviewed-by: Thomas Hellstrom --- drivers/gpu/drm/i915/gt/intel_migrate.c | 164 +++- 1 file changed, 160 insertions(+), 4 deletions(-) diff --git a/drivers/gp

[Intel-gfx] [PATCH v8 8/9] drm/i915/gem: Add extra pages in ttm_tt for ccs data

2022-04-05 Thread Ramalingam C
when obj's placement is lmem only v4: GEM_BUG_ON if the ttm->num_pages > obj page size [Thomas] Signed-off-by: Ramalingam C cc: Christian Koenig cc: Hellstrom Thomas Reviewed-by: Thomas Hellstrom Reviewed-by: Nirmoy Das --- drivers/gpu/drm/i915/gem/i915_gem

[Intel-gfx] [PATCH v8 7/9] drm/i915/selftest_migrate: Check CCS meta data clear

2022-04-05 Thread Ramalingam C
Extend the live migrate selftest, to verify the ccs surface clearing during the Flat-CCS capable lmem obj clear. v2: Look at right places for ccs data [Thomas] Signed-off-by: Ramalingam C Reviewed-by: Thomas Hellstrom --- drivers/gpu/drm/i915/gt/selftest_migrate.c | 250

[Intel-gfx] [PATCH v8 6/9] drm/i915/selftest_migrate: Consider the possible roundup of size

2022-04-05 Thread Ramalingam C
Consider the possible round up happened at obj size alignment to min_page_size during the obj allocation. Signed-off-by: Ramalingam C Reviewed-by: Thomas Hellstrom --- drivers/gpu/drm/i915/gt/selftest_migrate.c | 3 +++ 1 file changed, 3 insertions(+) diff --git a/drivers/gpu/drm/i915/gt

[Intel-gfx] [PATCH v8 4/9] drm/i915/gt: Pass the -EINVAL when emit_pte doesn't update any PTE

2022-04-05 Thread Ramalingam C
When emit_pte doesn't update any PTE with return value as 0, interpret it as -EINVAL. Signed-off-by: Ramalingam C --- drivers/gpu/drm/i915/gt/intel_migrate.c | 4 +++- 1 file changed, 3 insertions(+), 1 deletion(-) diff --git a/drivers/gpu/drm/i915/gt/intel_migrate.c b/drivers/gpu/drm/i9

[Intel-gfx] [PATCH v8 5/9] drm/i915/gt: Clear compress metadata for Flat-ccs objects

2022-04-05 Thread Ramalingam C
] only one ctrl surf cmd is used as size of lmem is <=8M [Thomas] Signed-off-by: Ramalingam C Signed-off-by: Ayaz A Siddiqui Reviewed-by: Thomas Hellstrom --- drivers/gpu/drm/i915/gt/intel_gpu_commands.h | 16 +++ drivers/gpu/drm/i915/gt/intel_migrate.c | 137 ++-

[Intel-gfx] [PATCH v8 3/9] drm/i915/gt: Optimize the migration and clear loop

2022-04-05 Thread Ramalingam C
Move the static calculations out of the loops for copy and clear. v2: Fix the loss of proper error code on emit_pte Signed-off-by: Ramalingam C Reviewed-by: Thomas Hellstrom (v1) --- drivers/gpu/drm/i915/gt/intel_migrate.c | 34 - 1 file changed, 17 insertions(+), 17

[Intel-gfx] [PATCH v8 2/9] drm/i915/gt: Use XY_FAST_COLOR_BLT to clear obj on graphics ver 12+

2022-04-05 Thread Ramalingam C
-off-by: Ramalingam C Signed-off-by: Chris Wilson Reviewed-by: Thomas Hellstrom --- drivers/gpu/drm/i915/gt/intel_gpu_commands.h | 5 +++ drivers/gpu/drm/i915/gt/intel_migrate.c | 43 +--- 2 files changed, 43 insertions(+), 5 deletions(-) diff --git a/drivers/gpu/drm/i915

[Intel-gfx] [PATCH v8 1/9] drm/i915/gt: use engine instance directly for offset

2022-04-05 Thread Ramalingam C
To make it uniform across copy and clear, use the engine offset directly to calculate the offset in the cmd forming for emit_clear. Signed-off-by: Ramalingam C Reviewed-by: Thomas Hellstrom --- drivers/gpu/drm/i915/gt/intel_migrate.c | 11 --- 1 file changed, 4 insertions(+), 7

[Intel-gfx] [PATCH v8 0/9] drm/i915/ttm: Evict and restore of compressed object

2022-04-05 Thread Ramalingam C
ta is done through a special cmd called XY_CTRL_SURF_COPY_BLT v8: New patch for return value fix Fix a return error code Test-with: 20220405141050.16037-1-ramalinga...@intel.com Ramalingam C (9): drm/i915/gt: use engine instance directly for offset drm/i915/gt: Use XY_FAST_COLOR_BLT to

Re: [Intel-gfx] [PATCH v7 3/9] drm/i915/gt: Optimize the migration and clear loop

2022-04-05 Thread Ramalingam C
On 2022-03-29 at 18:53:42 +0530, Balasubramani Vivekanandan wrote: > On 29.03.2022 00:37, Ramalingam C wrote: > > Move the static calculations out of the loops for copy and clear. > > > > Signed-off-by: Ramalingam C > > Reviewed-by: Thomas Hellström > >

Re: [Intel-gfx] [PATCH v7 7/9] drm/ttm: Add a parameter to add extra pages into ttm_tt

2022-04-01 Thread Ramalingam C
4.22 um 16:28 schrieb Ramalingam C: > > Christian, Joonas and vivi > > > > Once the premerge results are greeen, if this patch can be merged into > > drm-intel-gt-next along with other patches could you please ack the > > request to merge into drm-intel-gt-next? > > &g

Re: [Intel-gfx] ✗ Fi.CI.IGT: failure for drm/i915/ttm: Evict and restore of compressed object (rev7)

2022-04-01 Thread Ramalingam C
On 2022-04-01 at 15:59:01 +, Patchwork wrote: > == Series Details == > > Series: drm/i915/ttm: Evict and restore of compressed object (rev7) > URL : https://patchwork.freedesktop.org/series/101106/ > State : failure > > == Summary == > > CI Bug Log - changes from CI_DRM_11438_full -> Patch

Re: [Intel-gfx] [PATCH v7 7/9] drm/ttm: Add a parameter to add extra pages into ttm_tt

2022-04-01 Thread Ramalingam C
Christian, Joonas and vivi Once the premerge results are greeen, if this patch can be merged into drm-intel-gt-next along with other patches could you please ack the request to merge into drm-intel-gt-next? Thanks Ram On 2022-04-01 at 18:07:49 +0530, Ramalingam C wrote: > Add a parameter cal

[Intel-gfx] [PATCH v7 9/9] drm/i915/migrate: Evict and restore the flatccs capable lmem obj

2022-04-01 Thread Ramalingam C
op as main memory [Thomas] v4: changes for emit_copy_ccs v5: handle non-flat-ccs scenario Signed-off-by: Ramalingam C Reviewed-by: Thomas Hellstrom --- drivers/gpu/drm/i915/gt/intel_migrate.c | 164 +++- 1 file changed, 160 insertions(+), 4 deletions(-) diff --git a/drivers/gp

[Intel-gfx] [PATCH v7 7/9] drm/ttm: Add a parameter to add extra pages into ttm_tt

2022-04-01 Thread Ramalingam C
Add a parameter called "extra_pages" for ttm_tt_init, to indicate that driver needs extra pages in ttm_tt. v2: Used imperative wording [Thomas and Christian] Signed-off-by: Ramalingam C cc: Christian Koenig cc: Hellstrom Thomas Reviewed-by: Thomas Hellstrom Reviewed-by: Chris

[Intel-gfx] [PATCH v7 8/9] drm/i915/gem: Add extra pages in ttm_tt for ccs data

2022-04-01 Thread Ramalingam C
when obj's placement is lmem only v4: GEM_BUG_ON if the ttm->num_pages > obj page size [Thomas] Signed-off-by: Ramalingam C cc: Christian Koenig cc: Hellstrom Thomas Reviewed-by: Thomas Hellstrom Reviewed-by: Nirmoy Das --- drivers/gpu/drm/i915/gem/i915_gem

[Intel-gfx] [PATCH v7 6/9] drm/i915/selftest_migrate: Check CCS meta data clear

2022-04-01 Thread Ramalingam C
Extend the live migrate selftest, to verify the ccs surface clearing during the Flat-CCS capable lmem obj clear. v2: Look at right places for ccs data [Thomas] Signed-off-by: Ramalingam C Reviewed-by: Thomas Hellstrom --- drivers/gpu/drm/i915/gt/selftest_migrate.c | 250

[Intel-gfx] [PATCH v7 5/9] drm/i915/selftest_migrate: Consider the possible roundup of size

2022-04-01 Thread Ramalingam C
Consider the possible round up happened at obj size alignment to min_page_size during the obj allocation. Signed-off-by: Ramalingam C Reviewed-by: Thomas Hellstrom --- drivers/gpu/drm/i915/gt/selftest_migrate.c | 3 +++ 1 file changed, 3 insertions(+) diff --git a/drivers/gpu/drm/i915/gt

[Intel-gfx] [PATCH v7 4/9] drm/i915/gt: Clear compress metadata for Flat-ccs objects

2022-04-01 Thread Ramalingam C
] only one ctrl surf cmd is used as size of lmem is <=8M [Thomas] Signed-off-by: Ramalingam C Signed-off-by: Ayaz A Siddiqui Reviewed-by: Thomas Hellstrom --- drivers/gpu/drm/i915/gt/intel_gpu_commands.h | 16 +++ drivers/gpu/drm/i915/gt/intel_migrate.c | 137 ++-

[Intel-gfx] [PATCH v7 3/9] drm/i915/gt: Optimize the migration and clear loop

2022-04-01 Thread Ramalingam C
Move the static calculations out of the loops for copy and clear. Signed-off-by: Ramalingam C Reviewed-by: Thomas Hellstrom --- drivers/gpu/drm/i915/gt/intel_migrate.c | 40 - 1 file changed, 19 insertions(+), 21 deletions(-) diff --git a/drivers/gpu/drm/i915/gt

[Intel-gfx] [PATCH v7 2/9] drm/i915/gt: Use XY_FAST_COLOR_BLT to clear obj on graphics ver 12+

2022-04-01 Thread Ramalingam C
-off-by: Ramalingam C Signed-off-by: Chris Wilson Reviewed-by: Thomas Hellstrom --- drivers/gpu/drm/i915/gt/intel_gpu_commands.h | 5 +++ drivers/gpu/drm/i915/gt/intel_migrate.c | 43 +--- 2 files changed, 43 insertions(+), 5 deletions(-) diff --git a/drivers/gpu/drm/i915

[Intel-gfx] [PATCH v7 1/9] drm/i915/gt: use engine instance directly for offset

2022-04-01 Thread Ramalingam C
To make it uniform across copy and clear, use the engine offset directly to calculate the offset in the cmd forming for emit_clear. Signed-off-by: Ramalingam C Reviewed-by: Thomas Hellstrom --- drivers/gpu/drm/i915/gt/intel_migrate.c | 11 --- 1 file changed, 4 insertions(+), 7

[Intel-gfx] [PATCH v7 0/9] drm/i915/ttm: Evict and restore of compressed object

2022-04-01 Thread Ramalingam C
forms Resending with updated igt version for test with. Test-with: 20220401074527.15709-2-ramalinga...@intel.com Ramalingam C (9): drm/i915/gt: use engine instance directly for offset drm/i915/gt: Use XY_FAST_COLOR_BLT to clear obj on graphics ver 12+ drm/i915/gt: Optimize the migration and clear

[Intel-gfx] [PATCH v7 8/9] drm/i915/gem: Add extra pages in ttm_tt for ccs data

2022-03-28 Thread Ramalingam C
when obj's placement is lmem only v4: GEM_BUG_ON if the ttm->num_pages > obj page size [Thomas] Signed-off-by: Ramalingam C cc: Christian Koenig cc: Hellstrom Thomas Reviewed-by: Thomas Hellstrom Reviewed-by: Nirmoy Das --- drivers/gpu/drm/i915/gem/i915_gem

[Intel-gfx] [PATCH v7 9/9] drm/i915/migrate: Evict and restore the flatccs capable lmem obj

2022-03-28 Thread Ramalingam C
op as main memory [Thomas] v4: changes for emit_copy_ccs v5: handle non-flat-ccs scenario Signed-off-by: Ramalingam C --- drivers/gpu/drm/i915/gt/intel_migrate.c | 164 +++- 1 file changed, 160 insertions(+), 4 deletions(-) diff --git a/drivers/gpu/drm/i915/gt/intel_migrate

[Intel-gfx] [PATCH v7 6/9] drm/i915/selftest_migrate: Check CCS meta data clear

2022-03-28 Thread Ramalingam C
Extend the live migrate selftest, to verify the ccs surface clearing during the Flat-CCS capable lmem obj clear. v2: Look at right places for ccs data [Thomas] Signed-off-by: Ramalingam C --- drivers/gpu/drm/i915/gt/selftest_migrate.c | 250 ++--- 1 file changed, 222

[Intel-gfx] [PATCH v7 7/9] drm/ttm: Add a parameter to add extra pages into ttm_tt

2022-03-28 Thread Ramalingam C
Add a parameter called "extra_pages" for ttm_tt_init, to indicate that driver needs extra pages in ttm_tt. v2: Used imperative wording [Thomas and Christian] Signed-off-by: Ramalingam C cc: Christian Koenig cc: Hellstrom Thomas Reviewed-by: Thomas Hellstrom Reviewed-by: Chris

[Intel-gfx] [PATCH v7 3/9] drm/i915/gt: Optimize the migration and clear loop

2022-03-28 Thread Ramalingam C
Move the static calculations out of the loops for copy and clear. Signed-off-by: Ramalingam C Reviewed-by: Thomas Hellström --- drivers/gpu/drm/i915/gt/intel_migrate.c | 44 - 1 file changed, 21 insertions(+), 23 deletions(-) diff --git a/drivers/gpu/drm/i915/gt

[Intel-gfx] [PATCH v7 4/9] drm/i915/gt: Clear compress metadata for Flat-ccs objects

2022-03-28 Thread Ramalingam C
] only one ctrl surf cmd is used as size of lmem is <=8M [Thomas] Signed-off-by: Ramalingam C Signed-off-by: Ayaz A Siddiqui --- drivers/gpu/drm/i915/gt/intel_gpu_commands.h | 16 +++ drivers/gpu/drm/i915/gt/intel_migrate.c | 137 ++- 2 files changed, 152 inserti

[Intel-gfx] [PATCH v7 5/9] drm/i915/selftest_migrate: Consider the possible roundup of size

2022-03-28 Thread Ramalingam C
Consider the possible round up happened at obj size alignment to min_page_size during the obj allocation. Signed-off-by: Ramalingam C --- drivers/gpu/drm/i915/gt/selftest_migrate.c | 3 +++ 1 file changed, 3 insertions(+) diff --git a/drivers/gpu/drm/i915/gt/selftest_migrate.c b/drivers/gpu

[Intel-gfx] [PATCH v7 2/9] drm/i915/gt: Use XY_FAST_COLOR_BLT to clear obj on graphics ver 12+

2022-03-28 Thread Ramalingam C
-off-by: Ramalingam C Signed-off-by: Chris Wilson Reviewed-by: Thomas Hellstrom --- drivers/gpu/drm/i915/gt/intel_gpu_commands.h | 5 +++ drivers/gpu/drm/i915/gt/intel_migrate.c | 43 +--- 2 files changed, 43 insertions(+), 5 deletions(-) diff --git a/drivers/gpu/drm/i915

[Intel-gfx] [PATCH v7 0/9] drm/i915/ttm: Evict and restore of compressed object

2022-03-28 Thread Ramalingam C
Test-with: 20220314051432.15785-1-ramalinga...@intel.com Ramalingam C (9): drm/i915/gt: use engine instance directly for offset drm/i915/gt: Use XY_FAST_COLOR_BLT to clear obj on graphics ver 12+ drm/i915/gt: Optimize the migration and clear loop drm/i915/gt: Clear compress metadata for Fla

  1   2   3   4   5   6   7   8   9   10   >