On Thu, 2019-08-29 at 13:52 -0700, Matt Roper wrote:
> When choosing a low resolution mode to switch to, we search the
> connector's mode list for a mode that's small enough that a plane
> positioned in the bottom left corner of the screen in the original mode
> will be fully offscreen in the new,
On Thu, 2019-08-29 at 09:47 -0700, Matt Roper wrote:
> This test performs display updates via COMMIT_ATOMIC, but fails to check
> that the platform being tested actually supports atomic. This causes
> failures on some of our older pre-gen5 platforms.
>
> Bugzilla: https://bugs.freedesktop.org/sho
On Wed, 2019-08-28 at 19:40 +0300, Ville Syrjälä wrote:
> On Fri, Aug 23, 2019 at 12:49:46PM +0300, Simon Ser wrote:
> > This patch adds a line with the port name to connectors in
> > debugfs/i915_debug_info. If the port is Type-C, the Type-C port number is
> > printed too.
> >
> > Signed-off-by:
On Tue, 2019-08-27 at 17:14 +0100, Chris Wilson wrote:
> e.g. benchmarks/gem_wsim.c:2936:4: warning: absolute value function ‘abs’
> given an argument of type ‘long int’ but has parameter of type ‘int’ which
> may cause truncation of value [-Wabsolute-value]
>
> Signed-off-by: Chris Wilson
Rev
On Thu, 2019-07-18 at 12:15 +0100, liviu.du...@arm.com wrote:
> On Thu, Jul 18, 2019 at 09:56:39AM +0000, Ser, Simon wrote:
> > On Thu, 2019-07-18 at 10:49 +0100, liviu.du...@arm.com wrote:
> > > On Wed, Jul 17, 2019 at 11:46:39AM +, Ser, Simon wrote:
> > > >
On Thu, 2019-07-18 at 10:49 +0100, liviu.du...@arm.com wrote:
> On Wed, Jul 17, 2019 at 11:46:39AM +0000, Ser, Simon wrote:
> > Thanks for the clarification!
> >
> > On Tue, 2019-07-16 at 16:22 +0100, liviu.du...@arm.com wrote:
> > > > > > +static void
On Tue, 2019-07-16 at 22:47 -0300, Rodrigo Siqueira wrote:
> On 07/12, Ser, Simon wrote:
> > So, to test these last two patches we'd need specific hardware right?
> > Because VKMS doesn't support cloning yet (does it?).
>
> hmmm... actually, VKMS successfully pas
On Tue, 2019-07-16 at 22:21 -0300, Rodrigo Siqueira wrote:
> On 07/12, Ser, Simon wrote:
> > On Thu, 2019-07-11 at 23:44 -0300, Rodrigo Siqueira wrote:
> > > On 07/10, Ser, Simon wrote:
> > > > Hi,
> > > >
> > > > Thanks for the patch! Here
Thanks for the clarification!
On Tue, 2019-07-16 at 16:22 +0100, liviu.du...@arm.com wrote:
> > > > +static void invalid_out_fence(igt_output_t *output, igt_fb_t
> > > > *valid_fb, igt_fb_t *invalid_fb)
> > > > +{
> > > > + int i, ret;
> > > > + int32_t out_fence;
> > > > + stru
So, to test these last two patches we'd need specific hardware right?
Because VKMS doesn't support cloning yet (does it?).
What kind of hardware supports cloned writeback outputs? I have a
Raspberry Pi which supports writeback via VC4, but I don't think it has
writeback cloning. I'm also not willi
Mostly looks good, here are a few comments.
On Wed, 2019-06-12 at 23:17 -0300, Brian Starkey wrote:
> Add a test which makes commits using the writeback connector, and
> checks the output buffer hash to make sure it is/isn't written as
> appropriate.
>
> Signed-off-by: Brian Starkey
> ---
> tes
On Thu, 2019-07-11 at 23:49 -0300, Rodrigo Siqueira wrote:
> On 07/10, Ser, Simon wrote:
> > On Wed, 2019-07-10 at 15:30 +0000, Ser, Simon wrote:
> > > Mostly LGTM, here are a few nits.
> > >
> > > On Wed, 2019-06-12 at 23:17 -0300, Brian Starkey wrote:
>
On Thu, 2019-07-11 at 23:44 -0300, Rodrigo Siqueira wrote:
> On 07/10, Ser, Simon wrote:
> > Hi,
> >
> > Thanks for the patch! Here are a few comments.
> >
> > For bonus points, it would be nice to add igt_describe descriptions of
> > each sub-test.
>
On Wed, 2019-07-10 at 15:30 +, Ser, Simon wrote:
> Mostly LGTM, here are a few nits.
>
> On Wed, 2019-06-12 at 23:17 -0300, Brian Starkey wrote:
> > To use writeback buffers as a CRC source, we need to be able to hash
> > them. Implement a simple FVA-1a hashing rou
Mostly LGTM, here are a few nits.
On Wed, 2019-06-12 at 23:17 -0300, Brian Starkey wrote:
> To use writeback buffers as a CRC source, we need to be able to hash
> them. Implement a simple FVA-1a hashing routine for this purpose.
>
> Doing a bytewise hash on the framebuffer directly can be very sl
Hi,
Thanks for the patch! Here are a few comments.
For bonus points, it would be nice to add igt_describe descriptions of
each sub-test.
On Wed, 2019-06-12 at 23:16 -0300, Brian Starkey wrote:
> Add tests for the WRITEBACK_PIXEL_FORMATS, WRITEBACK_OUT_FENCE_PTR and
> WRITEBACK_FB_ID properties o
On Wed, 2019-06-12 at 23:16 -0300, Brian Starkey wrote:
> Add support in igt_kms for writeback connectors, with the ability
> to attach framebuffers.
>
> v5: Rebase and add DRM_CLIENT_CAP_WRITEBACK_CONNECTORS before
> drmModeGetResources()
>
> Signed-off-by: Brian Starkey
> [rebased and updated
On Tue, 2019-07-09 at 11:32 -0300, Rodrigo Siqueira wrote:
> On Wed, Jul 3, 2019 at 9:15 AM Ser, Simon wrote:
> > On Tue, 2019-06-18 at 18:56 -0300, Rodrigo Siqueira wrote:
> > > On Thu, Jun 13, 2019 at 11:54 AM Liviu Dudau wrote:
> > > > On Wed, Jun 12, 2019 at 1
On Tue, 2019-06-18 at 18:56 -0300, Rodrigo Siqueira wrote:
> On Thu, Jun 13, 2019 at 11:54 AM Liviu Dudau wrote:
> > On Wed, Jun 12, 2019 at 11:16:02PM -0300, Brian Starkey wrote:
> > > Add support in igt_kms for writeback connectors, with the ability
> > > to attach framebuffers.
> > >
> > > v5:
On Thu, 2019-06-27 at 14:30 +0100, Guillaume Tucker wrote:
> Use the libatomic1:mips package only in the Debian Stretch Docker
> image for MIPS and add Gitlab CI step to run tests on MIPS.
>
> Signed-off-by: Guillaume Tucker
And pushed:
To gitlab.freedesktop.org:drm/igt-gpu-tools.git
3c4edeb
On Thu, 2019-06-27 at 16:19 +0300, Arkadiusz Hiler wrote:
> On Thu, Jun 27, 2019 at 04:14:53PM +0300, Ser, Simon wrote:
> > On Thu, 2019-06-27 at 11:02 +0100, Guillaume Tucker wrote:
> > > On 27/06/2019 08:02, Ser, Simon wrote:
> > > > On Tue, 2019-06-25 at 14:08
On Thu, 2019-06-27 at 14:30 +0100, Guillaume Tucker wrote:
> Use the libatomic1:mips package only in the Debian Stretch Docker
> image for MIPS and add Gitlab CI step to run tests on MIPS.
>
> Signed-off-by: Guillaume Tucker
With this tag added:
Fixes: 439a9f5d615f ("gitlab-ci: add build for MI
On Thu, 2019-06-27 at 11:02 +0100, Guillaume Tucker wrote:
> On 27/06/2019 08:02, Ser, Simon wrote:
> > On Tue, 2019-06-25 at 14:08 +0100, Guillaume Tucker wrote:
> > > On 18/06/2019 13:42, Guillaume Tucker wrote:
> > > > Add Docker image and Gitlab CI steps to run bu
On Thu, 2019-06-27 at 08:36 +0100, Chris Wilson wrote:
> The "basic" subtests perform no verification that the read/write work,
> only function as mere API exercisers and loose benchmarks. Rename them
> to reflect that they are poor benchmarks instead.
>
> Signed-off-by: Chris Wilson
Reviewed-by
On Tue, 2019-06-25 at 14:08 +0100, Guillaume Tucker wrote:
> On 18/06/2019 13:42, Guillaume Tucker wrote:
> > Add Docker image and Gitlab CI steps to run builds and tests for
> > the
> > MIPS architecture using Debian Stretch with backports.
> >
> > Signed-off-by: Guillaume Tucker
> > ---
> >
>
On Mon, 2019-06-24 at 17:22 +0100, Guillaume Tucker wrote:
> This series replaces calls to the __sync_* functions with the more
> recent atomic_* ones defined in stdatomic.h in gem_create and
> sw_sync. It also adds dependency on libatomic when required, that is
> to say when the CPU architecture
On Mon, 2019-06-24 at 17:22 +0100, Guillaume Tucker wrote:
> Add libatomic to the Fedora docker image so it can link binaries that
> use __atomic_* functions. Also explicitly add libatomic1 to Debian
> docker images as it is needed in particular on non-x86 architectures
> for run-time linkage.
>
On Tue, 2019-06-18 at 13:27 +0100, Guillaume Tucker wrote:
> Add libatomic to the Fedora docker image so it can link binaries that
> use __atomic_* functions. Also explicitly add libatomic1 to Debian
> docker images as it is needed in particular on non-x86 architectures
> for run-time linkage.
Pe
On Tue, 2019-06-18 at 17:03 +0100, Guillaume Tucker wrote:
> On 18/06/2019 15:37, Ser, Simon wrote:
> > On Tue, 2019-06-18 at 14:59 +0100, Guillaume Tucker wrote:
> > > On 18/06/2019 14:20, Ser, Simon wrote:
> > > > On Tue, 2019-06-18 at 13:27 +0100, Guillau
On Tue, 2019-06-18 at 14:59 +0100, Guillaume Tucker wrote:
> On 18/06/2019 14:20, Ser, Simon wrote:
> > On Tue, 2019-06-18 at 13:27 +0100, Guillaume Tucker wrote:
> > > Add conditional dependency on libatomic in order to be able to use the
> > > __atomic_* functions i
On Tue, 2019-06-18 at 13:27 +0100, Guillaume Tucker wrote:
> Add conditional dependency on libatomic in order to be able to use the
> __atomic_* functions instead of the older __sync_* ones. The
> libatomic library is only needed when there aren't any native support
> on the current architecture,
On Tue, 2019-06-18 at 09:33 +0100, Guillaume Tucker wrote:
> On 14/06/2019 09:07, Ser, Simon wrote:
> > On Thu, 2019-06-13 at 14:53 +0100, Guillaume Tucker wrote:
> > > Add conditional dependency on libatomic in order to be able to use the
> > > __atomic_* functions i
On Fri, 2019-06-14 at 15:43 +0300, Petri Latvala wrote:
> On Fri, Jun 14, 2019 at 02:24:53PM +0300, Ser, Simon wrote:
> > On Fri, 2019-06-14 at 13:00 +0300, Petri Latvala wrote:
> > > On Thu, Jun 13, 2019 at 02:53:20PM +0100, Guillaume Tucker wrote:
> > > > Add libato
On Fri, 2019-06-14 at 13:00 +0300, Petri Latvala wrote:
> On Thu, Jun 13, 2019 at 02:53:20PM +0100, Guillaume Tucker wrote:
> > Add libatomic to the Fedora docker image so it can link binaries that
> > use __atomic_* functions. Also explicitly add libatomic1 to Debian
> > docker images even though
On Thu, 2019-06-13 at 14:53 +0100, Guillaume Tucker wrote:
> Replace calls to the older __sync_* functions with the new atomic_*
> standard ones to be consistent with other tests and improve
> portability across CPU architectures. Add dependency of sw_sync on
> libatomic.
>
> Signed-off-by: Guill
On Thu, 2019-06-13 at 14:53 +0100, Guillaume Tucker wrote:
> This fixes builds on some architectures, in particular MIPS which
> doesn't have __sync_add_and_fetch_8 and __sync_val_compare_and_swap_8
> for 64-bit variable handling.
>
> * replace calls to the older __sync_* functions with the new at
On Thu, 2019-06-13 at 14:53 +0100, Guillaume Tucker wrote:
> Add libatomic to the Fedora docker image so it can link binaries that
> use __atomic_* functions. Also explicitly add libatomic1 to Debian
> docker images even though it's already installed as a dependency.
>
> Signed-off-by: Guillaume
On Thu, 2019-06-13 at 14:53 +0100, Guillaume Tucker wrote:
> Add conditional dependency on libatomic in order to be able to use the
> __atomic_* functions instead of the older __sync_* ones. The
> libatomic library is only needed when there aren't any native support
> on the current architecture,
On Thu, 2019-06-13 at 13:55 +0100, Guillaume Tucker wrote:
> On 06/06/2019 08:18, Ser, Simon wrote:
> > On Mon, 2019-06-03 at 12:54 +0100, Guillaume Tucker wrote:
> > > Add dependency to libatomic in order to be able to use the __atomic_*
> > > functions instead of the
On Thu, 2019-06-06 at 12:28 -0300, Rodrigo Siqueira wrote:
> On 06/06, Ser, Simon wrote:
> > On Tue, 2019-06-04 at 23:30 -0300, Rodrigo Siqueira wrote:
> > > The kms_flip test relies on VBlank support, and this situation may
> > > exclude some virtual drivers to take adv
On Tue, 2019-06-04 at 23:30 -0300, Rodrigo Siqueira wrote:
> The kms_flip test relies on VBlank support, and this situation may
> exclude some virtual drivers to take advantage of this set of tests.
> This commit adds a mechanism that checks if a module has VBlank. If the
> target module has VBlank
On Thu, 2019-06-06 at 10:21 +0300, Arkadiusz Hiler wrote:
> On Mon, Jun 03, 2019 at 12:54:48PM +0100, Guillaume Tucker wrote:
> > Add libatomic to the Fedora docker image so it can link binaries that
> > use __atomic_* functions.
> >
> > Signed-off-by: Guillaume Tucker
> > ---
> > Dockerfile.fed
On Mon, 2019-06-03 at 12:54 +0100, Guillaume Tucker wrote:
> Replace calls to the older __sync_* functions with the new __atomic_*
> standard ones. This fixes builds on some architectures, in particular
> MIPS which doesn't have __sync_add_and_fetch_8 and
> __sync_val_compare_and_swap_8 for 64-bit
On Mon, 2019-06-03 at 12:54 +0100, Guillaume Tucker wrote:
> Add dependency to libatomic in order to be able to use the __atomic_*
> functions instead of the older __sync_* ones. This is to enable
> atomic operations on a wider number of architectures including MIPS.
Thanks for your patch! I have
On Mon, 2019-06-03 at 17:08 +0200, Daniel Vetter wrote:
> On Mon, Jun 03, 2019 at 11:50:53AM +0200, Michel Dänzer wrote:
> > On 2019-05-21 9:52 a.m., Daniel Vetter wrote:
> > > On Tue, May 21, 2019 at 8:55 AM Pekka Paalanen
> > > wrote:
> > > > On Mon, 20 May 2019 18:11:07 +0200
> > > > Daniel Ve
On Fri, 2019-05-24 at 09:33 +0100, Chris Wilson wrote:
> Quoting Tvrtko Ursulin (2019-05-24 09:20:47)
> > On 24/05/2019 08:25, Chris Wilson wrote:
> > > Apparently VLA structs (e.g. struct { int array[count] }) is a gcc
> > > extension that clang refuses to support as handling memory layout is too
On Fri, 2019-05-24 at 09:20 +0100, Tvrtko Ursulin wrote:
> On 24/05/2019 08:25, Chris Wilson wrote:
> > Apparently VLA structs (e.g. struct { int array[count] }) is a gcc
> > extension that clang refuses to support as handling memory layout is too
> > difficult for it.
> >
> > Move the on-stack VL
On Fri, 2019-05-24 at 08:25 +0100, Chris Wilson wrote:
> Apparently VLA structs (e.g. struct { int array[count] }) is a gcc
> extension that clang refuses to support as handling memory layout is too
> difficult for it.
>
> Move the on-stack VLA to the heap.
IMHO using an upper bound would be much
Hi Rodrigo,
On Sun, 2019-05-19 at 20:00 -0300, Rodrigo Siqueira wrote:
> The function __kms_addfb() and drmModeAddFB2WithModifiers() have a
> similar code. Due to this similarity, this commit replaces all the
> occurrences of __kms_addfb() by drmModeAddFB2WithModifiers() and adds
> the required a
On Thu, 2019-05-16 at 19:58 +0100, Chris Wilson wrote:
> To avoid hitting the same rut on each benchmark run, start with a new
> random seed. To allow hitting the same rut again, let it be specified
> by the user.
>
> Signed-off-by: Chris Wilson
> Cc: Tvrtko Ursulin
> ---
> benchmarks/gem_wsim.
On Tue, 2019-05-14 at 11:02 +0300, Pekka Paalanen wrote:
> On Mon, 13 May 2019 11:34:58 +0200
> Daniel Vetter wrote:
>
> > On Mon, May 13, 2019 at 11:02 AM Paul Kocialkowski
> > wrote:
> > > Hi,
> > >
> > > On Fri, 2019-05-10 at 16:54 +0200, Daniel Vetter wrote:
> > > > On Fri, May 10, 2019 a
On Mon, 2019-05-13 at 17:04 +0200, Daniel Vetter wrote:
> On Mon, May 13, 2019 at 10:11:01AM +0000, Ser, Simon wrote:
> > On Mon, 2019-05-13 at 11:34 +0200, Daniel Vetter wrote:
> > > On Mon, May 13, 2019 at 11:02 AM Paul Kocialkowski
> > > wrote:
> > > >
On Mon, 2019-05-13 at 11:34 +0200, Daniel Vetter wrote:
> On Mon, May 13, 2019 at 11:02 AM Paul Kocialkowski
> wrote:
> > Hi,
> >
> > On Fri, 2019-05-10 at 16:54 +0200, Daniel Vetter wrote:
> > > On Fri, May 10, 2019 at 2:12 PM Paul Kocialkowski
> > > wrote:
> > > > Hi,
> > > >
> > > > On Tue,
53 matches
Mail list logo
