Re: [Intel-gfx] [PATCH v6] drm/i915: respect the VBT minimum backlight brightness again

2015-11-12 Thread Shih-Yuan Lee (FourDollars)
You may need to put "drm.debug=0xe" into the kernel parameter and reboot the system to collect some system log. Did you check the brightness value after you change it? On Thu, Nov 12, 2015 at 4:40 PM, Stéphane ANCELOT <sance...@free.fr> wrote: > On 12/11/2015 09:28, Shih-Yu

Re: [Intel-gfx] [PATCH v6] drm/i915: respect the VBT minimum backlight brightness again

2015-11-12 Thread Shih-Yuan Lee (FourDollars)
mply the documentation is lacking > > Regards, > S.Ancelot > > > On 12/11/2015 06:43, Shih-Yuan Lee (FourDollars) wrote: > >> There was a wonderful period after >> >> commit 6dda730e55f412a6dfb181cae6784822ba463847 >> Author: Jani Nikula >>

[Intel-gfx] [PATCH v7] drm/i915: A better backlight class brightness range.

2015-11-12 Thread Shih-Yuan Lee (FourDollars)
Expose the whole valid PWM brightness range to the backlight class and respect the VBT minimum backlight brightness. Signed-off-by: Shih-Yuan Lee (FourDollars) <sy...@canonical.com> --- drivers/gpu/drm/i915/intel_panel.c | 31 ++- 1 file changed, 14 insertions(

[Intel-gfx] [PATCH v7] drm/i915: A better backlight class brightness range.

2015-11-12 Thread Shih-Yuan Lee (FourDollars)
re is no duplicate and 37 matched the corresponding PWM min by VBT min. Taking VBT min 255 and PWD max 937 as an example. The corresponding PWM min will be 937 because of round(255 * 937 / 255). sysfs : PWM --- 0 -> 0 (off) 1 -> 937 Even for the corner case, it still work

[Intel-gfx] [PATCH v5] drm/i915: Set backlight class max to 100 and respect the VBT minimum again.

2015-11-11 Thread Shih-Yuan Lee (FourDollars)
his commit makes that backlight class 1 brightness means the PWM min and backlight class 100 brightness means the PWM max. Signed-off-by: Shih-Yuan Lee (FourDollars) <sy...@canonical.com> --- drivers/gpu/drm/i915/intel_panel.c | 24 ++-- 1 file changed, 18 insertions

Re: [Intel-gfx] [PATCH v4] drm/i915: Set brightness maximum to a fixed value 100.

2015-11-11 Thread Shih-Yuan Lee (FourDollars)
On Wed, Nov 11, 2015 at 02:05:57PM +0200, Jani Nikula wrote: > On Wed, 11 Nov 2015, "Shih-Yuan Lee (FourDollars)" <sy...@canonical.com> > wrote: > > Take Dell XPS 13 (2015) as an example. The vbt min 10 out of [0..255]. > > The PWM max is 937 so the corre

[Intel-gfx] [PATCH v6] drm/i915: respect the VBT minimum backlight brightness again

2015-11-11 Thread Shih-Yuan Lee (FourDollars)
f-by: Shih-Yuan Lee (FourDollars) <sy...@canonical.com> --- drivers/gpu/drm/i915/intel_panel.c | 26 ++ 1 file changed, 18 insertions(+), 8 deletions(-) diff --git a/drivers/gpu/drm/i915/intel_panel.c b/drivers/gpu/drm/i915/intel_panel.c index b05c6d9..8efa199 100644 -

Re: [Intel-gfx] [PATCH v2] drm/i915: Respect the brightness range from VBT.

2015-11-10 Thread Shih-Yuan Lee (FourDollars)
On Tue, Nov 10, 2015 at 02:57:39PM +0200, Jani Nikula wrote: > On Tue, 10 Nov 2015, "Shih-Yuan Lee (FourDollars)" <sy...@canonical.com> > wrote: > > Apparently you are not aware of GNOME has used 1 as the minimum brightness > >

[Intel-gfx] [PATCH v2] drm/i915: Respect the brightness range from VBT.

2015-11-10 Thread Shih-Yuan Lee (FourDollars)
is the lowest PWM brightness. We should make users able to use it for the extreme power saving reason and users can still see the display. Signed-off-by: Shih-Yuan Lee (FourDollars) <sy...@canonical.com> --- drivers/gpu/drm/i915/intel_panel.c | 10 +- 1 file changed, 5 insertions(+), 5 del

Re: [Intel-gfx] [PATCH v2] drm/i915: Respect the brightness range from VBT.

2015-11-10 Thread Shih-Yuan Lee (FourDollars)
On Tue, Nov 10, 2015 at 12:15:48PM +0200, Jani Nikula wrote: > On Tue, 10 Nov 2015, "Shih-Yuan Lee (FourDollars)" <sy...@canonical.com> > wrote: > > Taking Dell XPS 13 (2015) as an example. The lowest PWM brightness is 10 > > and the highest PWM brightness is 93

[Intel-gfx] [PATCH v4] drm/i915: Set brightness maximum to a fixed value 100.

2015-11-10 Thread Shih-Yuan Lee (FourDollars)
Take Dell XPS 13 (2015) as an example. The vbt min 10 out of [0..255]. The PWM max is 937 so the corresponding PWM min is 37 (10*937/256). This commit makes the sysfs brightness 1 map to the PWM brightness 37 and 100 map to the PWM brightness 937. Signed-off-by: Shih-Yuan Lee (FourDollars) <

[Intel-gfx] [PATCH v3] drm/i915: Set brightness maximum to a fixed value 100.

2015-11-10 Thread Shih-Yuan Lee (FourDollars)
Take Dell XPS 13 (2015) as an example. The vbt min 10 out of [0..255]. The PWM max is 937 so the corresponding PWM min is 37 (10*937/256). This commit makes the sysfs brightness 1 map to the PWM brightness 37 and 100 map to the PWM brightness 937. Signed-off-by: Shih-Yuan Lee (FourDollars) <

Re: [Intel-gfx] [PATCH] drm/i915: A better maximum brightness for users.

2015-11-09 Thread Shih-Yuan Lee (FourDollars)
On Mon, Nov 9, 2015 at 8:58 PM, Jani Nikula <jani.nik...@linux.intel.com> wrote: > On Mon, 09 Nov 2015, "Shih-Yuan Lee (FourDollars)" <sy...@canonical.com> > wrote: > > On Mon, Nov 9, 2015 at 6:51 PM, Jani Nikula <jani.nik...@linux.intel.com > > > >

Re: [Intel-gfx] [PATCH] drm/i915: A better maximum brightness for users.

2015-11-09 Thread Shih-Yuan Lee (FourDollars)
; >> On Mon, 09 Nov 2015, "Shih-Yuan Lee (FourDollars)" <sy...@canonical.com> > >> wrote: > >>> The PWM brightness level of Dell XPS 13 (2015) is from 10 to 937 however > >>> the sysfs brightness level always starts from 0 so it is better to u

Re: [Intel-gfx] [PATCH] drm/i915: A better maximum brightness for users.

2015-11-09 Thread Shih-Yuan Lee (FourDollars)
On Mon, Nov 9, 2015 at 6:17 PM, Jani Nikula <jani.nik...@linux.intel.com> wrote: > On Mon, 09 Nov 2015, "Shih-Yuan Lee (FourDollars)" <sy...@canonical.com> > wrote: > > The PWM brightness level of Dell XPS 13 (2015) is from 10 to 937 however > > the sysfs

Re: [Intel-gfx] [PATCH] drm/i915: A better maximum brightness for users.

2015-11-09 Thread Shih-Yuan Lee (FourDollars)
On Mon, Nov 9, 2015 at 6:51 PM, Jani Nikula <jani.nik...@linux.intel.com> wrote: > On Mon, 09 Nov 2015, "Shih-Yuan Lee (FourDollars)" <sy...@canonical.com> > wrote: > > On Mon, Nov 9, 2015 at 6:17 PM, Jani Nikula <jani.nik...@linux.intel.com > > > >

[Intel-gfx] [PATCH] drm/i915: A better maximum brightness for users.

2015-11-08 Thread Shih-Yuan Lee (FourDollars)
-Yuan Lee (FourDollars) <sy...@canonical.com> --- drivers/gpu/drm/i915/intel_panel.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/gpu/drm/i915/intel_panel.c b/drivers/gpu/drm/i915/intel_panel.c index a24df35..697fd4d 100644 --- a/drivers/gpu/drm/i915/intel_p