Re: [Intel-gfx] [PATCH 3/5] drm/i915: Fixes to support the DP Compliance EDID tests.

2016-05-24 Thread Shubhangi Shrivastava
On Monday 23 May 2016 01:48 PM, Ander Conselvan De Oliveira wrote: On Fri, 2016-04-29 at 18:28 -0700, Manasi Navare wrote: This patch addresses a few issues from the original patch for DP Compliance EDID test support submitted by Todd Previte Do you mean commit 559be30cb74d ("drm/i915: Implem

Re: [Intel-gfx] [PATCH 3/5] drm/i915: Fixes to support the DP Compliance EDID tests.

2016-05-24 Thread Shubhangi Shrivastava
On Monday 23 May 2016 01:48 PM, Ander Conselvan De Oliveira wrote: On Fri, 2016-04-29 at 18:28 -0700, Manasi Navare wrote: This patch addresses a few issues from the original patch for DP Compliance EDID test support submitted by Todd Previte Do you mean commit 559be30cb74d ("drm/i915: Implem

[Intel-gfx] [PATCH 2/2] drm/i915: Lane count change detection

2016-05-12 Thread Shubhangi Shrivastava
ff-by: Sivakumar Thulasimani Signed-off-by: Shubhangi Shrivastava --- drivers/gpu/drm/i915/i915_drv.h | 1 + drivers/gpu/drm/i915/i915_irq.c | 2 ++ drivers/gpu/drm/i915/intel_dp.c | 47 ++--- drivers/gpu/drm/i915/intel_drv.h | 4 +++ drivers/gpu/drm

[Intel-gfx] [PATCH 1/2] drm/i915: Always perform link training when requested

2016-05-12 Thread Shubhangi Shrivastava
Short pulse can be generated for automated tests requesting link training again, such scenarios we have to perform the request irrespective of the current status of link. This patch adds support for this request in DP encoder. Signed-off-by: Sivakumar Thulasimani Signed-off-by: Shubhangi

Re: [Intel-gfx] [PATCH 2/5] drm/i915: Read test values for lane_count and link_rate

2016-05-02 Thread Shubhangi Shrivastava
automated testing (test numbers from the CTS usite) in the commit message. Regards, Manasi Navare Graphics Kernel Developer OTC, Intel Corporation -Original Message- From: Intel-gfx [mailto:intel-gfx-boun...@lists.freedesktop.org] On Behalf Of Shubhangi Shrivastava Sent: Monday, April 25,

[Intel-gfx] [PATCH 5/5] drm/i915: Delay acknowledging of link training for ATR

2016-04-25 Thread Shubhangi Shrivastava
alreay ack'ed the request. So send the ack response only when performing link training with the given parameters. Signed-off-by: Sivakumar Thulasimani Signed-off-by: Shubhangi Shrivastava --- drivers/gpu/drm/i915/intel_dp.c | 10 ++ drivers/gpu/drm

[Intel-gfx] [PATCH 3/5] drm/i915: Cleanup panel IRQ handling

2016-04-25 Thread Shubhangi Shrivastava
to clear the bits only when handled, so this patch moves the IRQ clearing bit post handling code. Signed-off-by: Sivakumar Thulasimani Signed-off-by: Shubhangi Shrivastava --- drivers/gpu/drm/i915/intel_dp.c | 24 ++-- 1 file changed, 18 insertions(+), 6 deletions(-) diff

[Intel-gfx] [PATCH 1/5] drm/i915: Handle automated test requests for short pulse hpd

2016-04-25 Thread Shubhangi Shrivastava
This patch adds support for automated test requests during short pulse handling in gen platforms. Signed-off-by: Sivakumar Thulasimani Signed-off-by: Shubhangi Shrivastava --- drivers/gpu/drm/i915/intel_dp.c | 12 +--- 1 file changed, 9 insertions(+), 3 deletions(-) diff --git a

[Intel-gfx] [PATCH 2/5] drm/i915: Read test values for lane_count and link_rate

2016-04-25 Thread Shubhangi Shrivastava
During automated test request for link training we are supposed to read the TEST_LANE_COUNT and TEST_LINK_RATE dpcd registers and use respective values in the next link training. This patch adds reading and updating of these values. Signed-off-by: Sivakumar Thulasimani Signed-off-by: Shubhangi

[Intel-gfx] [PATCH 4/5] drm/i915: Extract test reply to separate function

2016-04-25 Thread Shubhangi Shrivastava
Replying for automated test request must be done only when we are ready for the request. This patch extracts this reply to separate function as it is needed in other places in the upcoming patches. Signed-off-by: Sivakumar Thulasimani Signed-off-by: Shubhangi Shrivastava --- drivers/gpu/drm

[Intel-gfx] [PATCH 2/5] drm/i915: Read test values for lane_count and link_rate

2016-04-21 Thread Shubhangi Shrivastava
During automated test request for link training we are supposed to read the TEST_LANE_COUNT and TEST_LINK_RATE dpcd registers and use respective values in the next link training. This patch adds reading and updating of these values. Signed-off-by: Sivakumar Thulasimani Signed-off-by: Shubhangi

[Intel-gfx] [PATCH 5/5] drm/i915: Delay acknowledging of link training for ATR

2016-04-21 Thread Shubhangi Shrivastava
alreay ack'ed the request. So send the ack response only when performing link training with the given parameters. Signed-off-by: Sivakumar Thulasimani Signed-off-by: Shubhangi Shrivastava --- drivers/gpu/drm/i915/intel_dp.c | 10 ++ drivers/gpu/drm

[Intel-gfx] [PATCH 1/5] drm/i915: Handle automated test requests for short pulse hpd

2016-04-21 Thread Shubhangi Shrivastava
This patch adds support for automated test requests during short pulse handling in gen platforms. Signed-off-by: Sivakumar Thulasimani Signed-off-by: Shubhangi Shrivastava --- drivers/gpu/drm/i915/intel_dp.c | 12 +--- 1 file changed, 9 insertions(+), 3 deletions(-) diff --git a

[Intel-gfx] [PATCH 3/5] drm/i915: Cleanup panel IRQ handling

2016-04-21 Thread Shubhangi Shrivastava
to clear the bits only when handled, so this patch moves the IRQ clearing bit post handling code. Signed-off-by: Sivakumar Thulasimani Signed-off-by: Shubhangi Shrivastava --- drivers/gpu/drm/i915/intel_dp.c | 24 ++-- 1 file changed, 18 insertions(+), 6 deletions(-) diff

[Intel-gfx] [PATCH 4/5] drm/i915: Extract test reply to separate function

2016-04-21 Thread Shubhangi Shrivastava
Replying for automated test request must be done only when we are ready for the request. This patch extracts this reply to separate function as it is needed in other places in the upcoming patches. Signed-off-by: Sivakumar Thulasimani Signed-off-by: Shubhangi Shrivastava --- drivers/gpu/drm

[Intel-gfx] [PATCH] drm/i915: Use fail safe mode when edid is corrupt

2016-04-20 Thread Shubhangi Shrivastava
used anytime by using edid_corrupt flag instead of checking for Automated test request flag. Signed-off-by: Sivakumar Thulasimani Signed-off-by: Shubhangi Shrivastava --- drivers/gpu/drm/i915/intel_dp.c | 24 +--- 1 file changed, 21 insertions(+), 3 deletions(-) diff --

[Intel-gfx] [PATCH] drm/i915: Fixing eDP detection on certain platforms

2016-04-11 Thread Shubhangi Shrivastava
Signed-off-by: Sivakumar Thulasimani Signed-off-by: Shubhangi Shrivastava Tested-by: Tvrtko Ursulin --- drivers/gpu/drm/i915/intel_dp.c | 5 - 1 file changed, 4 insertions(+), 1 deletion(-) diff --git a/drivers/gpu/drm/i915/intel_dp.c b/drivers/gpu/drm/i915/intel_dp.c index da0c3d2..bdc7e12 100

[Intel-gfx] [PATCH] drm/i915: Fixing eDP detection on certain platforms

2016-04-07 Thread Shubhangi Shrivastava
s: 30d9aa4265fe ("drm/i915: Read sink_count dpcd always") Cc: Ander Conselvan De Oliveira Cc: Jani Nikula Reported-by: Tvrtko Ursulin Signed-off-by: Sivakumar Thulasimani Signed-off-by: Shubhangi Shrivastava --- drivers/gpu/drm/i915/intel_dp.c | 5 - 1 file changed, 4 insertion

[Intel-gfx] [PATCH] drm/i915: Fixing eDP detection on certain platforms

2016-04-07 Thread Shubhangi Shrivastava
Sink count was read for eDP as well as DP. But in some cases the sink count for eDP is received as zero, as against the expected non zero value. This is seen in: commit 30d9aa4265fe4b2b28239934770b2c2d59858df3 Author: Shubhangi Shrivastava Date: Wed Mar 30 18:05:25 2016 +0530 drm/i915

Re: [Intel-gfx] ✓ Fi.CI.BAT: success for series starting with [1/5] drm/i915: Splitting intel_dp_detect

2016-04-07 Thread Shubhangi Shrivastava
On Thursday 07 April 2016 03:26 PM, Thulasimani, Sivakumar wrote: On 4/7/2016 1:54 PM, Ander Conselvan De Oliveira wrote: On Thu, 2016-04-07 at 10:58 +0300, Jani Nikula wrote: On Wed, 06 Apr 2016, Tvrtko Ursulin wrote: On 04/04/16 12:41, Tvrtko Ursulin wrote: On 04/04/16 12:08, Jani Niku

[Intel-gfx] [PATCH] drm/i915: Fixing eDP detection on certain platforms

2016-04-07 Thread Shubhangi Shrivastava
Sink count was read for eDP as well as DP. But in some cases the sink count for eDP is received as zero, as against the expected non zero value. This is seen in: commit 30d9aa4265fe4b2b28239934770b2c2d59858df3 Author: Shubhangi Shrivastava Date: Wed Mar 30 18:05:25 2016 +0530 drm/i915

Re: [Intel-gfx] ✓ Fi.CI.BAT: success for series starting with [1/5] drm/i915: Splitting intel_dp_detect

2016-04-04 Thread Shubhangi Shrivastava
On Friday 01 April 2016 01:11 PM, Ander Conselvan De Oliveira wrote: On Thu, 2016-03-31 at 12:38 +, Patchwork wrote: == Series Details == Series: series starting with [1/5] drm/i915: Splitting intel_dp_detect URL : https://patchwork.freedesktop.org/series/5044/ State : success I pushed

Re: [Intel-gfx] [PATCH 5/5] drm/i915: force full detect on sink count change

2016-03-31 Thread Shubhangi Shrivastava
by this series, but at this point is probably better to rebase and resend. CI seems to be a lot happier lately. :) Ander Alright.. Rebased and resent.. Finally, CI has become happy.. :) Thanks Ander!! Shubhangi Thanks and Regards, Shubhangi Shrivastava. -Original Message- From: Ander

Re: [Intel-gfx] [PATCH 1/2] drm/i915: Update VBT fields for child devices

2016-03-31 Thread Shubhangi Shrivastava
On Wednesday 30 March 2016 08:18 PM, Jani Nikula wrote: On Fri, 25 Mar 2016, Shubhangi Shrivastava wrote: This patch adds new fields that are not yet added in drm code in child devices struct Signed-off-by: Sivakumar Thulasimani Signed-off-by: Durgadoss R Signed-off-by: Shubhangi

[Intel-gfx] [PATCH 2/2] drm/i915: Set invert bit for hpd based on VBT

2016-03-31 Thread Shubhangi Shrivastava
register and added required breaks. (Ville) Signed-off-by: Sivakumar Thulasimani Signed-off-by: Durgadoss R Signed-off-by: Shubhangi Shrivastava Reviewed-by: Ville Syrjälä --- drivers/gpu/drm/i915/i915_drv.h | 2 ++ drivers/gpu/drm/i915/i915_irq.c | 20 drivers/gpu/drm

[Intel-gfx] [PATCH 1/2] drm/i915: Update VBT fields for child devices

2016-03-31 Thread Shubhangi Shrivastava
This patch adds new fields that are not yet added in drm code in child devices struct Signed-off-by: Sivakumar Thulasimani Signed-off-by: Durgadoss R Signed-off-by: Shubhangi Shrivastava Reviewed-by: Ville Syrjälä --- drivers/gpu/drm/i915/intel_bios.c | 15 ++- drivers/gpu

[Intel-gfx] [PATCH 1/5] drm/i915: Splitting intel_dp_detect

2016-03-30 Thread Shubhangi Shrivastava
Thulasimani Signed-off-by: Shubhangi Shrivastava Reviewed-by: Ander Conselvan de Oliveira --- drivers/gpu/drm/i915/intel_dp.c | 63 - 1 file changed, 43 insertions(+), 20 deletions(-) diff --git a/drivers/gpu/drm/i915/intel_dp.c b/drivers/gpu/drm/i915

[Intel-gfx] [PATCH 4/5] drm/i915: Read sink_count dpcd always

2016-03-30 Thread Shubhangi Shrivastava
ned-off-by: Sivakumar Thulasimani Signed-off-by: Shubhangi Shrivastava Reviewed-by: Ander Conselvan de Oliveira --- drivers/gpu/drm/i915/intel_dp.c | 30 +++--- drivers/gpu/drm/i915/intel_drv.h | 1 + 2 files changed, 24 insertions(+), 7 deletions(-) diff --git a/drivers/

[Intel-gfx] [PATCH 2/5] drm/i915: Cleaning up intel_dp_hpd_pulse

2016-03-30 Thread Shubhangi Shrivastava
multiple detects on hotplug. (Ander) Tested-by: Nathan D Ciobanu Signed-off-by: Sivakumar Thulasimani Signed-off-by: Shubhangi Shrivastava Reviewed-by: Ander Conselvan de Oliveira --- drivers/gpu/drm/i915/intel_dp.c | 72 +--- drivers/gpu/drm/i915

[Intel-gfx] [PATCH 3/5] drm/i915: Reorganizing intel_dp_check_link_status

2016-03-30 Thread Shubhangi Shrivastava
being read before performing encoder checks (Daniel) v4: Changed commit message to explain need of reading link status on short pulse (Ander) Tested-by: Nathan D Ciobanu Signed-off-by: Sivakumar Thulasimani Signed-off-by: Shubhangi Shrivastava Reviewed-by: Ander Conselvan de Oliveira

[Intel-gfx] [PATCH 5/5] drm/i915: force full detect on sink count change

2016-03-30 Thread Shubhangi Shrivastava
intel_dp_short_pulse (Ander) Tested-by: Nathan D Ciobanu Signed-off-by: Sivakumar Thulasimani Signed-off-by: Shubhangi Shrivastava Reviewed-by: Ander Conselvan de Oliveira --- drivers/gpu/drm/i915/intel_dp.c | 33 +++-- 1 file changed, 27 insertions(+), 6 deletions

[Intel-gfx] [PATCH 2/2] drm/i915: Set invert bit for hpd based on VBT

2016-03-25 Thread Shubhangi Shrivastava
register and added required breaks. (Ville) Signed-off-by: Sivakumar Thulasimani Signed-off-by: Durgadoss R Signed-off-by: Shubhangi Shrivastava Reviewed-by: Ville Syrjälä --- drivers/gpu/drm/i915/i915_drv.h | 2 ++ drivers/gpu/drm/i915/i915_irq.c | 20 drivers/gpu/drm

[Intel-gfx] [PATCH 1/2] drm/i915: Update VBT fields for child devices

2016-03-25 Thread Shubhangi Shrivastava
This patch adds new fields that are not yet added in drm code in child devices struct Signed-off-by: Sivakumar Thulasimani Signed-off-by: Durgadoss R Signed-off-by: Shubhangi Shrivastava Reviewed-by: Ville Syrjälä --- drivers/gpu/drm/i915/intel_bios.c | 15 ++- drivers/gpu

[Intel-gfx] [PATCH 2/2] drm/i915: Set invert bit for hpd based on VBT

2016-03-24 Thread Shubhangi Shrivastava
register Changed logic to incorporate required breaks. (Ville) Signed-off-by: Sivakumar Thulasimani Signed-off-by: Durgadoss R Signed-off-by: Shubhangi Shrivastava Reviewed-by: Ville Syrjälä --- drivers/gpu/drm/i915/i915_drv.h | 2 ++ drivers/gpu/drm/i915/i915_irq.c | 20

[Intel-gfx] [PATCH 1/2] drm/i915: Update VBT fields for child devices

2016-03-24 Thread Shubhangi Shrivastava
This patch adds new fields that are not yet added in drm code in child devices struct Signed-off-by: Sivakumar Thulasimani Signed-off-by: Durgadoss R Signed-off-by: Shubhangi Shrivastava Reviewed-by: Ville Syrjälä --- drivers/gpu/drm/i915/intel_bios.c | 15 ++- drivers/gpu

[Intel-gfx] [PATCH 2/2] drm/i915: Set invert bit for hpd based on VBT

2016-03-15 Thread Shubhangi Shrivastava
: Durgadoss R Signed-off-by: Shubhangi Shrivastava --- drivers/gpu/drm/i915/i915_drv.h | 2 ++ drivers/gpu/drm/i915/i915_irq.c | 20 drivers/gpu/drm/i915/i915_reg.h | 8 drivers/gpu/drm/i915/intel_bios.c | 35 +++ 4 files changed, 65

[Intel-gfx] [PATCH 1/2] drm/i915: Update VBT fields for child devices

2016-03-15 Thread Shubhangi Shrivastava
This patch adds new fields that are not yet added in drm code in child devices struct Signed-off-by: Sivakumar Thulasimani Signed-off-by: Durgadoss R Signed-off-by: Shubhangi Shrivastava --- drivers/gpu/drm/i915/intel_bios.c | 15 ++- drivers/gpu/drm/i915/intel_bios.h | 16

[Intel-gfx] [PATCH 2/2] drm/i915: Set invert bit for hpd based on VBT

2016-03-11 Thread Shubhangi Shrivastava
: Durgadoss R Signed-off-by: Shubhangi Shrivastava --- drivers/gpu/drm/i915/i915_drv.h | 1 + drivers/gpu/drm/i915/i915_irq.c | 21 drivers/gpu/drm/i915/i915_reg.h | 8 drivers/gpu/drm/i915/intel_bios.c | 40 +++ 4 files changed

[Intel-gfx] [PATCH 1/2] drm/i915: Update VBT fields for child devices

2016-03-11 Thread Shubhangi Shrivastava
This patch adds new fields that are not yet added in drm code in child devices struct Signed-off-by: Sivakumar Thulasimani Signed-off-by: Durgadoss R Signed-off-by: Shubhangi Shrivastava --- drivers/gpu/drm/i915/intel_bios.c | 15 ++- drivers/gpu/drm/i915/intel_bios.h | 16

[Intel-gfx] [PATCH 1/2] drm/i915: Update VBT fields for child devices

2016-03-11 Thread Shubhangi Shrivastava
This patch adds new fields that are not yet added in drm code in child devices struct Signed-off-by: Sivakumar Thulasimani Signed-off-by: Durgadoss R Signed-off-by: Shubhangi Shrivastava --- drivers/gpu/drm/i915/intel_bios.c | 15 ++- drivers/gpu/drm/i915/intel_bios.h | 16

[Intel-gfx] [PATCH 2/2] drm/i915: Set invert bit for hpd based on VBT

2016-03-11 Thread Shubhangi Shrivastava
: Durgadoss R Signed-off-by: Shubhangi Shrivastava --- drivers/gpu/drm/i915/i915_drv.h | 1 + drivers/gpu/drm/i915/i915_irq.c | 21 drivers/gpu/drm/i915/i915_reg.h | 8 drivers/gpu/drm/i915/intel_bios.c | 40 +++ 4 files changed

[Intel-gfx] [PATCH 1/2] drm/i915: Update VBT fields for child devices

2016-02-25 Thread Shubhangi Shrivastava
This patch adds new fields that are not yet added in drm code in child devices struct Signed-off-by: Sivakumar Thulasimani Signed-off-by: Durgadoss R Signed-off-by: Shubhangi Shrivastava --- drivers/gpu/drm/i915/intel_bios.c | 15 ++- drivers/gpu/drm/i915/intel_bios.h | 16

[Intel-gfx] [PATCH 2/2] drm/i915: Set invert bit for hpd based on VBT

2016-02-25 Thread Shubhangi Shrivastava
. (Jani) v3: Moved setting invert bit logic to bxt_hpd_irq_setup() and changed its logic to avoid looping twice. (Ville) Signed-off-by: Sivakumar Thulasimani Signed-off-by: Durgadoss R Signed-off-by: Shubhangi Shrivastava --- drivers/gpu/drm/i915/i915_drv.h | 1 + drivers/gpu/drm/i915

[Intel-gfx] [PATCH 5/5] drm/i915: force full detect on sink count change

2016-02-16 Thread Shubhangi Shrivastava
intel_dp_short_pulse (Ander) Tested-by: Nathan D Ciobanu Signed-off-by: Sivakumar Thulasimani Signed-off-by: Shubhangi Shrivastava Reviewed-by: Ander Conselvan de Oliveira --- drivers/gpu/drm/i915/intel_dp.c | 33 +++-- 1 file changed, 27 insertions(+), 6 deletions

[Intel-gfx] [PATCH 1/5] drm/i915: Splitting intel_dp_detect

2016-02-16 Thread Shubhangi Shrivastava
Thulasimani Signed-off-by: Shubhangi Shrivastava Reviewed-by: Ander Conselvan de Oliveira --- drivers/gpu/drm/i915/intel_dp.c | 63 - 1 file changed, 43 insertions(+), 20 deletions(-) diff --git a/drivers/gpu/drm/i915/intel_dp.c b/drivers/gpu/drm/i915

[Intel-gfx] [PATCH 3/5] drm/i915: Reorganizing intel_dp_check_link_status

2016-02-16 Thread Shubhangi Shrivastava
being read before performing encoder checks (Daniel) v4: Changed commit message to explain need of reading link status on short pulse (Ander) Tested-by: Nathan D Ciobanu Signed-off-by: Sivakumar Thulasimani Signed-off-by: Shubhangi Shrivastava Reviewed-by: Ander Conselvan de Oliveira

[Intel-gfx] [PATCH 4/5] drm/i915: Read sink_count dpcd always

2016-02-16 Thread Shubhangi Shrivastava
ned-off-by: Sivakumar Thulasimani Signed-off-by: Shubhangi Shrivastava Reviewed-by: Ander Conselvan de Oliveira --- drivers/gpu/drm/i915/intel_dp.c | 30 +++--- drivers/gpu/drm/i915/intel_drv.h | 1 + 2 files changed, 24 insertions(+), 7 deletions(-) diff --git a/drivers/

[Intel-gfx] [PATCH 2/5] drm/i915: Cleaning up intel_dp_hpd_pulse

2016-02-16 Thread Shubhangi Shrivastava
multiple detects on hotplug. (Ander) Tested-by: Nathan D Ciobanu Signed-off-by: Sivakumar Thulasimani Signed-off-by: Shubhangi Shrivastava Reviewed-by: Ander Conselvan de Oliveira --- drivers/gpu/drm/i915/intel_dp.c | 72 +--- drivers/gpu/drm/i915

[Intel-gfx] [PATCH 2/2] drm/i915: Set invert bit for hpd based on VBT

2016-02-12 Thread Shubhangi Shrivastava
. (Jani) Signed-off-by: Sivakumar Thulasimani Signed-off-by: Durgadoss R Signed-off-by: Shubhangi Shrivastava --- drivers/gpu/drm/i915/i915_drv.h | 1 + drivers/gpu/drm/i915/i915_irq.c | 43 +++ drivers/gpu/drm/i915/i915_reg.h | 9 drivers/gpu

[Intel-gfx] [PATCH 1/2] drm/i915: Update VBT fields for child devices

2016-02-12 Thread Shubhangi Shrivastava
This patch adds new fields that are not yet added in drm code in child devices struct Signed-off-by: Sivakumar Thulasimani Signed-off-by: Durgadoss R Signed-off-by: Shubhangi Shrivastava --- drivers/gpu/drm/i915/intel_bios.c | 15 ++- drivers/gpu/drm/i915/intel_bios.h | 20

[Intel-gfx] [PATCH] drm/i915: Set invert bit for hpd based on VBT

2016-02-12 Thread Shubhangi Shrivastava
. (Jani) Signed-off-by: Sivakumar Thulasimani Signed-off-by: Durgadoss R Signed-off-by: Shubhangi Shrivastava --- drivers/gpu/drm/i915/i915_drv.h | 1 + drivers/gpu/drm/i915/i915_irq.c | 43 +++ drivers/gpu/drm/i915/i915_reg.h | 9 drivers/gpu

[Intel-gfx] [PATCH 1/5] drm/i915: Splitting intel_dp_detect

2016-02-10 Thread Shubhangi Shrivastava
Thulasimani Signed-off-by: Shubhangi Shrivastava Reviewed-by: Ander Conselvan de Oliveira --- drivers/gpu/drm/i915/intel_dp.c | 63 - 1 file changed, 43 insertions(+), 20 deletions(-) diff --git a/drivers/gpu/drm/i915/intel_dp.c b/drivers/gpu/drm/i915

[Intel-gfx] [PATCH 5/5] drm/i915: force full detect on sink count change

2016-02-10 Thread Shubhangi Shrivastava
intel_dp_short_pulse (Ander) Tested-by: Nathan D Ciobanu Signed-off-by: Sivakumar Thulasimani Signed-off-by: Shubhangi Shrivastava Reviewed-by: Ander Conselvan de Oliveira --- drivers/gpu/drm/i915/intel_dp.c | 33 +++-- 1 file changed, 27 insertions(+), 6 deletions

[Intel-gfx] [PATCH 4/5] drm/i915: Save sink_count for tracking changes to it and read sink_count dpcd always

2016-02-10 Thread Shubhangi Shrivastava
nto one. (Ander) v3: Added comment to explain the need of early return when sink count is 0. (Ander) Tested-by: Nathan D Ciobanu Signed-off-by: Sivakumar Thulasimani Signed-off-by: Shubhangi Shrivastava Reviewed-by: Ander Conselvan de Oliveira --- drivers/gpu/drm/i915/intel_dp.c |

[Intel-gfx] [PATCH 3/5] drm/i915: Reorganizing intel_dp_check_link_status

2016-02-10 Thread Shubhangi Shrivastava
being read before performing encoder checks (Daniel) v4: Changed commit message to explain need of reading link status on short pulse (Ander) Tested-by: Nathan D Ciobanu Signed-off-by: Sivakumar Thulasimani Signed-off-by: Shubhangi Shrivastava Reviewed-by: Ander Conselvan de Oliveira

[Intel-gfx] [PATCH 2/5] drm/i915: Cleaning up intel_dp_hpd_pulse

2016-02-10 Thread Shubhangi Shrivastava
Signed-off-by: Shubhangi Shrivastava --- drivers/gpu/drm/i915/intel_dp.c | 72 +--- drivers/gpu/drm/i915/intel_drv.h | 1 + 2 files changed, 47 insertions(+), 26 deletions(-) diff --git a/drivers/gpu/drm/i915/intel_dp.c b/drivers/gpu/drm/i915/intel_dp.c

[Intel-gfx] [PATCH 2/2] drm/i915: Set invert bit for hpd based on VBT

2016-02-04 Thread Shubhangi Shrivastava
: Durgadoss R Signed-off-by: Shubhangi Shrivastava --- drivers/gpu/drm/i915/i915_irq.c | 49 + drivers/gpu/drm/i915/i915_reg.h | 9 2 files changed, 58 insertions(+) diff --git a/drivers/gpu/drm/i915/i915_irq.c b/drivers/gpu/drm/i915/i915_irq.c index

[Intel-gfx] [PATCH 1/2] drm/i915: Update VBT fields for child devices

2016-02-04 Thread Shubhangi Shrivastava
This patch adds new fields that are not yet added in drm code in child devices struct Signed-off-by: Sivakumar Thulasimani Signed-off-by: Durgadoss R Signed-off-by: Shubhangi Shrivastava --- drivers/gpu/drm/i915/intel_bios.c | 15 ++- drivers/gpu/drm/i915/intel_bios.h | 20

[Intel-gfx] [PATCH 3/5] drm/i915: Reorganizing intel_dp_check_link_status

2016-02-01 Thread Shubhangi Shrivastava
being read before performing encoder checks (Daniel) v4: Changed commit message to explain need of reading link status on short pulse (Ander) Tested-by: Nathan D Ciobanu Signed-off-by: Sivakumar Thulasimani Signed-off-by: Shubhangi Shrivastava --- drivers/gpu/drm/i915/intel_dp.c | 65

[Intel-gfx] [PATCH 4/5] drm/i915: Save sink_count for tracking changes to it and read sink_count dpcd always

2016-02-01 Thread Shubhangi Shrivastava
nto one. (Ander) v3: Added comment to explain the need of early return when sink count is 0. (Ander) Tested-by: Nathan D Ciobanu Signed-off-by: Sivakumar Thulasimani Signed-off-by: Shubhangi Shrivastava --- drivers/gpu/drm/i915/intel_dp.c | 30 +++--- drivers/gpu/

[Intel-gfx] [PATCH 5/5] drm/i915: force full detect on sink count change

2016-02-01 Thread Shubhangi Shrivastava
intel_dp_short_pulse (Ander) Tested-by: Nathan D Ciobanu Signed-off-by: Sivakumar Thulasimani Signed-off-by: Shubhangi Shrivastava Reviewed-by: Ander Conselvan de Oliveira --- drivers/gpu/drm/i915/intel_dp.c | 33 +++-- 1 file changed, 27 insertions(+), 6 deletions

[Intel-gfx] [PATCH 1/5] drm/i915: Splitting intel_dp_detect

2016-02-01 Thread Shubhangi Shrivastava
Thulasimani Signed-off-by: Shubhangi Shrivastava --- drivers/gpu/drm/i915/intel_dp.c | 63 - 1 file changed, 43 insertions(+), 20 deletions(-) diff --git a/drivers/gpu/drm/i915/intel_dp.c b/drivers/gpu/drm/i915/intel_dp.c index 1761254..65028a4 100644 --- a

[Intel-gfx] [PATCH 2/5] drm/i915: Cleaning up intel_dp_hpd_pulse

2016-02-01 Thread Shubhangi Shrivastava
Signed-off-by: Shubhangi Shrivastava --- drivers/gpu/drm/i915/intel_dp.c | 65 + 1 file changed, 40 insertions(+), 25 deletions(-) diff --git a/drivers/gpu/drm/i915/intel_dp.c b/drivers/gpu/drm/i915/intel_dp.c index 65028a4..ce99d59 100644 --- a/drivers

Re: [Intel-gfx] [PATCH 2/5] drm/i915: Cleaning up intel_dp_hpd_pulse

2016-01-29 Thread Shubhangi Shrivastava
On Tuesday 26 January 2016 06:52 PM, Ander Conselvan De Oliveira wrote: On Tue, 2016-01-19 at 16:07 +0530, Shubhangi Shrivastava wrote: Current DP detection has DPCD operations split across intel_dp_hpd_pulse and intel_dp_detect which contains duplicates as well. Also intel_dp_detect is

[Intel-gfx] [PATCH 2/5] drm/i915: Cleaning up intel_dp_hpd_pulse

2016-01-19 Thread Shubhangi Shrivastava
Signed-off-by: Shubhangi Shrivastava --- drivers/gpu/drm/i915/intel_dp.c | 71 + 1 file changed, 44 insertions(+), 27 deletions(-) diff --git a/drivers/gpu/drm/i915/intel_dp.c b/drivers/gpu/drm/i915/intel_dp.c index 8969ff9..82ee18d 100644 --- a/drivers

[Intel-gfx] [PATCH 5/5] drm/i915: force full detect on sink count change

2016-01-19 Thread Shubhangi Shrivastava
intel_dp_short_pulse (Ander) Tested-by: Nathan D Ciobanu Signed-off-by: Sivakumar Thulasimani Signed-off-by: Shubhangi Shrivastava --- drivers/gpu/drm/i915/intel_dp.c | 33 +++-- 1 file changed, 27 insertions(+), 6 deletions(-) diff --git a/drivers/gpu/drm/i915

[Intel-gfx] [PATCH 3/5] drm/i915: Reorganizing intel_dp_check_link_status

2016-01-19 Thread Shubhangi Shrivastava
() (Ander) v3: Changed commit message to explain need of link status being read before performing encoder checks (Daniel) Tested-by: Nathan D Ciobanu Signed-off-by: Sivakumar Thulasimani Signed-off-by: Shubhangi Shrivastava --- drivers/gpu/drm/i915/intel_dp.c | 65

[Intel-gfx] [PATCH 4/5] drm/i915: Save sink_count for tracking changes to it and read sink_count dpcd always

2016-01-19 Thread Shubhangi Shrivastava
display connected through dongle v2: Storing value of intel_dp->sink_count that is ready for consumption. (Ander) Squashing two commits into one. (Ander) Tested-by: Nathan D Ciobanu Signed-off-by: Sivakumar Thulasimani Signed-off-by: Shubhangi Shrivastava --- drivers/gpu/

[Intel-gfx] [PATCH 1/5] drm/i915: Splitting intel_dp_detect

2016-01-19 Thread Shubhangi Shrivastava
series. Moved intel_dp_unset_edid to out. (Ander) v3: Rephrased commit message and intel_dp_unset_dp() is called within intel_dp_set_dp() to free the previous EDID. (Ander) Tested-by: Nathan D Ciobanu Signed-off-by: Sivakumar Thulasimani Signed-off-by: Shubhangi Shrivastava --- drivers

[Intel-gfx] [PATCH 5/5] drm/i915: force full detect on sink count change

2016-01-19 Thread Shubhangi Shrivastava
intel_dp_short_pulse (Ander) Tested-by: Nathan D Ciobanu Signed-off-by: Sivakumar Thulasimani Signed-off-by: Shubhangi Shrivastava --- drivers/gpu/drm/i915/intel_dp.c | 33 +++-- 1 file changed, 27 insertions(+), 6 deletions(-) diff --git a/drivers/gpu/drm/i915

[Intel-gfx] [PATCH 4/5] drm/i915: Save sink_count for tracking changes to it and read sink_count dpcd always

2016-01-19 Thread Shubhangi Shrivastava
display connected through dongle v2: Storing value of intel_dp->sink_count that is ready for consumption. (Ander) Squashing two commits into one. (Ander) Tested-by: Nathan D Ciobanu Signed-off-by: Sivakumar Thulasimani Signed-off-by: Shubhangi Shrivastava --- drivers/gpu/

[Intel-gfx] [PATCH 3/5] drm/i915: Reorganizing intel_dp_check_link_status

2016-01-19 Thread Shubhangi Shrivastava
() (Ander) v3: Changed commit message to explain need of link status being read before performing encoder checks (Daniel) Tested-by: Nathan D Ciobanu Signed-off-by: Sivakumar Thulasimani Signed-off-by: Shubhangi Shrivastava --- drivers/gpu/drm/i915/intel_dp.c | 65

[Intel-gfx] [PATCH 2/5] drm/i915: Cleaning up intel_dp_hpd_pulse

2016-01-19 Thread Shubhangi Shrivastava
Signed-off-by: Shubhangi Shrivastava --- drivers/gpu/drm/i915/intel_dp.c | 71 + 1 file changed, 44 insertions(+), 27 deletions(-) diff --git a/drivers/gpu/drm/i915/intel_dp.c b/drivers/gpu/drm/i915/intel_dp.c index 8969ff9..82ee18d 100644 --- a/drivers

[Intel-gfx] [PATCH 1/5] drm/i915: Splitting intel_dp_detect

2016-01-19 Thread Shubhangi Shrivastava
series. Moved intel_dp_unset_edid to out. (Ander) v3: Rephrased commit message and intel_dp_unset_dp() is called within intel_dp_set_dp() to free the previous EDID. (Ander) Tested-by: Nathan D Ciobanu Signed-off-by: Sivakumar Thulasimani Signed-off-by: Shubhangi Shrivastava --- drivers

[Intel-gfx] [PATCH] drm/i915: Reorganizing intel_dp_check_link_status

2016-01-19 Thread Shubhangi Shrivastava
() (Ander) v3: Changed commit message to explain need of link status being read before performing encoder checks (Daniel) Tested-by: Nathan D Ciobanu Signed-off-by: Sivakumar Thulasimani Signed-off-by: Shubhangi Shrivastava --- drivers/gpu/drm/i915/intel_dp.c | 65

Re: [Intel-gfx] [PATCH 4/6] drm/i915: Save sink_count for tracking changes to it

2016-01-19 Thread Shubhangi Shrivastava
On Thursday 14 January 2016 06:30 PM, Ander Conselvan De Oliveira wrote: On Tue, 2016-01-05 at 18:20 +0530, Shubhangi Shrivastava wrote: Sink count can change between short pulse hpd hence this patch adds a member variable to intel_dp so we can track any changes between short pulse interrupts

Re: [Intel-gfx] [PATCH 3/6] drm/i915: Splitting intel_dp_check_link_status

2016-01-19 Thread Shubhangi Shrivastava
On Wednesday 13 January 2016 08:34 PM, Ander Conselvan De Oliveira wrote: On Tue, 2016-01-05 at 18:20 +0530, Shubhangi Shrivastava wrote: When created originally intel_dp_check_link_status() was supposed to handle only link training for short pulse but has grown into handler for short pulse

Re: [Intel-gfx] [PATCH 1/6] drm/i915: Splitting intel_dp_detect

2016-01-19 Thread Shubhangi Shrivastava
On Friday 15 January 2016 03:37 PM, Ander Conselvan De Oliveira wrote: On Thu, 2016-01-14 at 19:20 +0530, Shubhangi Shrivastava wrote: On Wednesday 13 January 2016 07:03 PM, Ander Conselvan De Oliveira wrote: On Wed, 2016-01-13 at 13:20 +0200, Ander Conselvan De Oliveira wrote: On Tue, 2016

Re: [Intel-gfx] [PATCH 6/6] drm/i915: force full detect on sink count change

2016-01-19 Thread Shubhangi Shrivastava
On Thursday 14 January 2016 07:20 PM, Ander Conselvan De Oliveira wrote: On Tue, 2016-01-05 at 18:20 +0530, Shubhangi Shrivastava wrote: This patch checks for changes in sink count between short pulse hpds and forces full detect when there is a change. This will allow both detection of

Re: [Intel-gfx] [PATCH 5/6] drm/i915: read sink_count dpcd always

2016-01-19 Thread Shubhangi Shrivastava
On Monday 18 January 2016 06:30 PM, Ander Conselvan De Oliveira wrote: On Mon, 2016-01-18 at 18:14 +0530, Shubhangi Shrivastava wrote: On Thursday 14 January 2016 06:34 PM, Ander Conselvan De Oliveira wrote: On Tue, 2016-01-05 at 18:20 +0530, Shubhangi Shrivastava wrote: This patch reads

[Intel-gfx] [PATCH] drm/i915: Save sink_count for tracking changes to it and read sink_count dpcd always

2016-01-18 Thread Shubhangi Shrivastava
display connected through dongle v2: Storing value of intel_dp->sink_count that is ready for consumption. (Ander) Squashing two commits into one. (Ander) Tested-by: Nathan D Ciobanu Signed-off-by: Sivakumar Thulasimani Signed-off-by: Shubhangi Shrivastava --- drivers/gpu/

Re: [Intel-gfx] [PATCH 5/6] drm/i915: read sink_count dpcd always

2016-01-18 Thread Shubhangi Shrivastava
On Monday 18 January 2016 06:14 PM, Shubhangi Shrivastava wrote: On Thursday 14 January 2016 06:34 PM, Ander Conselvan De Oliveira wrote: On Tue, 2016-01-05 at 18:20 +0530, Shubhangi Shrivastava wrote: This patch reads sink_count dpcd always and removes its read operation based on values

Re: [Intel-gfx] [PATCH 5/6] drm/i915: read sink_count dpcd always

2016-01-18 Thread Shubhangi Shrivastava
On Thursday 14 January 2016 06:34 PM, Ander Conselvan De Oliveira wrote: On Tue, 2016-01-05 at 18:20 +0530, Shubhangi Shrivastava wrote: This patch reads sink_count dpcd always and removes its read operation based on values in downstream port dpcd. SINK_COUNT dpcd is not dependent on

[Intel-gfx] [PATCH] drm/i915: Splitting intel_dp_check_link_status

2016-01-18 Thread Shubhangi Shrivastava
-off-by: Shubhangi Shrivastava --- drivers/gpu/drm/i915/intel_dp.c | 65 +++-- 1 file changed, 36 insertions(+), 29 deletions(-) diff --git a/drivers/gpu/drm/i915/intel_dp.c b/drivers/gpu/drm/i915/intel_dp.c index 82ee18d..f8d9611 100644 --- a/drivers/gpu/drm/i915

[Intel-gfx] [PATCH] drm/i915: Splitting intel_dp_detect

2016-01-18 Thread Shubhangi Shrivastava
series. Moved intel_dp_unset_edid to out. (Ander) v3: Rephrased commit message and intel_dp_unset_dp() is called within intel_dp_set_dp() to free the previous EDID. (Ander) Tested-by: Nathan D Ciobanu Signed-off-by: Sivakumar Thulasimani Signed-off-by: Shubhangi Shrivastava --- drivers

Re: [Intel-gfx] [PATCH 1/6] drm/i915: Splitting intel_dp_detect

2016-01-14 Thread Shubhangi Shrivastava
On Wednesday 13 January 2016 07:03 PM, Ander Conselvan De Oliveira wrote: On Wed, 2016-01-13 at 13:20 +0200, Ander Conselvan De Oliveira wrote: On Tue, 2016-01-05 at 18:20 +0530, Shubhangi Shrivastava wrote: intel_dp_detect() is called for not just detection but during modes enumeration as

Re: [Intel-gfx] Intel-gfx Digest, Vol 96, Issue 26

2016-01-12 Thread Shubhangi Shrivastava
Hi, Can someone review the patches in the below mail? PFB the link to the same: https://patchwork.freedesktop.org/series/369/#rev5 Thanks and Regards, Shubhangi Shrivastava. On Tuesday 05 January 2016 06:28 PM, intel-gfx-requ...@lists.freedesktop.org wrote: Send Intel-gfx

[Intel-gfx] [PATCH 6/6] drm/i915: force full detect on sink count change

2016-01-05 Thread Shubhangi Shrivastava
) return immediately if perform_full_detect is set(Siva) v3: changed method of determining full detection from using pointer to return code (Siva) Tested-by: Nathan D Ciobanu Signed-off-by: Sivakumar Thulasimani Signed-off-by: Shubhangi Shrivastava --- drivers/gpu/drm/i915/intel_dp.c | 30

[Intel-gfx] [PATCH 1/6] drm/i915: Splitting intel_dp_detect

2016-01-05 Thread Shubhangi Shrivastava
series. Moved intel_dp_unset_edid to out. (Ander) v3: Rephrased commit message and intel_dp_unset_dp() is called within intel_dp_set_dp() to free the previous EDID. (Ander) Tested-by: Nathan D Ciobanu Signed-off-by: Sivakumar Thulasimani Signed-off-by: Shubhangi Shrivastava --- drivers

[Intel-gfx] [PATCH 5/6] drm/i915: read sink_count dpcd always

2016-01-05 Thread Shubhangi Shrivastava
1 dongle is connected without display 1 0 display connected directly 1 1 display connected through dongle Tested-by: Nathan D Ciobanu Signed-off-by: Sivakumar Thulasimani Signed-off-by: Shubhangi Shrivastava

[Intel-gfx] [PATCH 0/6] Fixing sink count related detection over

2016-01-05 Thread Shubhangi Shrivastava
appropriately. Shubhangi Shrivastava (6): drm/i915: Splitting intel_dp_detect drm/i915: Cleaning up intel_dp_hpd_pulse drm/i915: Splitting intel_dp_check_link_status drm/i915: Save sink_count for tracking changes to it drm/i915: read sink_count dpcd always drm/i915: force full detect on

[Intel-gfx] [PATCH 2/6] drm/i915: Cleaning up intel_dp_hpd_pulse

2016-01-05 Thread Shubhangi Shrivastava
Signed-off-by: Shubhangi Shrivastava --- drivers/gpu/drm/i915/intel_dp.c | 71 + 1 file changed, 44 insertions(+), 27 deletions(-) diff --git a/drivers/gpu/drm/i915/intel_dp.c b/drivers/gpu/drm/i915/intel_dp.c index e3b4208..137757b 100644 --- a/drivers

[Intel-gfx] [PATCH 3/6] drm/i915: Splitting intel_dp_check_link_status

2016-01-05 Thread Shubhangi Shrivastava
intel_dp_short_pulse. This change is required to avoid performing all DPCD related operations on performing link retraining. Tested-by: Nathan D Ciobanu Signed-off-by: Sivakumar Thulasimani Signed-off-by: Shubhangi Shrivastava --- drivers/gpu/drm/i915/intel_dp.c | 56

[Intel-gfx] [PATCH 4/6] drm/i915: Save sink_count for tracking changes to it

2016-01-05 Thread Shubhangi Shrivastava
Sink count can change between short pulse hpd hence this patch adds a member variable to intel_dp so we can track any changes between short pulse interrupts. Tested-by: Nathan D Ciobanu Signed-off-by: Sivakumar Thulasimani Signed-off-by: Shubhangi Shrivastava --- drivers/gpu/drm/i915

Re: [Intel-gfx] [PATCH 0/6] Fixing sink count related detection over

2015-11-18 Thread Shubhangi Shrivastava
On Wednesday 18 November 2015 02:53 PM, Ander Conselvan De Oliveira wrote: On Wed, 2015-11-18 at 11:12 +0530, Shubhangi Shrivastava wrote: On Wednesday 18 November 2015 01:23 AM, Daniel Vetter wrote: On Mon, Nov 02, 2015 at 06:25:10PM +0530, Shubhangi Shrivastava wrote: This patch set

Re: [Intel-gfx] [PATCH 0/6] Fixing sink count related detection over

2015-11-17 Thread Shubhangi Shrivastava
On Wednesday 18 November 2015 01:23 AM, Daniel Vetter wrote: On Mon, Nov 02, 2015 at 06:25:10PM +0530, Shubhangi Shrivastava wrote: This patch set cleans up DP detection logic to bring all DPCD operations at one place and to create a clear demarcation between handling of long and short pulses

Re: [Intel-gfx] [PATCH 1/6] drm/i915: Splitting intel_dp_detect

2015-11-17 Thread Shubhangi Shrivastava
On Tuesday 17 November 2015 02:52 PM, Ander Conselvan De Oliveira wrote: On Tue, 2015-11-17 at 11:47 +0530, Shubhangi Shrivastava wrote: On Monday 16 November 2015 07:10 PM, Ander Conselvan De Oliveira wrote: On Fri, 2015-11-06 at 17:58 +0530, Shubhangi Shrivastava wrote: This patch moves

Re: [Intel-gfx] [PATCH 2/6] drm/i915: Cleaning up intel_dp_hpd_pulse

2015-11-16 Thread Shubhangi Shrivastava
On Monday 16 November 2015 08:16 PM, Ander Conselvan De Oliveira wrote: On Mon, 2015-11-16 at 16:33 +0200, Ander Conselvan De Oliveira wrote: On Fri, 2015-11-06 at 17:58 +0530, Shubhangi Shrivastava wrote: Current DP detection has DPCD operations split across intel_dp_hpd_pulse and

[Intel-gfx] [PATCH] drm/i915: Cleaning up intel_dp_hpd_pulse

2015-11-16 Thread Shubhangi Shrivastava
DPCD operations in one single function and make intel_dp_detect use existing values instead of repeating same steps. v2: Pulled in a hunk from last patch of the series to this patch. (Ander) Signed-off-by: Sivakumar Thulasimani Signed-off-by: Shubhangi Shrivastava --- drivers/gpu/drm/i915

Re: [Intel-gfx] [PATCH 2/6] drm/i915: Cleaning up intel_dp_hpd_pulse

2015-11-16 Thread Shubhangi Shrivastava
On Monday 16 November 2015 08:03 PM, Ander Conselvan De Oliveira wrote: On Fri, 2015-11-06 at 17:58 +0530, Shubhangi Shrivastava wrote: Current DP detection has DPCD operations split across intel_dp_hpd_pulse and intel_dp_detect which contains duplicates as well. Also intel_dp_detect is

  1   2   >