Re: [Intel-gfx] [PATCH] drm/i915/bdw: cancel the SW turbo tasks before runtime suspending

2014-09-08 Thread Sun, Daisy
Need to reset the flip_received flag at the end of this block, indicate that the flip interrupt will stop working. + if (dev_priv->rps.is_bdw_sw_turbo) { + del_timer_sync(&dev_priv->rps.sw_turbo.flip_timer); + cancel_work_sync(&dev_priv->rps.sw_turbo.work_max_fr

Re: [Intel-gfx] [PATCH v3] drm/i915/bdw: BDW Software Turbo

2014-08-11 Thread Sun, Daisy
The expected design is a constant timer which will trigger GT busyness calculation steadily, I understand. Yet the case is that we would have to wrap up BDW related works as we mentioned with Jesse, there are not enough resources to do further development on the constant timer scheme, sorry tha

Re: [Intel-gfx] [PATCH v2] drm/i915/bdw: BDW Software Turbo

2014-07-25 Thread Sun, Daisy
estart it upon first batch when transitioning out of idle. -Daniel Jesse On Tue, 15 Jul 2014 06:35:20 + "Sun, Daisy" wrote: Hi Daniel, Chris The concern for traditional X and media server do make sense. I'll update the patch with RP_UP_EI_INTERRUPT as trigger instead of the

Re: [Intel-gfx] [PATCH v2] drm/i915/bdw: BDW Software Turbo

2014-07-25 Thread Sun, Daisy
is idle we need to stop rearming that timer and restart it upon first batch when transitioning out of idle. -Daniel Jesse On Tue, 15 Jul 2014 06:35:20 +0000 "Sun, Daisy" wrote: Hi Daniel, Chris The concern for traditional X and media server do make sense. I'll update the patch w

Re: [Intel-gfx] [PATCH v2] drm/i915/bdw: BDW Software Turbo

2014-07-14 Thread Sun, Daisy
h] On Behalf Of Daniel Vetter Sent: Monday, July 14, 2014 12:04 AM To: Sun, Daisy Cc: Chris Wilson; intel-gfx@lists.freedesktop.org Subject: Re: [Intel-gfx] [PATCH v2] drm/i915/bdw: BDW Software Turbo On Mon, Jul 14, 2014 at 8:59 AM, Daniel Vetter wrote: > On Mon, Jul 14, 2014 at 04:22:44AM +0

Re: [Intel-gfx] [PATCH v2] drm/i915/bdw: BDW Software Turbo

2014-07-13 Thread Sun, Daisy
l try to cover it definitely. -Original Message- From: Chris Wilson [mailto:ch...@chris-wilson.co.uk] Sent: Thursday, July 10, 2014 11:16 PM To: Sun, Daisy Cc: intel-gfx@lists.freedesktop.org Subject: Re: [Intel-gfx] [PATCH v2] drm/i915/bdw: BDW Software Turbo On Thu, Jul 10, 2014 at

Re: [Intel-gfx] [PATCH v2] drm/i915/bdw: BDW Software Turbo

2014-07-10 Thread Sun, Daisy
, 2014 at 11:42:59AM -0700, Sun, Daisy wrote: GT is not going to run at a single frequency all the time actually. It starts from a single frequency, and then will dynamically adjust according to the GT utilization, either go up or down. From this perspective, SW turbo function the same as the HW

Re: [Intel-gfx] [PATCH v2] drm/i915/bdw: BDW Software Turbo

2014-07-10 Thread Sun, Daisy
GT is not going to run at a single frequency all the time actually. It starts from a single frequency, and then will dynamically adjust according to the GT utilization, either go up or down. From this perspective, SW turbo function the same as the HW turbo. For the algorithm, we did go over t

Re: [Intel-gfx] [PATCH] drm/i915/bdw: Broaden FBC resolution limit to 4096x4096

2014-06-16 Thread Sun, Daisy
IC. I started working from BDW FBC, did not check all the gens thoroughly:-) Sent out a version 2 just now. - Daisy On 6/16/2014 2:49 PM, Daniel Vetter wrote: On Mon, Jun 16, 2014 at 10:41 PM, Sun, Daisy wrote: Yes, the change starts from HSW. I'll update the patch. what's the &qu

Re: [Intel-gfx] [PATCH] drm/i915/bdw: Broaden FBC resolution limit to 4096x4096

2014-06-16 Thread Sun, Daisy
Yes, the change starts from HSW. I'll update the patch. what's the "rant" I need to insert? I was not in the list a year ago:), having some trouble find the email as reference. Any archives I can look into? On 6/16/2014 11:15 AM, Daniel Vetter wrote: On Mon, Jun 16, 2014 at 06:11:45PM +0100,

Re: [Intel-gfx] [PATCH v3] drm/i915: Debugfs disable RPS boost and idle

2014-05-06 Thread Sun, Daisy
"So can you not tracepoints to give EI results for up/down signals and filter out the noise? ", Do you mean I don't need the debugfs at all? For developer, he/she is able to trace anything including the point of Turbo algorithm adjustment(+n/-n). But as a black box, validation will not see the c

Re: [Intel-gfx] [PATCH] drm/i915: Debugfs disable RPS boost and idle

2014-04-25 Thread Sun, Daisy
Thanks for the timely reply, Daniel. The intention to bring debugfs for RPS boost and idle is when boost and idle are disabled, we are able to have a clear vision of what normal turbo algorithm. It‘s very helpful to verify if the turbo algorithm is working as expected, at least from the VPG va