Re: [Intel-gfx] [PATCH v6 2/3] drm/i915/hwmon: Add hwmon support in libpower for dgfx

2022-12-06 Thread Tauro, Riana
On 12/7/2022 10:56 AM, Dixit, Ashutosh wrote: On Tue, 06 Dec 2022 21:17:46 -0800, Riana Tauro wrote: diff --git a/drivers/gpu/drm/i915/selftests/libpower.c b/drivers/gpu/drm/i915/selftests/libpower.c index c66e993c5f85..3d4d2dc74a54 100644 --- a/drivers/gpu/drm/i915/selftests/libpower.c +++

Re: [Intel-gfx] [PATCH v5 2/3] drm/i915/hwmon: Add helper function to obtain energy values

2022-12-04 Thread Tauro, Riana
On 12/3/2022 3:42 AM, Dixit, Ashutosh wrote: On Tue, 29 Nov 2022 21:34:26 -0800, Riana Tauro wrote: Hi Riana, Mostly looks good but I have a little nit below. diff --git a/drivers/gpu/drm/i915/i915_hwmon.c b/drivers/gpu/drm/i915/i915_hwmon.c index c588a17f97e9..57d4e96d5c72 100644 ---

Re: [Intel-gfx] [PATCH v3 3/3] drm/i915/selftests: Add hwmon support in libpower for dgfx

2022-11-28 Thread Tauro, Riana
On 11/22/2022 8:10 AM, Dixit, Ashutosh wrote: On Sun, 20 Nov 2022 23:29:46 -0800, Riana Tauro wrote: diff --git a/drivers/gpu/drm/i915/gt/selftest_rc6.c b/drivers/gpu/drm/i915/gt/selftest_rc6.c index 15b84c428f66..845058ed83ed 100644 --- a/drivers/gpu/drm/i915/gt/selftest_rc6.c +++ b/driver

Re: [Intel-gfx] [PATCH v2 1/1] drm/i915/guc/slpc: Add selftest for slpc tile-tile interaction

2022-10-30 Thread Tauro, Riana
On 10/28/2022 3:53 PM, Tvrtko Ursulin wrote: Hi, I peeked inside from curiosity and was pleasantly surprise to see kthread_work is used! Some comments below. On 28/10/2022 10:50, Riana Tauro wrote: Run a workload on tiles simultaneously by requesting for RP0 frequency. Pcode can however

Re: [Intel-gfx] [PATCH v2] drm/i915/slpc: Use platform limits for min/max frequency

2022-10-13 Thread Tauro, Riana
On 10/13/2022 9:25 PM, Vinay Belgaumkar wrote: GuC will set the min/max frequencies to theoretical max on ATS-M. This will break kernel ABI, so limit min/max frequency to RP0(platform max) instead. Also modify the SLPC selftest to update the min frequency when we have a server part so that we

Re: [Intel-gfx] [PATCH] drm/i915/slpc: Use platform limits for min/max frequency

2022-10-13 Thread Tauro, Riana
On 10/12/2022 11:56 PM, Vinay Belgaumkar wrote: GuC will set the min/max frequencies to theoretical max on ATS-M. This will break kernel ABI, so limit min/max frequency to RP0(platform max) instead. Also modify the SLPC selftest to update the min frequency when we have a server part so that w

Re: [Intel-gfx] [PATCH 3/3] drm/i915/guc/slpc: Add SLPC selftest live_slpc_power

2022-09-27 Thread Tauro, Riana
On 9/27/2022 4:42 PM, Gupta, Anshuman wrote: -Original Message- From: Belgaumkar, Vinay Sent: Monday, September 26, 2022 9:35 PM To: Tauro, Riana ; intel-gfx@lists.freedesktop.org Cc: Gupta, Anshuman ; Dixit, Ashutosh Subject: Re: [PATCH 3/3] drm/i915/guc/slpc: Add SLPC selftest