Re: [Intel-gfx] [PATCH] drm: Fix deadlock retry loop in page_flip_ioctl

2017-05-22 Thread Tommi Rantala
Cc: Jani Nikula > Cc: Sean Paul > Cc: David Airlie > Cc: dri-de...@lists.freedesktop.org > Reported-by: Tommi Rantala > Cc: Tommi Rantala > Cc: Michel Dänzer > Signed-off-by: Daniel Vetter Thanks, confirmed that this fixes the warning that I was seeing! Tested-by: Tommi R

Re: [Intel-gfx] [PATCH] drm/i915: Reject the colorkey ioctls for primary and cursor planes

2015-03-29 Thread Tommi Rantala
st move ahead with the colorkey property conversion. > > Cc: Tommi Rantala > Signed-off-by: Ville Syrjälä Thanks, this fixes the oopses I was seeing. Tommi ___ Intel-gfx mailing list Intel-gfx@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/intel-gfx

Re: [Intel-gfx] [PATCH] drm/i915: Rip out GET_SPRITE_COLORKEY ioctl

2015-03-27 Thread Tommi Rantala
it search in userspace and only found >>> broken definitions and no users anywhere. >>> >>> Cc: Tommi Rantala >>> Signed-off-by: Daniel Vetter >> >> Hm Tommi discovered oopses in there, so I guess this should be >> cherry-picked to -fixes+cc: stable

[Intel-gfx] intel_sprite_get_colorkey oops

2015-03-26 Thread Tommi Rantala
Hello, Trinity discovered oopses with the i915 colorkey ioctls, reproducible on my system with this: #include #include #include #include #include #include #include #include #define GET DRM_IOWR(DRM_COMMAND_BASE + DRM_I915_GET_SPRITE_COLORKEY, struct drm_intel_sprite_colorkey) int main(i

[Intel-gfx] [PATCH] drm/i915: fix definition of the DRM_IOCTL_I915_GET_SPRITE_COLORKEY ioctl

2015-03-26 Thread Tommi Rantala
Fix definition of the DRM_IOCTL_I915_GET_SPRITE_COLORKEY ioctl, so that it is different from the DRM_IOCTL_I915_SET_SPRITE_COLORKEY ioctl. Signed-off-by: Tommi Rantala --- include/uapi/drm/i915_drm.h | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/include/uapi/drm/i915_drm.h

Re: [Intel-gfx] [PATCH] drm: Fix deadlock due to getconnector locking changes

2015-03-02 Thread Tommi Rantala
2015-02-24 1:55 GMT+02:00 Marc Finet : > On Sun, Feb 22, 2015 at 11:38:36AM +0100, Daniel Vetter wrote: >> In >> >> daniel@phenom:~/linux/src$ git show ccfc08655 >> commit ccfc08655d5fd5076828f45fb09194c070f2f63a >> Author: Rob Clark >> Date: Thu Dec 18 16:01:48 2014 -0500 >> >> drm: tweak g

Re: [Intel-gfx] [PATCH] drm/i915: Sanity check incoming ioctl data for a NULL pointer

2013-04-11 Thread Tommi Rantala
2013/3/17 Chris Wilson : > On Mon, Mar 18, 2013 at 07:42:58AM +1000, Dave Airlie wrote: >> On Mon, Mar 18, 2013 at 7:40 AM, Chris Wilson >> wrote: >> > On Sun, Mar 17, 2013 at 08:50:03PM +0100, Daniel Vetter wrote: >> >> On Sat, Mar 16, 2013 at 11:19 AM, Chris Wilson >> >> wrote: >> >> > If *us

Re: [Intel-gfx] [PATCH] drm/i915: Sanity check incoming ioctl data for a NULL pointer

2013-03-17 Thread Tommi Rantala
2013/3/14 Chris Wilson : > In order to prevent a potential NULL deference with hostile userspace, > we need to check whether the ioctl was passed an invalid args pointer. > > Reported-by: Tommi Rantala > Link: > http://lkml.kernel.org/r/ca+ydwtpubvbwxbt-tdgpuvj1eu7it