[PATCH 6/8] drm/i915/display: update to plane_wm register access function

2024-11-05 Thread Vinod Govindapillai
flip is added Signed-off-by: Vinod Govindapillai --- drivers/gpu/drm/i915/display/skl_watermark.c | 11 ++- 1 file changed, 6 insertions(+), 5 deletions(-) diff --git a/drivers/gpu/drm/i915/display/skl_watermark.c b/drivers/gpu/drm/i915/display/skl_watermark.c index a01b1dc01348

[PATCH 3/8] drm/i915/display: update use_minimal_wm0_only to use intel_display

2024-11-05 Thread Vinod Govindapillai
Avoid using struct drm_i915_private reference and use intel_display instead. This is in preparation for the rest of the patches in this series where hw support for the minimum and interim ddb allocations for async flip is added Signed-off-by: Vinod Govindapillai --- drivers/gpu/drm/i915/display

[PATCH 8/8] drm/i915/debugfs: add dbuf alloc status as part of i915_ddb_info

2024-11-04 Thread Vinod Govindapillai
>From xe3 onwards, there is a provision to define and use min ddb and interim ddb allocations for async flip use case. Add the dbuf allocation status as part of i915_ddb_info as well to show if min or interim ddb is being used. Bspec: 72053 Signed-off-by: Vinod Govindapillai --- .../drm/i

[PATCH 7/8] drm/i915/xe3: Use hw support for min/interim ddb allocations for async flip

2024-11-04 Thread Vinod Govindapillai
programmed. Bspec: 69880, 72053 Signed-off-by: Stanislav Lisovskiy Signed-off-by: Vinod Govindapillai --- .../gpu/drm/i915/display/intel_atomic_plane.c | 9 ++ .../drm/i915/display/intel_display_types.h| 8 ++ .../drm/i915/display/skl_universal_plane.c| 31 +++ .../i915/display

[PATCH 4/8] drm/i915/display: update use_min_ddb to use intel_display

2024-11-04 Thread Vinod Govindapillai
Avoid using struct drm_i915_private reference and use intel_display instead. This is in preparation for the rest of the patches in this series where hw support for the minimum and interim ddb allocations for async flip is added Signed-off-by: Vinod Govindapillai --- drivers/gpu/drm/i915/display

[PATCH 5/8] drm/i915/display: update skl_plane_wm_equals to use intel_display

2024-11-04 Thread Vinod Govindapillai
Use intel_display object instead of struct drm_i915_private in skl_plane_wm_equals(). This is in preparation for the rest of the patches in this series where hw support for the minimum and interim ddb allocations for async flip is added Signed-off-by: Vinod Govindapillai --- drivers/gpu/drm

[PATCH 2/8] drm/i9i5/display: use intel_display in intel_de_read calls of skl_watermark.c

2024-11-04 Thread Vinod Govindapillai
Convert all intel_de_read() to use intel_display instead of struct drm_i915_private object. This is in preparation for the rest of the patches in this series where hw support for the minimum and interim ddb allocations for async flip is added. Signed-off-by: Vinod Govindapillai --- drivers/gpu

[PATCH 1/8] drm/i915/display: update intel_enabled_dbuf_slices_mask to use intel_display

2024-11-04 Thread Vinod Govindapillai
Update intel_enabled_dbuf_slices_mask to use intel_display instead of drm_i915_private object. This is a prepratory patch for the next patch in the series, where all intel_de_read calls in skl_watermarks.c are updated to use intel_display instead of drm_i915_private. Signed-off-by: Vinod

[PATCH 0/8] use hw support for min/interim ddb allocation for async flip

2024-11-04 Thread Vinod Govindapillai
): drm/i915/xe3: Use hw support for min/interim ddb allocations for async flip Vinod Govindapillai (7): drm/i915/display: update intel_enabled_dbuf_slices_mask to use intel_display drm/i9i5/display: use intel_display in intel_de_read calls of skl_watermark.c drm/i915/display

[PATCH v7] drm/i915: Implement Dbuf overlap detection feature starting from LNL

2024-10-30 Thread Vinod Govindapillai
ned-off-by: Stanislav Lisovskiy Signed-off-by: Vinod Govindapillai --- drivers/gpu/drm/i915/display/intel_display_device.c | 5 + drivers/gpu/drm/i915/display/intel_display_device.h | 2 ++ drivers/gpu/drm/i915/display/intel_display_irq.c| 10 ++ drivers/gpu/drm/i915/i915_re

[PATCH v6] drm/i915: Implement Dbuf overlap detection feature starting from LNL

2024-10-29 Thread Vinod Govindapillai
off-by: Vinod Govindapillai --- drivers/gpu/drm/i915/display/intel_display_device.c | 5 + drivers/gpu/drm/i915/display/intel_display_device.h | 2 ++ drivers/gpu/drm/i915/display/intel_display_irq.c| 10 ++ drivers/gpu/drm/i915/i915_reg.h | 2 ++ 4 files chan

[PATCH] drm/i915: Implement Dbuf overlap detection feature starting from LNL

2024-10-29 Thread Vinod Govindapillai
ror message to kernel log. v2: Initialize dbuf overlap flag in runtime_defaults (Jani Nikula) v3: Unmask the overlap detection interrupt (Uma) v4: use display over i915 (Jani Nikula) Bspec: 69450 Signed-off-by: Stanislav Lisovskiy Signed-off-by: Vinod Govindapillai --- drivers/gpu/drm/i915/disp

[PATCH] drm/i915: Implement Dbuf overlap detection feature starting from LNL

2024-10-28 Thread Vinod Govindapillai
ror message to kernel log. v2: Initialize dbuf overlap flag in runtime_defaults (Jani Nikula) v3: Unmask the overlap detection interrupt (Uma) Bspec: 69450 Signed-off-by: Stanislav Lisovskiy Signed-off-by: Vinod Govindapillai --- drivers/gpu/drm/i915/display/intel_display_device.c |

[PATCH 9/9] drm/i915/display: update audio bw calculations for MTL

2024-10-08 Thread Vinod Govindapillai
Update the reference overhaed values for audio bw calculations for MTL onwards Bspec: 67768 Signed-off-by: Vinod Govindapillai --- drivers/gpu/drm/i915/display/intel_dp.c | 7 ++- 1 file changed, 6 insertions(+), 1 deletion(-) diff --git a/drivers/gpu/drm/i915/display/intel_dp.c b/drivers

[PATCH 8/9] drm/i815/disaply: limit the audio bw check with DP2 config

2024-10-08 Thread Vinod Govindapillai
Limit the audio bw check with DP2 configurations only Signed-off-by: Vinod Govindapillai --- drivers/gpu/drm/i915/display/intel_dp.c | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/drivers/gpu/drm/i915/display/intel_dp.c b/drivers/gpu/drm/i915/display/intel_dp.c index

[PATCH 7/9] drm/i915/display: update audio support based on the available frequencies

2024-10-08 Thread Vinod Govindapillai
After pruning the sad audio frequency list, if there are no supported audio frequencies left, audio cannot be supported. So mark has_audio accordingly. Signed-off-by: Vinod Govindapillai --- drivers/gpu/drm/i915/display/intel_audio.c | 7 ++- 1 file changed, 6 insertions(+), 1 deletion

[PATCH 4/9] drm/i915/display: update logic to determine crtcstate has audio support

2024-10-08 Thread Vinod Govindapillai
In intel_dp_audio_compute_config() pipe_config->has_audio decision is now based on combination of two condition checks. Split out these condition as two separate checks to facilitate handling has_audio decision when we introduce audio bw checks in the follow up patches. Signed-off-by: Vi

[PATCH 6/9] drm/i915/display: iterare through channels if no feasible frequencies

2024-10-08 Thread Vinod Govindapillai
For a pipe configuration, if no supported audio frequencies are found, then start reducing the audio channels and try assess the sad audio frequency list again. Bspec: 67768 Signed-off-by: Vinod Govindapillai --- drivers/gpu/drm/i915/display/intel_audio.c | 32 -- 1 file

[PATCH 5/9] drm/i915/display: check and prune audio frequencies based on bw limits

2024-10-08 Thread Vinod Govindapillai
Calculate the audio bw requirements and check the supported sad audio frequencies are feasible with selected pipe configuration. If not feasible, prune the audio frequencies from sad list. Bspec: 67768 Signed-off-by: Vinod Govindapillai --- drivers/gpu/drm/i915/display/intel_audio.c | 107

[PATCH 3/9] drm/i915/display: update call to intel_dp_audio_compute_config

2024-10-08 Thread Vinod Govindapillai
assess if an audio frequency can be supported with a pipe config. Signed-off-by: Vinod Govindapillai --- drivers/gpu/drm/i915/display/intel_dp.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/drivers/gpu/drm/i915/display/intel_dp.c b/drivers/gpu/drm/i915/display

[PATCH 2/9] drm/i915/display: create a common function to check validity of ELD

2024-10-08 Thread Vinod Govindapillai
We would need to check the validity of connector ELD from multiple places in the follow up patches. So create a separate function to check the validity for ELD. Signed-off-by: Vinod Govindapillai --- drivers/gpu/drm/i915/display/intel_audio.c | 18 ++ 1 file changed, 14

[PATCH 1/9] drm/i915/display: get rid of encoder param in intel_audio_compute_config

2024-10-08 Thread Vinod Govindapillai
ls. In the followup patches, we don't even need the drm_i915_private object in this function. Signed-off-by: Vinod Govindapillai --- drivers/gpu/drm/i915/display/intel_audio.c | 5 ++--- drivers/gpu/drm/i915/display/intel_audio.h | 3 +-- drivers/gpu/drm/i915/display/intel_dp.c| 2 +- drive

[PATCH 0/9] prunue audio frequencies based on bw limits for DP2

2024-10-08 Thread Vinod Govindapillai
and the assessment is done again. Eventually both supported audio frequency and channels are updated to SAD in ELD. TODO: Update the hblank available calculations for Xe3 Vinod Govindapillai (9): drm/i915/display: get rid of encoder param in intel_audio_compute_config drm/i915/display

[PATCH v2] drm/i915: Implement Dbuf overlap detection feature starting from LNL

2024-08-22 Thread Vinod Govindapillai
ror message to kernel log. v2: Initialize dbuf overlap flag in runtime_defaults (Jani Nikula) Signed-off-by: Stanislav Lisovskiy Signed-off-by: Vinod Govindapillai --- drivers/gpu/drm/i915/display/intel_display_device.c | 5 + drivers/gpu/drm/i915/display/intel_display_device.h | 2 ++ driv

[PATCH v2] drm/i915: Implement Dbuf overlap detection feature starting from LNL

2024-08-22 Thread Vinod Govindapillai
ror message to kernel log. v2: Initialize dbuf overlap flag in runtime_defaults (Jani Nikula) Signed-off-by: Stanislav Lisovskiy Signed-off-by: Vinod Govindapillai --- drivers/gpu/drm/i915/display/intel_display_device.c | 5 + drivers/gpu/drm/i915/display/intel_display_device.h | 2 ++ driv

[PATCH v3] drm/i915/display: update handling of FBC when VT-d active workaround

2024-05-28 Thread Vinod Govindapillai
) Bspec: 21664 Suggested-by: Ville Syrjälä Signed-off-by: Vinod Govindapillai --- drivers/gpu/drm/i915/display/intel_fbc.c | 22 ++ 1 file changed, 6 insertions(+), 16 deletions(-) diff --git a/drivers/gpu/drm/i915/display/intel_fbc.c b/drivers/gpu/drm/i915/display/intel_fbc.c

[PATCH v2] drm/i915/display: update handling of FBC when VT-d active workaround

2024-05-28 Thread Vinod Govindapillai
: Vinod Govindapillai --- drivers/gpu/drm/i915/display/intel_fbc.c | 22 ++ 1 file changed, 6 insertions(+), 16 deletions(-) diff --git a/drivers/gpu/drm/i915/display/intel_fbc.c b/drivers/gpu/drm/i915/display/intel_fbc.c index e9189a864f69..492dc26ecfa2 100644 --- a/drivers

[PATCH] drm/i915/display: update handling of FBC when VT-d active workaround

2024-05-28 Thread Vinod Govindapillai
Move the handling of the disabling FBC when VT-d is active wa as part of the intel_fbc_check_plane() Bspec: 21664 Signed-off-by: Vinod Govindapillai --- drivers/gpu/drm/i915/display/intel_fbc.c | 22 ++ 1 file changed, 6 insertions(+), 16 deletions(-) diff --git a/drivers

[PATCH v1] drm/xe: avoid the async_flip update in the initial plane config

2024-04-19 Thread Vinod Govindapillai
Async flip call is not needed. The updated fb mapping is updated as part of the fixup_initial_plane_config() call. Otherwise we end up updating the PLAN_SURF register twice with the same info. v2: avoid async_flip instead of removing fixup call (Ville) Signed-off-by: Vinod Govindapillai

[PATCH v1] drm/xe: no need to call fixup_initial_plane_config in XE

2024-04-12 Thread Vinod Govindapillai
In XE, the updated fb mapping is already done and updated as part of intel_find_initial_plane_obj(). So no need to invoke fixup_initial_plane_config() again as it would basically write the same data to "PLAN_SURF" again. Signed-off-by: Vinod Govindapillai --- drivers/gpu/drm/

[PATCH v1 1/1] iommu/vt-d: Fix WARN_ON in iommu probe path

2024-04-09 Thread Vinod Govindapillai
quot;iommu/vt-d: Use rbtree to track iommu probed devices") Signed-off-by: Lu Baolu Signed-off-by: Vinod Govindapillai --- drivers/iommu/intel/iommu.c | 11 +++ 1 file changed, 7 insertions(+), 4 deletions(-) diff --git a/drivers/iommu/intel/iommu.c b/drivers/iommu/intel/i

[PATCH v1 0/1] iommu/vt-d: Fix WARN_ON in iommu probe path

2024-04-09 Thread Vinod Govindapillai
This has already been sent to try bot https://patchwork.freedesktop.org/series/132132/ Lu Baolu (1): iommu/vt-d: Fix WARN_ON in iommu probe path drivers/iommu/intel/iommu.c | 11 +++ 1 file changed, 7 insertions(+), 4 deletions(-) -- 2.34.1

[PATCH v10 6/6] drm/i915/display: force qgv check after the hw state readout

2024-04-05 Thread Vinod Govindapillai
. Signed-off-by: Vinod Govindapillai --- drivers/gpu/drm/i915/display/intel_bw.c | 8 ++-- drivers/gpu/drm/i915/display/intel_bw.h | 6 ++ 2 files changed, 12 insertions(+), 2 deletions(-) diff --git a/drivers/gpu/drm/i915/display/intel_bw.c b/drivers/gpu/drm/i915/display/intel_bw.c index

[PATCH v10 5/6] drm/i915/display: handle systems with duplicate psf gv points

2024-04-05 Thread Vinod Govindapillai
o qgv points as well (Vinod) v2: - pcode confirms that for qgv points, it sets whatever the driver sets (Vinod) Signed-off-by: Stanislav Lisovskiy Signed-off-by: Vinod Govindapillai --- drivers/gpu/drm/i915/display/intel_bw.c | 2 ++ 1 file changed, 2 insertions(+) diff --git a/drivers/gp

[PATCH v10 4/6] drm/i915/display: Disable SAGV on bw init, to force QGV point recalculation

2024-04-05 Thread Vinod Govindapillai
4 (Vinod) v8: - Simplify icl_force_disable_sagv (Vinod) Signed-off-by: Stanislav Lisovskiy Signed-off-by: Vinod Govindapillai --- drivers/gpu/drm/i915/display/intel_bw.c | 50 ++-- drivers/gpu/drm/i915/display/skl_watermark.c | 2 +- drivers/gpu/drm/i915/display/skl_watermar

[PATCH v10 3/6] drm/i915/display: extract code to prepare qgv points mask

2024-04-05 Thread Vinod Govindapillai
Extract the code to prepare the QGV points mask as per the format expected by the pcode as this could be utlized from multiple points. Signed-off-by: Vinod Govindapillai --- drivers/gpu/drm/i915/display/intel_bw.c | 16 +++- 1 file changed, 11 insertions(+), 5 deletions(-) diff

[PATCH v10 1/6] drm/i915/display: Add meaningful traces for QGV point info error handling

2024-04-05 Thread Vinod Govindapillai
ing to get access to target device and adding those traces manually. v2: - Make the debug more generic and move it to intel_dram_detect (Gustavo Sousa) v3: - Use %u for unsigned variable in debug prints (Gustavo) Reviewed-by: Gustavo Sousa Signed-off-by: Stanislav Lisovskiy Signed-off

[PATCH v10 2/6] drm/i915/display: Extract code required to calculate max qgv/psf gv point

2024-04-05 Thread Vinod Govindapillai
v_point_mask to return max qgv point mask (Vinod) v4: - Minor changes in icl_find_qgv_points (Vinod) Signed-off-by: Stanislav Lisovskiy Signed-off-by: Vinod Govindapillai --- drivers/gpu/drm/i915/display/intel_bw.c | 80 +++-- 1 file changed, 50 insertions(+), 30 deletions

[PATCH v10 0/6] QGV/SAGV related fixes

2024-04-05 Thread Vinod Govindapillai
calculate max qgv/psf gv point drm/i915/display: Disable SAGV on bw init, to force QGV point recalculation drm/i915/display: handle systems with duplicate psf gv points Vinod Govindapillai (2): drm/i915/display: extract code to prepare qgv points mask drm/i915/display: force qgv

[PATCH v9 6/6] drm/i915/display: force qgv check after the hw state readout

2024-03-26 Thread Vinod Govindapillai
. Signed-off-by: Vinod Govindapillai --- drivers/gpu/drm/i915/display/intel_bw.c | 8 ++-- drivers/gpu/drm/i915/display/intel_bw.h | 6 ++ 2 files changed, 12 insertions(+), 2 deletions(-) diff --git a/drivers/gpu/drm/i915/display/intel_bw.c b/drivers/gpu/drm/i915/display/intel_bw.c index

[PATCH v9 4/6] drm/i915/display: Disable SAGV on bw init, to force QGV point recalculation

2024-03-26 Thread Vinod Govindapillai
4 (Vinod) v8: - Simplify icl_force_disable_sagv (Vinod) Signed-off-by: Stanislav Lisovskiy Signed-off-by: Vinod Govindapillai --- drivers/gpu/drm/i915/display/intel_bw.c | 50 ++-- drivers/gpu/drm/i915/display/skl_watermark.c | 2 +- drivers/gpu/drm/i915/display/skl_watermar

[PATCH v9 5/6] drm/i915/display: handle systems with duplicate qgv/psf gv points

2024-03-26 Thread Vinod Govindapillai
Lisovskiy Signed-off-by: Vinod Govindapillai --- drivers/gpu/drm/i915/display/intel_bw.c | 4 1 file changed, 4 insertions(+) diff --git a/drivers/gpu/drm/i915/display/intel_bw.c b/drivers/gpu/drm/i915/display/intel_bw.c index 5f4f93524bef..f6690d545d95 100644 --- a/drivers/gpu/drm/i915

[PATCH v9 2/6] drm/i915/display: Extract code required to calculate max qgv/psf gv point

2024-03-26 Thread Vinod Govindapillai
v_point_mask to return max qgv point mask (Vinod) v4: - Minor changes in icl_find_qgv_points (Vinod) Signed-off-by: Stanislav Lisovskiy Signed-off-by: Vinod Govindapillai --- drivers/gpu/drm/i915/display/intel_bw.c | 80 +++-- 1 file changed, 50 insertions(+), 30 deletions

[PATCH v9 3/6] drm/i915/display: extract code to prepare qgv points mask

2024-03-26 Thread Vinod Govindapillai
Extract the code to prepare the QGV points mask as per the format expected by the pcode as this could be utlized from multiple points. Signed-off-by: Vinod Govindapillai --- drivers/gpu/drm/i915/display/intel_bw.c | 16 +++- 1 file changed, 11 insertions(+), 5 deletions(-) diff

[PATCH v9 1/6] drm/i915/display: Add meaningful traces for QGV point info error handling

2024-03-26 Thread Vinod Govindapillai
ing to get access to target device and adding those traces manually. v2: - Make the debug more generic and move it to intel_dram_detect (Gustavo Sousa) v3: - Use %u for unsigned variable in debug prints (Gustavo) Reviewed-by: Gustavo Sousa Signed-off-by: Stanislav Lisovskiy Signed-off

[PATCH v9 0/6] QGV/SAGV related fixes

2024-03-26 Thread Vinod Govindapillai
calculate max qgv/psf gv point drm/i915/display: Disable SAGV on bw init, to force QGV point recalculation drm/i915/display: handle systems with duplicate qgv/psf gv points Vinod Govindapillai (2): drm/i915/display: extract code to prepare qgv points mask drm/i915/display: force

[PATCH v8 4/4] drm/i915/display: handle systems with duplicate qgv/psf gv points

2024-03-25 Thread Vinod Govindapillai
Lisovskiy Signed-off-by: Vinod Govindapillai --- drivers/gpu/drm/i915/display/intel_bw.c | 4 1 file changed, 4 insertions(+) diff --git a/drivers/gpu/drm/i915/display/intel_bw.c b/drivers/gpu/drm/i915/display/intel_bw.c index 844d2d9efeb4..20c67474154e 100644 --- a/drivers/gpu/drm/i915

[PATCH v8 3/4] drm/i915: Disable SAGV on bw init, to force QGV point recalculation

2024-03-25 Thread Vinod Govindapillai
4 (Vinod) Signed-off-by: Stanislav Lisovskiy Signed-off-by: Vinod Govindapillai --- drivers/gpu/drm/i915/display/intel_bw.c | 55 ++-- drivers/gpu/drm/i915/display/skl_watermark.c | 2 +- drivers/gpu/drm/i915/display/skl_watermark.h | 1 + 3 files changed, 54 insertio

[PATCH v8 2/4] drm/i915: Extract code required to calculate max qgv/psf gv point

2024-03-25 Thread Vinod Govindapillai
v_point_mask to return max qgv point mask (Vinod) Signed-off-by: Stanislav Lisovskiy Signed-off-by: Vinod Govindapillai --- drivers/gpu/drm/i915/display/intel_bw.c | 76 - 1 file changed, 49 insertions(+), 27 deletions(-) diff --git a/drivers/gpu/drm/i915/displa

[PATCH v8 1/4] drm/i915: Add meaningful traces for QGV point info error handling

2024-03-25 Thread Vinod Govindapillai
ing to get access to target device and adding those traces manually. v2: - Make the debug more generic and move it to intel_dram_detect (Gustavo Sousa) v3: - Use %u for unsigned variable in debug prints (Gustavo) Reviewed-by: Gustavo Sousa Signed-off-by: Stanislav Lisovskiy Signed-off

[PATCH v8 0/4] QGV/SAGV related fixes

2024-03-25 Thread Vinod Govindapillai
We have couple of customer issues, related to SAGV/QGV point calculation. Those patches contain fixes plus some additional debugs for those issues. Stanislav Lisovskiy (4): drm/i915: Add meaningful traces for QGV point info error handling drm/i915: Extract code required to calculate max qgv/ps

[PATCH v1 6/6] drm/xe/lnl: Enable the display support

2024-02-22 Thread Vinod Govindapillai
From: Balasubramani Vivekanandan Enable the display support for LUNARLAKE Signed-off-by: Balasubramani Vivekanandan Signed-off-by: Lucas De Marchi Reviewed-by: Matt Roper --- drivers/gpu/drm/xe/xe_pci.c | 1 + 1 file changed, 1 insertion(+) diff --git a/drivers/gpu/drm/xe/xe_pci.c b/drivers

[PATCH v1 5/6] drm/i915/xe2lpd: Load DMC

2024-02-22 Thread Vinod Govindapillai
From: Balasubramani Vivekanandan Load DMC for XE2LPD. The value 0x8000 is the maximum payload size for any xe2lpd dmc firmware. Signed-off-by: Balasubramani Vivekanandan Signed-off-by: Dnyaneshwar Bhadane --- drivers/gpu/drm/i915/display/intel_dmc.c | 9 - 1 file changed, 8 insertions

[PATCH v1 4/6] drm/i915/xe2lpd: Update mbus on post plane updates

2024-02-22 Thread Vinod Govindapillai
From: Stanislav Lisovskiy According to BSpec we need to write the MBUS CTL and DBUF CTL both for increasing CDCLK case (pre plane) and for decreasing CDCLK case (post plane). Make sure those updates are in place for Xe2-LPD. Since the mbus update is not only on pre-enable anymore, also rename th

[PATCH v1 2/6] drm/i915/lnl: Add programming for CDCLK change

2024-02-22 Thread Vinod Govindapillai
From: Ravi Kumar Vodapalli Add programming sequence for changes on CDCLK for Lunar Lake platforms. It's mostly the same as MTL, but with some additional programming for the squash and crawling steps when a change in mdclk/cdclk ratio is observed. v2: Remove wrong changes for bxt_cdclk_cd2x_pipe(

[PATCH v1 3/6] drm/i915/xe2lpd: Write DBuf after CDCLK change in post plane

2024-02-22 Thread Vinod Govindapillai
From: Stanislav Lisovskiy Previously we always updated DBuf MBUS CTL and DBUF CTL regs after CDCLK has been changed(CDCLK_CTL), however for Xe2-LPD we can't do like that anymore. According to BSpec, we have to first update DBuf regs and then write CDCLK regs, when CDCLK is decreased, which we do

[PATCH v1 1/6] drm/i915/lnl: Introduce MDCLK_CDCLK ratio to DBuf

2024-02-22 Thread Vinod Govindapillai
since it's compatible with previous versions (Matt Roper) - Squash the serialization of global state when mdclk_cdclk_ratio changes Bspec: 68864, 69482, 69445 Cc: Mika Kahola Signed-off-by: Stanislav Lisovskiy Signed-off-by: Lucas De Marchi Signed-off-by: Vinod Govindap

[PATCH v1 0/6] LNL display

2024-02-22 Thread Vinod Govindapillai
Rest of the cdclk patches as well as the patches to enable the display in LNL Balasubramani Vivekanandan (2): drm/i915/xe2lpd: Load DMC drm/xe/lnl: Enable the display support Ravi Kumar Vodapalli (1): drm/i915/lnl: Add programming for CDCLK change Stanislav Lisovskiy (3): drm/i915/lnl: I

[PATCH v1 2/2] drm/xe: Modify the cfb size to be page size aligned for FBC

2024-01-10 Thread Vinod Govindapillai
drm_gem_private_object_init expect the object size be page size aligned. The xe_bo create functions do not update the size for any alignment requirements. So align cfb size to be page size aligned in xe stolen memory handling. Signed-off-by: Vinod Govindapillai --- drivers/gpu/drm/xe/compat

[PATCH v1 1/2] drm/i915/display: use PAGE_SIZE macro for FBC cfb alloc

2024-01-10 Thread Vinod Govindapillai
FBC compressed frame buffer size need to be PAGE_SIZE aligned and the corresponding the drm_gem functions check the object size alignment using PAGE_SIZE macro. Use the PAGE_SIZE macro in the cfb alloc as well instead of the magic number. Signed-off-by: Vinod Govindapillai --- drivers/gpu/drm

[PATCH v1 0/2] drm/xe: ensure fbc cfb size to be page size aligned

2024-01-10 Thread Vinod Govindapillai
DRM gem object handling expet the object size to be page size aligned. Neither the driver or xe stolen memory handlers do that causing BUG_ON being triggered in some cases. Vinod Govindapillai (2): drm/i915/display: use PAGE_SIZE macro for FBC cfb alloc drm/xe: Modify the cfb size to be page

[Intel-gfx] [PATCH v4 1/1] drm/i915/xe2lpd: implement WA for underruns while enabling FBC

2023-11-11 Thread Vinod Govindapillai
FIFO underruns are observed when FBC is enabled on plane 2 or plane 3. Recommended WA is to update the FBC enabling sequence. The plane binding register bits need to be updated separately before programming the FBC enable bit. Bspec: 74151 Reviewed-by: Mika Kahola #v3 Signed-off-by: Vinod

[Intel-gfx] [PATCH v4 0/1] drm/i915/xe2lpd: WA for underruns during FBC enable

2023-11-11 Thread Vinod Govindapillai
removed reference to PSR from the comments Added reference to HSD v4: updated the comments to include wa number Vinod Govindapillai (1): drm/i915/xe2lpd: implement WA for underruns while enabling FBC drivers/gpu/drm/i915/display/intel_fbc.c | 8 +++- 1 file changed, 7 insertions(+), 1

[Intel-gfx] [PATCH v1 1/1] drm/i915/xe2lpd: remove the FBC restriction if PSR2 is enabled

2023-11-10 Thread Vinod Govindapillai
In earlier versions, FBC was restricted if PSR2 is enabled. From xe2lpd onwards no such restrictions are needed anymore. HSD: 14014305387 Signed-off-by: Vinod Govindapillai --- drivers/gpu/drm/i915/display/intel_fbc.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers

[Intel-gfx] [PATCH v1 0/1] drm/i915/xe2lpd: remove FBC restriction if PSR2 is enabled

2023-11-10 Thread Vinod Govindapillai
FBC restriction when PSR2 is enabled can be removed in xe2lpd Vinod Govindapillai (1): drm/i915/xe2lpd: remove the FBC restriction if PSR2 is enabled drivers/gpu/drm/i915/display/intel_fbc.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) -- 2.34.1

[Intel-gfx] [PATCH v3 1/1] drm/i915/xe2lpd: implement WA for underruns while enabling FBC

2023-11-08 Thread Vinod Govindapillai
: Vinod Govindapillai --- drivers/gpu/drm/i915/display/intel_fbc.c | 13 - 1 file changed, 12 insertions(+), 1 deletion(-) diff --git a/drivers/gpu/drm/i915/display/intel_fbc.c b/drivers/gpu/drm/i915/display/intel_fbc.c index bde12fe62275..8a3594e4d992 100644 --- a/drivers/gpu/drm/i915

[Intel-gfx] [PATCH v3 0/1] drm/i915/xe2lpd: WA for underruns during FBC enable

2023-11-08 Thread Vinod Govindapillai
removed reference to PSR from the comments Added reference to HSD Vinod Govindapillai (1): drm/i915/xe2lpd: implement WA for underruns while enabling FBC drivers/gpu/drm/i915/display/intel_fbc.c | 13 - 1 file changed, 12 insertions(+), 1 deletion(-) -- 2.34.1

[Intel-gfx] [PATCH v2 1/1] drm/i915/xe2lpd: implement WA for underruns while enabling FBC

2023-11-08 Thread Vinod Govindapillai
Because of HW bug, the FBC enabling sequence need to be updated. The plane binding registrer need to be updated before programming the FBC enable bit. Signed-off-by: Vinod Govindapillai --- drivers/gpu/drm/i915/display/intel_fbc.c | 12 +++- 1 file changed, 11 insertions(+), 1 deletion

[Intel-gfx] [PATCH v2 0/1] drm/i915/xe2lpd: WA for underruns during FBC enable

2023-11-08 Thread Vinod Govindapillai
Update the FBC enabling sequence. The plane binding register bits need to programmed before fbe enable bit. v2: update the patch subject and description as this underrun is not tied to PSR. FIFO underruns are observed when FBC is enabled on plane other than the primary. Vinod

[Intel-gfx] [PATCH v1 1/1] drm/i915/xe2lpd: alternate WA for underruns with PSR2 and FBC

2023-11-02 Thread Vinod Govindapillai
Implement the alternate WA for the underruns when both PSR2 and FBC is enabled. Signed-off-by: Vinod Govindapillai --- drivers/gpu/drm/i915/display/intel_fbc.c | 12 +++- 1 file changed, 11 insertions(+), 1 deletion(-) diff --git a/drivers/gpu/drm/i915/display/intel_fbc.c b/drivers

[Intel-gfx] [PATCH v1 0/1] drm/i915/xe2lpd: alternate WA for underruns with PSR2 and FBC

2023-11-02 Thread Vinod Govindapillai
Implement the alternate WA for the underruns when both PSR2 and FBC is enabled. Vinod Govindapillai (1): drm/i915/xe2lpd: alternate WA for underruns with PSR2 and FBC drivers/gpu/drm/i915/display/intel_fbc.c | 12 +++- 1 file changed, 11 insertions(+), 1 deletion(-) -- 2.34.1

[Intel-gfx] [PATCH v1 0/2] drm/i915/xe2lpd: choose between PSR2 and FBC

2023-11-02 Thread Vinod Govindapillai
In devices with PSR2 + FBC support, choose between PSR2 selective fetch and FBC based on the better power saving efficiency Vinod Govindapillai (2): drm/i915/xe2lpd: check selective fetch is optimal in some cases drm/i915/xe2lpd: prefer FBC for full frame fetch in PSR2 .../drm/i915/display

[Intel-gfx] [PATCH v1 2/2] drm/i915/xe2lpd: prefer FBC for full frame fetch in PSR2

2023-11-02 Thread Vinod Govindapillai
If the selective fetch is not optimal, use FBC Bspec: 68881 Signed-off-by: Vinod Govindapillai --- drivers/gpu/drm/i915/display/intel_fbc.c | 11 +-- 1 file changed, 9 insertions(+), 2 deletions(-) diff --git a/drivers/gpu/drm/i915/display/intel_fbc.c b/drivers/gpu/drm/i915/display

[Intel-gfx] [PATCH v1 1/2] drm/i915/xe2lpd: check selective fetch is optimal in some cases

2023-11-02 Thread Vinod Govindapillai
If both PSR2 + FBC is supported, in cases where the selective fetch area is greater than 25% of the screen area, FBC might be more efficient. So have a possibility to check this and add provision to enable FBC in such cases. Bspec: 68881 Signed-off-by: Vinod Govindapillai --- .../drm/i915

[Intel-gfx] [PATCH v4 0/2] display device info as a separate debugfs entry

2023-10-18 Thread Vinod Govindapillai
.sha...@intel.com Vinod Govindapillai (2): drm/i915/display: debugfs entry to list display capabilities drm/i915: remove display device info from i915 capabilities drivers/gpu/drm/i915/display/intel_display_debugfs.c | 12 drivers/gpu/drm/i915/i915_debugfs.c | 1

[Intel-gfx] [PATCH v4 1/2] drm/i915/display: debugfs entry to list display capabilities

2023-10-18 Thread Vinod Govindapillai
Create a separate debugfs entry to list the display capabilities IGT can rely on this debugfs entry for tests that depend on display device and display runtime info for both xe and i915 drivers. v2: rename the entry to i915_display_capabilities (Chaitanya) Signed-off-by: Vinod Govindapillai

[Intel-gfx] [PATCH v4 2/2] drm/i915: remove display device info from i915 capabilities

2023-10-18 Thread Vinod Govindapillai
Display device and display runtime info is exposed as part of i915_display_capabilities debugfs entry. Remove this information from i915_ capabilities as it is now reduntant. Signed-off-by: Vinod Govindapillai --- drivers/gpu/drm/i915/i915_debugfs.c | 1 - 1 file changed, 1 deletion(-) diff

[Intel-gfx] [PATCH v3 1/1] drm/i915/display: debugfs entry to list display capabilities

2023-10-17 Thread Vinod Govindapillai
Create a separate debugfs entry to list the display capabilities IGT can rely on this debugfs entry for tests that depend on display device and display runtime info for both xe and i915 drivers. v2: rename the entry to i915_display_capabilities (Chaitanya) Signed-off-by: Vinod Govindapillai

[Intel-gfx] [PATCH v3 0/1] display device info as a separate debugfs entry

2023-10-17 Thread Vinod Govindapillai
i915_capabilities from this patch series. Remove this only after IGT starts using the i915_display_capabilities Vinod Govindapillai (1): drm/i915/display: debugfs entry to list display capabilities drivers/gpu/drm/i915/display/intel_display_debugfs.c | 12 1 file changed, 12

[Intel-gfx] [PATCH v2 1/2] drm/i915/display: debugfs entry to list display capabilities

2023-10-17 Thread Vinod Govindapillai
Create a separate debugfs entry to list the display capabilities IGT can rely on this debugfs entry for tests that depend on display device and display runtime info for both xe and i915 drivers. v2: rename the entry to i915_display_capabilities (Chaitanya) Signed-off-by: Vinod Govindapillai

[Intel-gfx] [PATCH v2 2/2] drm/i915: remove display device info from i915 capabilities

2023-10-17 Thread Vinod Govindapillai
Display device and display runtime info is exposed as part of i915_display_capabilities debugfs entry. Remove this information from i915_ capabilities as it is now reduntant. Signed-off-by: Vinod Govindapillai --- drivers/gpu/drm/i915/i915_debugfs.c | 1 - 1 file changed, 1 deletion(-) diff

[Intel-gfx] [PATCH v2 0/2] display device info as a separate debugfs entry

2023-10-17 Thread Vinod Govindapillai
Expose the display device info as a separate debugfs entry to list out display device info and remove the same from i915_capabilities v2: rename the debugs entry to i915_display_capabilities and patch description changes Vinod Govindapillai (2): drm/i915/display: debugfs entry to list

[Intel-gfx] [PATCH v1 2/2] drm/i915: remove display device info from i915 capabilities

2023-10-17 Thread Vinod Govindapillai
Display device info is exposed as a separate debugfs entry. So remove the duplicate entries from i915_capabilities debugfs Signed-off-by: Vinod Govindapillai --- drivers/gpu/drm/i915/i915_debugfs.c | 1 - 1 file changed, 1 deletion(-) diff --git a/drivers/gpu/drm/i915/i915_debugfs.c b/drivers

[Intel-gfx] [PATCH v1 1/2] drm/i915/display: display device info debugfs entry

2023-10-17 Thread Vinod Govindapillai
Have a common debugfs entry to get the display device info for both xe and i915 drivers. Signed-off-by: Vinod Govindapillai --- drivers/gpu/drm/i915/display/intel_display_debugfs.c | 11 +++ 1 file changed, 11 insertions(+) diff --git a/drivers/gpu/drm/i915/display

[Intel-gfx] [PATCH v1 0/2] display device info as a separate debugfs entry

2023-10-17 Thread Vinod Govindapillai
Expose the display device info as a separate debugfs entry to list out display device info and remove the same from i915_capabilities Vinod Govindapillai (2): drm/i915/display: display device info debugfs entry drm/i915: remove display device info from i915 capabilities drivers/gpu/drm/i915

[Intel-gfx] [PATCH v1 3/3] drm/i915/xe2lpd: update the scaler feature capability

2023-10-01 Thread Vinod Govindapillai
Update the number of scalers per pipe based on the display capabilities reported. v1: define the field values instead of the magic number (JaniN) Bspec: 71161 Signed-off-by: Vinod Govindapillai --- drivers/gpu/drm/i915/display/intel_display_device.c | 7 +++ 1 file changed, 7 insertions

[Intel-gfx] [PATCH v1 0/3] scalable display feature configurations

2023-10-01 Thread Vinod Govindapillai
Get the reported device capabilities and update DSC and scaler feature support v1: use defined field values instead of magic numbers (Jani Nikula) Vinod Govindapillai (3): drm/i915/xe2lpd: display capability register definitions drm/i915/xe2lpd: update the dsc feature capability drm/i915

[Intel-gfx] [PATCH v1 2/3] drm/i915/xe2lpd: update the dsc feature capability

2023-10-01 Thread Vinod Govindapillai
Update the global dsc flag based on the display capabilities reported. v1: define the field values instead of the magic number (JaniN) Bspec: 71161 Signed-off-by: Vinod Govindapillai --- drivers/gpu/drm/i915/display/intel_display_device.c | 8 1 file changed, 8 insertions(+) diff

[Intel-gfx] [PATCH v1 1/3] drm/i915/xe2lpd: display capability register definitions

2023-10-01 Thread Vinod Govindapillai
Register definitions to track the reported scalable display feature configurations Bspec: 71161 Signed-off-by: Vinod Govindapillai --- drivers/gpu/drm/i915/i915_reg.h | 7 +++ 1 file changed, 7 insertions(+) diff --git a/drivers/gpu/drm/i915/i915_reg.h b/drivers/gpu/drm/i915/i915_reg.h

[Intel-gfx] [PATCH 3/3] drm/i915/xe2lpd: update the scaler feature capability

2023-09-27 Thread Vinod Govindapillai
Update the number of scalers per pipe based on the display capabilities reported. Bspec: 71161 Signed-off-by: Vinod Govindapillai --- drivers/gpu/drm/i915/display/intel_display_device.c | 6 ++ 1 file changed, 6 insertions(+) diff --git a/drivers/gpu/drm/i915/display/intel_display_device.c

[Intel-gfx] [PATCH 2/3] drm/i915/xe2lpd: update the dsc feature capability

2023-09-27 Thread Vinod Govindapillai
Update the global dsc flag based on the display capabilities reported. Bspec: 71161 Signed-off-by: Vinod Govindapillai --- drivers/gpu/drm/i915/display/intel_display_device.c | 7 +++ 1 file changed, 7 insertions(+) diff --git a/drivers/gpu/drm/i915/display/intel_display_device.c b

[Intel-gfx] [PATCH 1/3] drm/i915/xe2lpd: display capability register definitions

2023-09-27 Thread Vinod Govindapillai
Register definitions to track the reported scalable display feature configurations Bspec: 71161 Signed-off-by: Vinod Govindapillai --- drivers/gpu/drm/i915/i915_reg.h | 5 + 1 file changed, 5 insertions(+) diff --git a/drivers/gpu/drm/i915/i915_reg.h b/drivers/gpu/drm/i915/i915_reg.h index

[Intel-gfx] [PATCH 0/3] scalable display feature configurations

2023-09-27 Thread Vinod Govindapillai
Get the reported device capabilities and update DSC and scaler feature support Vinod Govindapillai (3): drm/i915/xe2lpd: display capability register definitions drm/i915/xe2lpd: update the dsc feature capability drm/i915/xe2lpd: update the scaler feature capability drivers/gpu/drm/i915

[Intel-gfx] [PATCH v5 2/2] drm/i915/lnl: update the supported plane formats with FBC

2023-09-22 Thread Vinod Govindapillai
FBC is supported with RGB32 8:8:8:8 with or without alpha Bspec: 68904, 69560 Signed-off-by: Vinod Govindapillai --- drivers/gpu/drm/i915/display/intel_fbc.c | 8 +++- 1 file changed, 7 insertions(+), 1 deletion(-) diff --git a/drivers/gpu/drm/i915/display/intel_fbc.c b/drivers/gpu/drm

[Intel-gfx] [PATCH v5 0/2] fbc on any planes

2023-09-22 Thread Vinod Govindapillai
FBC can be supported in first three planes in lnl Vinod Govindapillai (2): drm/i915/lnl: possibility to enable FBC on first three planes drm/i915/lnl: update the supported plane formats with FBC drivers/gpu/drm/i915/display/intel_fbc.c | 11 ++- drivers/gpu/drm/i915

[Intel-gfx] [PATCH v5 1/2] drm/i915/lnl: possibility to enable FBC on first three planes

2023-09-22 Thread Vinod Govindapillai
ess macro Bspec: 69560 Signed-off-by: Vinod Govindapillai --- drivers/gpu/drm/i915/display/intel_fbc.c | 3 +++ drivers/gpu/drm/i915/display/skl_universal_plane.c | 9 ++--- drivers/gpu/drm/i915/i915_reg.h| 2 ++ 3 files changed, 11 insertions(+), 3 deletions(-) d

[Intel-gfx] [PATCH v4 1/2] drm/i915/lnl: possibility to enable FBC on first three planes

2023-09-04 Thread Vinod Govindapillai
ess macro Bspec: 69560 Signed-off-by: Vinod Govindapillai --- drivers/gpu/drm/i915/display/intel_fbc.c | 3 +++ drivers/gpu/drm/i915/display/skl_universal_plane.c | 9 ++--- drivers/gpu/drm/i915/i915_reg.h| 2 ++ 3 files changed, 11 insertions(+), 3 deletions(-) d

[Intel-gfx] [PATCH v4 2/2] drm/i915/lnl: FBC is supported with per pixel alpha

2023-09-04 Thread Vinod Govindapillai
For LNL onwards, FBC can be supported on planes with per pixel alpha Bspec: 69560 Signed-off-by: Vinod Govindapillai --- drivers/gpu/drm/i915/display/intel_fbc.c | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/drivers/gpu/drm/i915/display/intel_fbc.c b/drivers/gpu/drm

[Intel-gfx] [PATCH v4 0/2] fbc on any planes

2023-09-04 Thread Vinod Govindapillai
FBC can be supported in first three planes in lnl Vinod Govindapillai (2): drm/i915/lnl: possibility to enable FBC on first three planes drm/i915/lnl: FBC is supported with per pixel alpha drivers/gpu/drm/i915/display/intel_fbc.c | 6 +- drivers/gpu/drm/i915/display

[Intel-gfx] [PATCH v3 2/2] drm/i915/lnl: FBC is supported with per pixel alpha

2023-09-01 Thread Vinod Govindapillai
For LNL onwards, FBC can be supported on planes with per pixel alpha Bspec: 69560 Signed-off-by: Vinod Govindapillai --- drivers/gpu/drm/i915/display/intel_fbc.c | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/drivers/gpu/drm/i915/display/intel_fbc.c b/drivers/gpu/drm

  1   2   3   4   >