Hi Nikula,
Could you help to review this patch?
Thanks,
Elaine
-Original Message-
From: Wang, Elaine
Sent: Friday, December 23, 2016 5:02 PM
To: intel-gfx@lists.freedesktop.org
Cc: Wang, Elaine ; Chris Wilson
; Joonas Lahtinen ;
Jani Nikula
Subject: [PATCH] drm/i915: Check num_pipes
From: Elaine Wang
when num_pipes is zero, it indicates display doesn't exist, so there
is no need to initialize display hooks. And to avoid calling these
uninitialized display hooks, respect num_pipes at the beginning of
intel_modeset_init_hw.
intel_init_pm() calls FBC init function and then ini
?id=98228)
[ 413.875957] [drm:drm_edid_block_valid] *ERROR* EDID checksum is invalid,
remainder is 63
Thanks,
Elaine
> -Original Message-
> From: Intel-gfx [mailto:intel-gfx-boun...@lists.freedesktop.org] On Behalf
> Of Patchwork
> Sent: Friday, December 23, 2016 2:54 PM
> To: Wang, Elain
From: Elaine Wang
Some platforms don't have display. To avoid accessing the
non-existent display interrupt registers, check whether num_pipes
isn't zero before invoking display IRQ install or reset function.
Cc: Chris Wilson
Cc: Joonas Lahtinen
Cc: Jani Nikula
Signed-off-by: Elaine Wang
---
> -Original Message-
> From: Jani Nikula [mailto:jani.nik...@linux.intel.com]
> Sent: Thursday, December 22, 2016 6:48 PM
> To: Wang, Elaine ; intel-gfx@lists.freedesktop.org;
> Wang, Elaine
> Cc: Chris Wilson ; Joonas Lahtinen
>
> Subject: Re: [PATCH v2 2/2] d
>
> On Thu, 22 Dec 2016, "Wang, Elaine" wrote:
> > Hi Jani, Ville,
> >
> > Any comment about the "PCH_NOP" vs "num_pipes == 0"?
> >
> > Thanks,
> > Elaine
> >> On Thu, 15 Dec 2016, Ville Syrjälä wrote:
> &g
Hi Chris/Lahtine/Jani,
Could you help to review this patch?
Thanks,
Elaine
-Original Message-
From: Wang, Elaine
Sent: Monday, December 19, 2016 6:19 PM
To: intel-gfx@lists.freedesktop.org; Wang, Elaine
Cc: Chris Wilson ; Joonas Lahtinen
; Jani Nikula
Subject: [PATCH v2 1/2] drm/i915
Hi Jani, Ville,
Any comment about the "PCH_NOP" vs "num_pipes == 0"?
Thanks,
Elaine
> On Thu, 15 Dec 2016, Ville Syrjälä wrote:
> > On Mon, Dec 12, 2016 at 02:57:44PM +0800, Wang Elaine wrote:
> >> From: Elaine Wang
> >>
> >> Some platfo
org]
> Sent: Monday, December 19, 2016 7:46 PM
> To: Wang, Elaine
> Cc: intel-gfx@lists.freedesktop.org
> Subject: ✗ Fi.CI.BAT: warning for series starting with [v2,1/2] drm/i915:
> Check
> num_pipes before initializing audio component
>
> == Series Details ==
>
> Seri
From: Elaine Wang
when num_pipes is zero, it indicates display doesn't exist, so there
is no need to initialize display hooks. And to avoid calling these
uninitialized display hooks, respect num_pipes at the beginning of
intel_modeset_init_hw and intel_init_clock_gating.
intel_init_pm() calls FB
From: Elaine Wang
when num_pipes is zero, it indicates there is no display and HDMI
audio doesn't exist.
v2: Move the check from caller to callee for consistency.
Cc: Chris Wilson
Cc: Joonas Lahtinen
Cc: Jani Nikula
Signed-off-by: Elaine Wang
---
drivers/gpu/drm/i915/intel_audio.c | 3 +++
>
> On Fri, 16 Dec 2016, Wang Elaine wrote:
> > From: Elaine Wang
> >
> > when num_pipes is zero, it indicates there is no display and HDMI
> > audio doesn't exist.
> >
> > Cc: Chris Wilson
> > Cc: Joonas Lahtinen
> > Signed-off-by
ug_printmodeline] Modeline 62:"640x480" 60
25175 640 656 752 800 480 490 492 525 0x40 0xa
[ 433.974931] [drm:drm_helper_probe_single_connector_modes]
[CONNECTOR:45:VGA-1]
> -Original Message-
> From: Patchwork [mailto:patchw...@emeril.freedesktop.org]
> Sent: Friday, Decemb
From: Elaine Wang
when num_pipes is zero, it indicates display doesn't exist, so there
is no need to initialize display hooks. And to avoid calling these
uninitialized display hooks, respect num_pipes at the beginning of
intel_modeset_init_hw and intel_init_clock_gating.
intel_init_pm() calls FB
From: Elaine Wang
when num_pipes is zero, it indicates there is no display and HDMI
audio doesn't exist.
Cc: Chris Wilson
Cc: Joonas Lahtinen
Signed-off-by: Elaine Wang
---
drivers/gpu/drm/i915/i915_drv.c | 3 ++-
1 file changed, 2 insertions(+), 1 deletion(-)
diff --git a/drivers/gpu/drm/i
> On Thu, 15 Dec 2016, Ville Syrjälä wrote:
> > On Mon, Dec 12, 2016 at 02:57:44PM +0800, Wang Elaine wrote:
> >> From: Elaine Wang
> >>
> >> Some platforms don't have display. To avoid accessing the
> >> non-existent registers, check HAS_PCH_NOP
70
[ 25.000375] [] i915_exit+0x1a/0x71 [i915]
[ 25.000378] [] SyS_delete_module+0x193/0x1e0
[ 25.000380] [] entry_SYSCALL_64_fastpath+0x1c/0xb1
Thanks,
Ealine
> -Original Message-
> From: Patchwork [mailto:patchw...@emeril.freedesktop.org]
> Sent: Monday, December 12, 2016 3:53 PM
+0x1a/0x71 [i915]
[ 25.000378] [] SyS_delete_module+0x193/0x1e0
[ 25.000380] [] entry_SYSCALL_64_fastpath+0x1c/0xb1
> -Original Message-
> From: Intel-gfx [mailto:intel-gfx-boun...@lists.freedesktop.org] On Behalf
> Of Patchwork
> Sent: Friday, December 9, 2016 6:53 PM
> To
From: Elaine Wang
Some platforms don't have display. To avoid accessing the
non-existent registers, check HAS_PCH_NOP before invoking
display IRQ install or reset function.
Cc: Chris Wilson
Cc: Joonas Lahtinen
Signed-off-by: Elaine Wang
---
drivers/gpu/drm/i915/i915_irq.c | 10 +++---
1
> On Fri, Dec 09, 2016 at 05:45:56PM +0200, Joonas Lahtinen wrote:
> > On pe, 2016-12-09 at 18:01 +0800, Wang Elaine wrote:
> > > From: Elaine Wang
> > >
> > > Some platforms don't have display. To avoid accessing the
> > > non-existent re
From: Elaine Wang
Some platforms don't have display. To avoid accessing the
non-existent registers, check whether num_pipes isn't zero
before invoking dispaly IRQ install or reset function.
Cc: Joonas Lahtinen
Signed-off-by: Elaine Wang
---
drivers/gpu/drm/i915/i915_irq.c | 10 +++---
1 f
> On Thu, Dec 08, 2016 at 06:46:49PM +0800, Wang Elaine wrote:
> > From: Elaine Wang
> >
> > Some platforms only have VCS ring in VDBox. To avoid accessing the
> > non-existent rings or display registers, check the ring_mask and
> > num_pipes in gen8 IRQ instal
From: Elaine Wang
Some platforms only have VCS ring in VDBox. To avoid accessing the
non-existent rings or display registers, check the ring_mask
and num_pipes in gen8 IRQ install and reset functions.
Cc: Joonas Lahtinen
Signed-off-by: Elaine Wang
---
drivers/gpu/drm/i915/i915_irq.c | 22
From: Elaine Wang
Some platforms don't have render or blitter. So no need to call
render domain or blitter domain forcewake init function.
Cc: Joonas Lahtinen
Signed-off-by: Elaine Wang
---
drivers/gpu/drm/i915/intel_uncore.c | 22 ++
1 file changed, 14 insertions(+), 8 de
24 matches
Mail list logo
