Re: [Intel-gfx] [PATCH v10 0/4] Separate panel orientation property creating and value setting

2022-06-01 Thread Hsin-Yi Wang
On Tue, May 31, 2022 at 6:56 PM Hans de Goede wrote: > > Hi, > > On 5/30/22 13:34, Hsin-Yi Wang wrote: > > On Mon, May 30, 2022 at 4:53 PM Hans de Goede wrote: > >> > >> Hi, > >> > >> On 5/30/22 10:19, Hsin-Yi Wang wrote: > >>&g

Re: [Intel-gfx] [PATCH v10 0/4] Separate panel orientation property creating and value setting

2022-05-30 Thread Hsin-Yi Wang
On Mon, May 30, 2022 at 4:53 PM Hans de Goede wrote: > > Hi, > > On 5/30/22 10:19, Hsin-Yi Wang wrote: > > Some drivers, eg. mtk_drm and msm_drm, rely on the panel to set the > > orientation. Panel calls drm_connector_set_panel_orientation() to create > > orientati

[Intel-gfx] [PATCH v10 4/4] arm64: dts: mt8183: Add panel rotation

2022-05-30 Thread Hsin-Yi Wang
krane, kakadu, and kodama boards have a default panel rotation. Signed-off-by: Hsin-Yi Wang Reviewed-by: Enric Balletbo i Serra Tested-by: Enric Balletbo i Serra --- arch/arm64/boot/dts/mediatek/mt8183-kukui.dtsi | 1 + 1 file changed, 1 insertion(+) diff --git a/arch/arm64/boot/dts/mediatek

[Intel-gfx] [PATCH v10 3/4] drm/msm: init panel orientation property

2022-05-30 Thread Hsin-Yi Wang
Init panel orientation property after connector is initialized. Let the panel driver decides the orientation value later. Signed-off-by: Hsin-Yi Wang --- drivers/gpu/drm/msm/dsi/dsi_manager.c | 4 1 file changed, 4 insertions(+) diff --git a/drivers/gpu/drm/msm/dsi/dsi_manager.c b

[Intel-gfx] [PATCH v10 2/4] drm/mediatek: init panel orientation property

2022-05-30 Thread Hsin-Yi Wang
Init panel orientation property after connector is initialized. Let the panel driver decides the orientation value later. Signed-off-by: Hsin-Yi Wang Acked-by: Chun-Kuang Hu --- drivers/gpu/drm/mediatek/mtk_dsi.c | 7 +++ 1 file changed, 7 insertions(+) diff --git a/drivers/gpu/drm

[Intel-gfx] [PATCH v10 1/4] gpu: drm: separate panel orientation property creating and value setting

2022-05-30 Thread Hsin-Yi Wang
/0x180 [4.909783] ---[ end trace b4f2db9d9c88610c ]--- Signed-off-by: Hsin-Yi Wang Reviewed-by: Sean Paul --- v9->v10: rebase to latest linux-next. v9: https://patchwork.kernel.org/project/linux-mediatek/patch/20220318074825.3359978-2-hsi...@chromium.org/ v8: https://patchwork.kernel.org/proj

[Intel-gfx] [PATCH v10 0/4] Separate panel orientation property creating and value setting

2022-05-30 Thread Hsin-Yi Wang
drm_connector_init_panel_orientation_property() earlier. Hsin-Yi Wang (4): gpu: drm: separate panel orientation property creating and value setting drm/mediatek: init panel orientation property drm/msm: init panel orientation property arm64: dts: mt8183: Add panel rotation .../arm64/boot

Re: [Intel-gfx] [PATCH v8 1/3] gpu: drm: separate panel orientation property creating and value setting

2022-03-18 Thread Hsin-Yi Wang
On Fri, Feb 18, 2022 at 11:57 PM Harry Wentland wrote: > > On 2022-02-18 07:12, Simon Ser wrote: > > On Friday, February 18th, 2022 at 12:54, Hans de Goede > > wrote: > > > >> On 2/18/22 12:39, Simon Ser wrote: > >>> On Friday, February 18th, 2022 at 11:38, Hans de Goede > >>> wrote: > >>> >

[Intel-gfx] [PATCH v9 4/4] arm64: dts: mt8183: Add panel rotation

2022-03-18 Thread Hsin-Yi Wang
krane, kakadu, and kodama boards have a default panel rotation. Signed-off-by: Hsin-Yi Wang Reviewed-by: Enric Balletbo i Serra Tested-by: Enric Balletbo i Serra --- arch/arm64/boot/dts/mediatek/mt8183-kukui.dtsi | 1 + 1 file changed, 1 insertion(+) diff --git a/arch/arm64/boot/dts/mediatek

[Intel-gfx] [PATCH v9 2/4] drm/mediatek: init panel orientation property

2022-03-18 Thread Hsin-Yi Wang
Init panel orientation property after connector is initialized. Let the panel driver decides the orientation value later. Signed-off-by: Hsin-Yi Wang Acked-by: Chun-Kuang Hu --- drivers/gpu/drm/mediatek/mtk_dsi.c | 7 +++ 1 file changed, 7 insertions(+) diff --git a/drivers/gpu/drm

[Intel-gfx] [PATCH v9 3/4] drm/msm: init panel orientation property

2022-03-18 Thread Hsin-Yi Wang
Init panel orientation property after connector is initialized. Let the panel driver decides the orientation value later. Signed-off-by: Hsin-Yi Wang --- drivers/gpu/drm/msm/dsi/dsi_manager.c | 4 1 file changed, 4 insertions(+) diff --git a/drivers/gpu/drm/msm/dsi/dsi_manager.c b

[Intel-gfx] [PATCH v9 1/4] gpu: drm: separate panel orientation property creating and value setting

2022-03-18 Thread Hsin-Yi Wang
/0x180 [4.909783] ---[ end trace b4f2db9d9c88610c ]--- Signed-off-by: Hsin-Yi Wang Reviewed-by: Sean Paul --- drivers/gpu/drm/drm_connector.c | 58 + include/drm/drm_connector.h | 2 ++ 2 files changed, 47 insertions(+), 13 deletions(-) diff --git a/drivers/g

[Intel-gfx] [PATCH v9 0/4] Separate panel orientation property creating and value setting

2022-03-18 Thread Hsin-Yi Wang
drm_connector_init_panel_orientation_property() earlier. Hsin-Yi Wang (4): gpu: drm: separate panel orientation property creating and value setting drm/mediatek: init panel orientation property drm/msm: init panel orientation property arm64: dts: mt8183: Add panel rotation .../arm64/boot/dts/mediatek/mt8183-kukui.dtsi | 1

Re: [Intel-gfx] [PATCH v8 1/3] gpu: drm: separate panel orientation property creating and value setting

2022-02-15 Thread Hsin-Yi Wang
On Tue, Feb 15, 2022 at 12:03 PM Gabriel Krisman Bertazi wrote: > > Hsin-Yi Wang writes: > > > On Tue, Feb 15, 2022 at 9:17 AM Gabriel Krisman Bertazi > > wrote: > >> > >> Hsin-Yi Wang writes: > >> > >> > drm_dev_register() sets conn

Re: [Intel-gfx] [PATCH v8 1/3] gpu: drm: separate panel orientation property creating and value setting

2022-02-15 Thread Hsin-Yi Wang
On Tue, Feb 15, 2022 at 8:04 PM Emil Velikov wrote: > > Greetings everyone, > > Padron for joining in so late o/ > > On Tue, 8 Feb 2022 at 08:42, Hsin-Yi Wang wrote: > > > > drm_dev_register() sets connector->registration_state to > > DRM_CONNECTOR

Re: [Intel-gfx] [PATCH v8 1/3] gpu: drm: separate panel orientation property creating and value setting

2022-02-14 Thread Hsin-Yi Wang
On Tue, Feb 15, 2022 at 9:17 AM Gabriel Krisman Bertazi wrote: > > Hsin-Yi Wang writes: > > > drm_dev_register() sets connector->registration_state to > > DRM_CONNECTOR_REGISTERED and dev->registered to true. If > > drm_connector_set_panel_orientation() is first

[Intel-gfx] [PATCH v8 3/3] arm64: dts: mt8183: Add panel rotation

2022-02-08 Thread Hsin-Yi Wang
krane, kakadu, and kodama boards have a default panel rotation. Signed-off-by: Hsin-Yi Wang Reviewed-by: Enric Balletbo i Serra Tested-by: Enric Balletbo i Serra --- arch/arm64/boot/dts/mediatek/mt8183-kukui.dtsi | 1 + 1 file changed, 1 insertion(+) diff --git a/arch/arm64/boot/dts/mediatek

[Intel-gfx] [PATCH v8 2/3] drm/mediatek: init panel orientation property

2022-02-08 Thread Hsin-Yi Wang
Init panel orientation property after connector is initialized. Let the panel driver decides the orientation value later. Signed-off-by: Hsin-Yi Wang Acked-by: Chun-Kuang Hu --- drivers/gpu/drm/mediatek/mtk_dsi.c | 7 +++ 1 file changed, 7 insertions(+) diff --git a/drivers/gpu/drm

[Intel-gfx] [PATCH v8 1/3] gpu: drm: separate panel orientation property creating and value setting

2022-02-08 Thread Hsin-Yi Wang
/0x180 [4.909783] ---[ end trace b4f2db9d9c88610c ]--- Signed-off-by: Hsin-Yi Wang Reviewed-by: Sean Paul --- v7->v8: - check if the prop is created to avoid leak issue when called multiple times. - attempt to create prop in drm_connector_set_panel_orientation if prop is not created b

Re: [Intel-gfx] [PATCH v7 1/3] gpu: drm: separate panel orientation property creating and value setting

2022-02-08 Thread Hsin-Yi Wang
On Tue, Feb 8, 2022 at 3:52 PM Ville Syrjälä wrote: > > On Tue, Feb 08, 2022 at 03:37:12PM +0800, Hsin-Yi Wang wrote: > > +int drm_connector_init_panel_orientation_property( > > + struct drm_connector *connector) > > +{ > > + struct drm_device *dev = co

[Intel-gfx] [PATCH v7 3/3] arm64: dts: mt8183: Add panel rotation

2022-02-07 Thread Hsin-Yi Wang
krane, kakadu, and kodama boards have a default panel rotation. Signed-off-by: Hsin-Yi Wang Reviewed-by: Enric Balletbo i Serra Tested-by: Enric Balletbo i Serra --- arch/arm64/boot/dts/mediatek/mt8183-kukui.dtsi | 1 + 1 file changed, 1 insertion(+) diff --git a/arch/arm64/boot/dts/mediatek

[Intel-gfx] [PATCH v7 2/3] drm/mediatek: init panel orientation property

2022-02-07 Thread Hsin-Yi Wang
Init panel orientation property after connector is initialized. Let the panel driver decides the orientation value later. Signed-off-by: Hsin-Yi Wang Acked-by: Chun-Kuang Hu --- drivers/gpu/drm/mediatek/mtk_dsi.c | 7 +++ 1 file changed, 7 insertions(+) diff --git a/drivers/gpu/drm

[Intel-gfx] [PATCH v7 1/3] gpu: drm: separate panel orientation property creating and value setting

2022-02-07 Thread Hsin-Yi Wang
/0x180 [4.909783] ---[ end trace b4f2db9d9c88610c ]--- Signed-off-by: Hsin-Yi Wang Reviewed-by: Sean Paul --- v6 -> v7: - Rebase to latest drm-misc. - Add function for amdgpu_dm. --- .../gpu/drm/amd/display/amdgpu_dm/amdgpu_dm.c | 1 + drivers/gpu/drm/drm_connector.c

[Intel-gfx] [PATCH v6 RESEND 3/3] arm64: dts: mt8183: Add panel rotation

2021-06-24 Thread Hsin-Yi Wang
krane, kakadu, and kodama boards have a default panel rotation. Signed-off-by: Hsin-Yi Wang --- arch/arm64/boot/dts/mediatek/mt8183-kukui.dtsi | 1 + 1 file changed, 1 insertion(+) diff --git a/arch/arm64/boot/dts/mediatek/mt8183-kukui.dtsi b/arch/arm64/boot/dts/mediatek/mt8183-kukui.dtsi

[Intel-gfx] [PATCH v6 RESEND 2/3] drm/mediatek: init panel orientation property

2021-06-24 Thread Hsin-Yi Wang
Init panel orientation property after connector is initialized. Let the panel driver decides the orientation value later. Signed-off-by: Hsin-Yi Wang Acked-by: Chun-Kuang Hu --- drivers/gpu/drm/mediatek/mtk_dsi.c | 7 +++ 1 file changed, 7 insertions(+) diff --git a/drivers/gpu/drm

[Intel-gfx] [PATCH v6 RESEND 1/3] gpu: drm: separate panel orientation property creating and value setting

2021-06-24 Thread Hsin-Yi Wang
/0x180 [4.909783] ---[ end trace b4f2db9d9c88610c ]--- Signed-off-by: Hsin-Yi Wang Reviewed-by: Sean Paul --- drivers/gpu/drm/drm_connector.c | 58 ++--- drivers/gpu/drm/i915/display/icl_dsi.c | 1 + drivers/gpu/drm/i915/display/intel_dp.c | 1 + drivers/gpu/dr

Re: [Intel-gfx] [PATCH v6 RESEND 1/3] gpu: drm: separate panel orientation property creating and value setting

2021-06-15 Thread Hsin-Yi Wang
On Thu, May 27, 2021 at 3:42 PM Hsin-Yi Wang wrote: > > drm_dev_register() sets connector->registration_state to > DRM_CONNECTOR_REGISTERED and dev->registered to true. If > drm_connector_set_panel_orientation() is first called after > drm_dev_register(), it will fail sever

Re: [Intel-gfx] linux-next: build failure after merge of the i2c tree

2021-06-01 Thread Hsin-Yi Wang
On Tue, Jun 1, 2021 at 4:55 PM Wolfram Sang wrote: > > Hi Stephen, > > > After merging the i2c tree, today's linux-next build (x86_64 allmodconfig) > > failed like this: > > > > In file included from drivers/gpu/drm/i915/i915_gem.c:1250: > > drivers/gpu/drm/i915/selftests/i915_gem.c:97:13: error:

[Intel-gfx] [PATCH v6 RESEND 3/3] arm64: dts: mt8183: Add panel rotation

2021-05-27 Thread Hsin-Yi Wang
krane, kakadu, and kodama boards have a default panel rotation. Signed-off-by: Hsin-Yi Wang --- arch/arm64/boot/dts/mediatek/mt8183-kukui.dtsi | 1 + 1 file changed, 1 insertion(+) diff --git a/arch/arm64/boot/dts/mediatek/mt8183-kukui.dtsi b/arch/arm64/boot/dts/mediatek/mt8183-kukui.dtsi

[Intel-gfx] [PATCH v6 RESEND 2/3] drm/mediatek: init panel orientation property

2021-05-27 Thread Hsin-Yi Wang
Init panel orientation property after connector is initialized. Let the panel driver decides the orientation value later. Signed-off-by: Hsin-Yi Wang Acked-by: Chun-Kuang Hu --- drivers/gpu/drm/mediatek/mtk_dsi.c | 7 +++ 1 file changed, 7 insertions(+) diff --git a/drivers/gpu/drm

[Intel-gfx] [PATCH v6 RESEND 1/3] gpu: drm: separate panel orientation property creating and value setting

2021-05-27 Thread Hsin-Yi Wang
/0x180 [4.909783] ---[ end trace b4f2db9d9c88610c ]--- Signed-off-by: Hsin-Yi Wang Reviewed-by: Sean Paul --- drivers/gpu/drm/drm_connector.c | 58 ++--- drivers/gpu/drm/i915/display/icl_dsi.c | 1 + drivers/gpu/drm/i915/display/intel_dp.c | 1 + drivers/gpu/dr

Re: [Intel-gfx] [PATCH v19 4/6] misc: eeprom: at24: check suspend status before disable regulator

2021-04-20 Thread Hsin-Yi Wang
On Fri, Apr 16, 2021 at 10:09 PM Bartosz Golaszewski wrote: > > On Wed, Apr 14, 2021 at 7:29 PM Hsin-Yi Wang wrote: > > > > cd5676db0574 ("misc: eeprom: at24: support pm_runtime control") disables > > regulator in runtime suspend. If runtime suspend is c

Re: [Intel-gfx] [PATCH v19 6/6] drm/i915/selftests: Rename functions names

2021-04-16 Thread Hsin-Yi Wang
On Fri, Apr 16, 2021 at 10:23 PM Jani Nikula wrote: > > On Thu, 15 Apr 2021, Hsin-Yi Wang wrote: > > pm_resume and pm_suspend might be conflict with the ones defined in > > include/linux/suspend.h. Rename pm_resume{suspend} to > > i915_pm_resume{suspend} since they a

[Intel-gfx] [PATCH v19 6/6] drm/i915/selftests: Rename functions names

2021-04-14 Thread Hsin-Yi Wang
pm_resume and pm_suspend might be conflict with the ones defined in include/linux/suspend.h. Rename pm_resume{suspend} to i915_pm_resume{suspend} since they are only used here. Signed-off-by: Hsin-Yi Wang Reported-by: kernel test robot --- drivers/gpu/drm/i915/selftests/i915_gem.c | 10

[Intel-gfx] [PATCH v19 5/6] arm64: dts: mt8183: add supply name for eeprom

2021-04-14 Thread Hsin-Yi Wang
Add supplies for eeprom for mt8183 boards. Signed-off-by: Hsin-Yi Wang --- arch/arm64/boot/dts/mediatek/mt8183-kukui-kakadu.dtsi | 4 arch/arm64/boot/dts/mediatek/mt8183-kukui-kodama.dtsi | 4 arch/arm64/boot/dts/mediatek/mt8183-kukui-krane.dtsi | 4 3 files changed, 12

[Intel-gfx] [PATCH v19 4/6] misc: eeprom: at24: check suspend status before disable regulator

2021-04-14 Thread Hsin-Yi Wang
cd5676db0574 ("misc: eeprom: at24: support pm_runtime control") disables regulator in runtime suspend. If runtime suspend is called before regulator disable, it will results in regulator unbalanced disabling. Signed-off-by: Hsin-Yi Wang --- drivers/misc/eeprom/at24.c | 6 -- 1 fi

[Intel-gfx] [PATCH v19 3/6] i2c: mediatek: mt65xx: add optional vbus-supply

2021-04-14 Thread Hsin-Yi Wang
Add vbus-supply which provides power to SCL/SDA. Pass this regulator into core so it can be turned on/off for low power mode support. Signed-off-by: Hsin-Yi Wang --- drivers/i2c/busses/i2c-mt65xx.c | 7 +++ 1 file changed, 7 insertions(+) diff --git a/drivers/i2c/busses/i2c-mt65xx.c b

[Intel-gfx] [PATCH v19 2/6] dt-binding: i2c: mt65xx: add vbus-supply property

2021-04-14 Thread Hsin-Yi Wang
Add vbus-supply property for mt65xx. The regulator can be passed into core and turned off during suspend/sleep to reduce power consumption. Signed-off-by: Hsin-Yi Wang --- Documentation/devicetree/bindings/i2c/i2c-mt65xx.txt | 1 + 1 file changed, 1 insertion(+) diff --git a/Documentation

[Intel-gfx] [PATCH v19 1/6] i2c: core: support bus regulator controlling in adapter

2021-04-14 Thread Hsin-Yi Wang
Signed-off-by: Hsin-Yi Wang --- drivers/i2c/i2c-core-base.c | 88 + include/linux/i2c.h | 2 + 2 files changed, 90 insertions(+) diff --git a/drivers/i2c/i2c-core-base.c b/drivers/i2c/i2c-core-base.c index 24c8f11bac73..c34920f30c5a 100644

[Intel-gfx] [PATCH v19 0/6] add power control in i2c

2021-04-14 Thread Hsin-Yi Wang
since v8: - fixup some wrong code - remove redundant message [... snip ...] Bibby Hsieh (1): i2c: core: support bus regulator controlling in adapter Hsin-Yi Wang (5): dt-binding: i2c: mt65xx: add vbus-supply property i2c: mediatek: mt65xx: add optional vbus-supply misc: eeprom

[Intel-gfx] [PATCH v2] drm/i915/gvt: fix memory leak in intel_vgpu_ioctl()

2018-08-08 Thread Yi Wang
The 'sparse' variable may leak when return in function intel_vgpu_ioctl(), and this patch fix this. Signed-off-by: Yi Wang Reviewed-by: Jiang Biao --- v2: fix a double-free error. Thanks to Zhenyu Wang. drivers/gpu/drm/i915/gvt/kvmgt.c | 8 ++-- 1 file changed, 6 insertions(+), 2

[Intel-gfx] [PATCH] drm/i915/gvt: fix memory leak in intel_vgpu_ioctl()

2018-08-03 Thread Yi Wang
The 'sparse' variable may leak when return in function intel_vgpu_ioctl(), and this patch fixes this. Signed-off-by: Yi Wang Reviewed-by: Jiang Biao --- drivers/gpu/drm/i915/gvt/kvmgt.c | 3 +++ 1 file changed, 3 insertions(+) diff --git a/drivers/gpu/drm/i915/gvt/kvmgt.c b/drivers/gpu/drm