Re: [Intel-gfx] [PATCH v8 1/4] drm/panel: Add helper for reading DT rotation

On Mon, Oct 7, 2019 at 9:38 AM Sean Paul wrote: > > On Wed, Sep 25, 2019 at 03:58:30PM -0700, Derek Basehore wrote: > > This adds a helper function for reading the rotation (panel > > orientation) from the device tree. > > > > Signed-off-by: Derek Basehore > > Reviewed-by: Sam Ravnborg > > The p

Re: [Intel-gfx] [v8, 2/4] drm/panel: set display info in panel attach

On Mon, Oct 7, 2019 at 9:44 AM Sean Paul wrote: > > On Mon, Sep 30, 2019 at 04:14:54PM -0700, dbasehore . wrote: > > On Sat, Sep 28, 2019 at 10:23 PM james qian wang (Arm Technology > > China) wrote: > > > > > > On Wed, Sep 25, 2019 at 03:58:31PM -0700, Dere

Re: [Intel-gfx] [v8, 2/4] drm/panel: set display info in panel attach

On Sat, Sep 28, 2019 at 10:23 PM james qian wang (Arm Technology China) wrote: > > On Wed, Sep 25, 2019 at 03:58:31PM -0700, Derek Basehore wrote: > > Devicetree systems can set panel orientation via a panel binding, but > > there's no way, as is, to propagate this setting to the connector, > > wh

Re: [Intel-gfx] [PATCH v7 2/4] drm/panel: set display info in panel attach

Hi Sam, thanks for pointing out the potential conflict. On Tue, Jul 23, 2019 at 2:19 AM Sam Ravnborg wrote: > > Hi Derek. > > On Tue, Jul 09, 2019 at 07:16:57PM -0700, Derek Basehore wrote: > > Devicetree systems can set panel orientation via a panel binding, but > > there's no way, as is, to pro

Re: [Intel-gfx] [PATCH v3 3/4] drm/connector: Split out orientation quirk detection

On Mon, Jun 24, 2019 at 6:24 AM Ville Syrjälä wrote: > > On Fri, Jun 21, 2019 at 08:41:04PM -0700, Derek Basehore wrote: > > Not every platform needs quirk detection for panel orientation, so > > split the drm_connector_init_panel_orientation_property into two > > functions. One for platforms with

Re: [Intel-gfx] [PATCH v3 1/4] drm/panel: Add helper for reading DT rotation

On Mon, Jun 24, 2019 at 1:36 PM Sam Ravnborg wrote: > > Hi Derek. > > On Fri, Jun 21, 2019 at 08:41:02PM -0700, Derek Basehore wrote: > > This adds a helper function for reading the rotation (panel > > orientation) from the device tree. > > > > Signed-off-by: Derek Basehore > > --- > > drivers/g

Re: [Intel-gfx] [PATCH v3 2/4] drm/panel: set display info in panel attach

On Fri, Jun 21, 2019 at 8:41 PM Derek Basehore wrote: > > Devicetree systems can set panel orientation via a panel binding, but > there's no way, as is, to propagate this setting to the connector, > where the property need to be added. > To address this, this patch sets orientation, as well as oth

Re: [Intel-gfx] [PATCH 3/5] drm/panel: Add attach/detach callbacks

On Fri, Jun 21, 2019 at 2:19 AM Thierry Reding wrote: > > On Tue, Jun 11, 2019 at 05:25:47PM -0700, dbasehore . wrote: > > On Tue, Jun 11, 2019 at 1:57 AM Daniel Vetter wrote: > > > > > > On Mon, Jun 10, 2019 at 09:03:48PM -0700, Derek Basehore wrote: >

Re: [Intel-gfx] [PATCH 3/5] drm/panel: Add attach/detach callbacks

If we want to query the device tree outside of the panel code in helper functions, we can do this with the struct as is. There's already a device struct pointer in drm_panel, so I think we can pull from that. On Tue, Jun 11, 2019 at 5:25 PM dbasehore . wrote: > > On Tue, Jun 11, 2019

Re: [Intel-gfx] [PATCH 1/5] drm/panel: Add helper for reading DT rotation

On Fri, Jun 14, 2019 at 5:43 PM dbasehore . wrote: > > On Wed, Jun 12, 2019 at 2:18 PM Sam Ravnborg wrote: > > > > Hi Derek. > > > > On Mon, Jun 10, 2019 at 09:03:46PM -0700, Derek Basehore wrote: > > > This adds a helper function for reading the rota

Re: [Intel-gfx] [PATCH 1/5] drm/panel: Add helper for reading DT rotation

On Wed, Jun 12, 2019 at 2:18 PM Sam Ravnborg wrote: > > Hi Derek. > > On Mon, Jun 10, 2019 at 09:03:46PM -0700, Derek Basehore wrote: > > This adds a helper function for reading the rotation (panel > > orientation) from the device tree. > > > > Signed-off-by: Derek Basehore > > --- > > drivers/g

Re: [Intel-gfx] [PATCH 4/5] drm/connector: Split out orientation quirk detection

On Wed, Jun 12, 2019 at 5:33 AM Hans de Goede wrote: > > Hi, > > On 12-06-19 02:16, dbasehore . wrote: > > On Tue, Jun 11, 2019 at 1:54 AM Hans de Goede wrote: > >> > >> Hi, > >> > >> On 11-06-19 10:08, Jani Nikula wrote: > >>> O

Re: [Intel-gfx] [PATCH 1/5] drm/panel: Add helper for reading DT rotation

On Wed, Jun 12, 2019 at 2:20 PM Sam Ravnborg wrote: > > Hi Derek. > > On Mon, Jun 10, 2019 at 09:03:46PM -0700, Derek Basehore wrote: > > This adds a helper function for reading the rotation (panel > > orientation) from the device tree. > > > > Signed-off-by: Derek Basehore > > --- > > drivers/g

Re: [Intel-gfx] [PATCH 2/5] dt-bindings: display/panel: Expand rotation documentation

On Thu, Jun 13, 2019 at 5:52 AM Rob Herring wrote: > > On Tue, Jun 11, 2019 at 4:02 PM dbasehore . wrote: > > > > On Tue, Jun 11, 2019 at 8:25 AM Rob Herring wrote: > > > > > > On Mon, Jun 10, 2019 at 10:03 PM Derek Basehore > > > wrote: > >

Re: [Intel-gfx] [PATCH 3/5] drm/panel: Add attach/detach callbacks

On Tue, Jun 11, 2019 at 1:57 AM Daniel Vetter wrote: > > On Mon, Jun 10, 2019 at 09:03:48PM -0700, Derek Basehore wrote: > > This adds the attach/detach callbacks. These are for setting up > > internal state for the connector/panel pair that can't be done at > > probe (since the connector doesn't

Re: [Intel-gfx] [PATCH 4/5] drm/connector: Split out orientation quirk detection

On Tue, Jun 11, 2019 at 1:54 AM Hans de Goede wrote: > > Hi, > > On 11-06-19 10:08, Jani Nikula wrote: > > On Mon, 10 Jun 2019, Derek Basehore wrote: > >> This removes the orientation quirk detection from the code to add > >> an orientation property to a panel. This is used only for legacy x86 >

Re: [Intel-gfx] [PATCH 2/5] dt-bindings: display/panel: Expand rotation documentation

On Tue, Jun 11, 2019 at 8:25 AM Rob Herring wrote: > > On Mon, Jun 10, 2019 at 10:03 PM Derek Basehore > wrote: > > > > This adds to the rotation documentation to explain how drivers should > > use the property and gives an example of the property in a devicetree > > node. > > > > Signed-off-by: