Re: [Intel-gfx] [CI] drm/i915/gt: Refactor hangcheck selftest to use igt_spinner

2023-08-22 Thread John Harrison
On 8/19/2023 15:50, Andi Shyti wrote: From: Jonathan Cavitt The hangcheck live selftest contains duplicate declarations of some functions that already exist in igt_spinner.c, such as the creation and deconstruction of a spinning batch buffer (spinner) that hangs an engine. It's undesireable to

Re: [Intel-gfx] [CI] drm/i915/gt: Refactor hangcheck selftest to use igt_spinner

2023-08-22 Thread Andi Shyti
Hi Jonathan, > > The hangcheck live selftest contains duplicate declarations of some > > functions that already exist in igt_spinner.c, such as the creation and > > deconstruction of a spinning batch buffer (spinner) that hangs an engine. > > It's undesireable to have such code duplicated, as the

Re: [Intel-gfx] [CI] drm/i915/gt: Refactor hangcheck selftest to use igt_spinner

2023-08-21 Thread Cavitt, Jonathan
-Original Message- From: Andi Shyti Sent: Saturday, August 19, 2023 3:50 PM To: Cavitt, Jonathan Cc: intel-gfx Subject: [CI] drm/i915/gt: Refactor hangcheck selftest to use igt_spinner > > From: Jonathan Cavitt > > The hangcheck live selftest contains duplicate declarations of some >

[Intel-gfx] [CI] drm/i915/gt: Refactor hangcheck selftest to use igt_spinner

2023-08-19 Thread Andi Shyti
From: Jonathan Cavitt The hangcheck live selftest contains duplicate declarations of some functions that already exist in igt_spinner.c, such as the creation and deconstruction of a spinning batch buffer (spinner) that hangs an engine. It's undesireable to have such code duplicated, as the requir

[Intel-gfx] [CI] drm/i915/gt: Refactor hangcheck selftest to use igt_spinner

2023-08-18 Thread Andi Shyti
From: Jonathan Cavitt The hangcheck live selftest contains duplicate declarations of some functions that already exist in igt_spinner.c, such as the creation and deconstruction of a spinning batch buffer (spinner) that hangs an engine. It's undesireable to have such code duplicated, as the requir