Re: [Intel-gfx] [Intel-xe] [PATCH 3/4] drm/i915/lnl: support FBC on any plane

2023-08-29 Thread Ville Syrjälä
On Tue, Aug 29, 2023 at 09:04:28AM -0700, Matt Roper wrote: > On Tue, Aug 29, 2023 at 06:50:02AM -0700, Govindapillai, Vinod wrote: > > On Mon, 2023-08-28 at 17:16 -0700, Matt Roper wrote: > > > On Mon, Aug 28, 2023 at 09:20:34AM +0300, Vinod Govindapillai wrote: > > > > In LNL onwards, FBC can be

Re: [Intel-gfx] [Intel-xe] [PATCH 3/4] drm/i915/lnl: support FBC on any plane

2023-08-29 Thread Ville Syrjälä
On Tue, Aug 29, 2023 at 01:34:56PM +, Govindapillai, Vinod wrote: > On Tue, 2023-08-29 at 10:50 +0300, Ville Syrjälä wrote: > > On Mon, Aug 28, 2023 at 09:20:34AM +0300, Vinod Govindapillai wrote: > > > In LNL onwards, FBC can be associated to the first three planes. > > > The FBC will be enabl

Re: [Intel-gfx] [Intel-xe] [PATCH 3/4] drm/i915/lnl: support FBC on any plane

2023-08-29 Thread Matt Roper
On Tue, Aug 29, 2023 at 06:50:02AM -0700, Govindapillai, Vinod wrote: > On Mon, 2023-08-28 at 17:16 -0700, Matt Roper wrote: > > On Mon, Aug 28, 2023 at 09:20:34AM +0300, Vinod Govindapillai wrote: > > > In LNL onwards, FBC can be associated to the first three planes. > > > > The title of this pat

Re: [Intel-gfx] [Intel-xe] [PATCH 3/4] drm/i915/lnl: support FBC on any plane

2023-08-29 Thread Govindapillai, Vinod
On Mon, 2023-08-28 at 17:16 -0700, Matt Roper wrote: > On Mon, Aug 28, 2023 at 09:20:34AM +0300, Vinod Govindapillai wrote: > > In LNL onwards, FBC can be associated to the first three planes. > > The title of this patch shouldn't say "any plane" when the reality is > that only the first three sup

Re: [Intel-gfx] [Intel-xe] [PATCH 3/4] drm/i915/lnl: support FBC on any plane

2023-08-29 Thread Govindapillai, Vinod
On Tue, 2023-08-29 at 10:50 +0300, Ville Syrjälä wrote: > On Mon, Aug 28, 2023 at 09:20:34AM +0300, Vinod Govindapillai wrote: > > In LNL onwards, FBC can be associated to the first three planes. > > The FBC will be enabled for first FBC capable visible plane > > until the userspace can select one

Re: [Intel-gfx] [Intel-xe] [PATCH 3/4] drm/i915/lnl: support FBC on any plane

2023-08-29 Thread Ville Syrjälä
On Mon, Aug 28, 2023 at 09:20:34AM +0300, Vinod Govindapillai wrote: > In LNL onwards, FBC can be associated to the first three planes. > The FBC will be enabled for first FBC capable visible plane > until the userspace can select one of these FBC capable plane > explicitly > > Bspec: 69560 > Sign

Re: [Intel-gfx] [Intel-xe] [PATCH 3/4] drm/i915/lnl: support FBC on any plane

2023-08-28 Thread Matt Roper
On Mon, Aug 28, 2023 at 09:20:34AM +0300, Vinod Govindapillai wrote: > In LNL onwards, FBC can be associated to the first three planes. The title of this patch shouldn't say "any plane" when the reality is that only the first three support FBC (the upper two do not). > The FBC will be enabled for

Re: [Intel-gfx] [Intel-xe] [PATCH 3/4] drm/i915/lnl: support FBC on any plane

2023-08-28 Thread Govindapillai, Vinod
On Mon, 2023-08-28 at 12:00 +0300, Jani Nikula wrote: > On Mon, 28 Aug 2023, Vinod Govindapillai > wrote: > > diff --git a/drivers/gpu/drm/i915/i915_reg.h > > b/drivers/gpu/drm/i915/i915_reg.h > > index aefad14ab27a..b207774f3c33 100644 > > --- a/drivers/gpu/drm/i915/i915_reg.h > > +++ b/drivers

Re: [Intel-gfx] [Intel-xe] [PATCH 3/4] drm/i915/lnl: support FBC on any plane

2023-08-28 Thread Jani Nikula
On Mon, 28 Aug 2023, Vinod Govindapillai wrote: > diff --git a/drivers/gpu/drm/i915/i915_reg.h b/drivers/gpu/drm/i915/i915_reg.h > index aefad14ab27a..b207774f3c33 100644 > --- a/drivers/gpu/drm/i915/i915_reg.h > +++ b/drivers/gpu/drm/i915/i915_reg.h > @@ -1327,6 +1327,10 @@ > #define DPFC_CTL_