Re: [Intel-gfx] [PATCH][V2] drm/i915/guc: fix GEM_BUG_ON check

2018-06-12 Thread Jani Nikula
On Tue, 12 Jun 2018, Dan Carpenter wrote: > On Mon, Jun 11, 2018 at 05:46:53PM +0100, Colin King wrote: >> From: Colin Ian King >> >> The check for level being less than zero always false because flags >> is currently unsigned and can never be negative. Fix this by making >> flags a s32. >> >>

Re: [Intel-gfx] [PATCH][V2] drm/i915/guc: fix GEM_BUG_ON check

2018-06-12 Thread Dan Carpenter
On Mon, Jun 11, 2018 at 05:46:53PM +0100, Colin King wrote: > From: Colin Ian King > > The check for level being less than zero always false because flags > is currently unsigned and can never be negative. Fix this by making > flags a s32. > > Detected by CoverityScan, CID#1468363 ("Macro compar

[Intel-gfx] [PATCH][V2] drm/i915/guc: fix GEM_BUG_ON check

2018-06-11 Thread Colin King
From: Colin Ian King The check for level being less than zero always false because flags is currently unsigned and can never be negative. Fix this by making flags a s32. Detected by CoverityScan, CID#1468363 ("Macro compares unsigned to 0") Signed-off-by: Colin Ian King --- V2: Make flags s32