Re: [Intel-gfx] [PATCH] [v2] intel_frequency: A tool to manipulate Intel GPU frequency

2015-01-15 Thread Dave Gordon
On 15/01/15 14:00, Dave Gordon wrote: [snip] Finally, I think the choice of command names (especially --set vs --custom) is confusing. I'd like to propose the following: # Reading: --get # get all --get namelist # get specified -g [namelist] # synonym for -g

Re: [Intel-gfx] [PATCH] [v2] intel_frequency: A tool to manipulate Intel GPU frequency

2015-01-15 Thread Ben Widawsky
On Thu, Jan 15, 2015 at 02:00:06PM +, Dave Gordon wrote: On 12/01/15 03:35, Ben Widawsky wrote: WARNING: very minimally tested In general you should not need this tool. It's primary purpose is for benchmarking, and for debugging performance issues. For many kernel releases now

Re: [Intel-gfx] [PATCH] [v2] intel_frequency: A tool to manipulate Intel GPU frequency

2015-01-15 Thread Dave Gordon
On 12/01/15 03:35, Ben Widawsky wrote: WARNING: very minimally tested In general you should not need this tool. It's primary purpose is for benchmarking, and for debugging performance issues. For many kernel releases now sysfs has supported reading and writing the GPU frequency.

Re: [Intel-gfx] [PATCH] [v2] intel_frequency: A tool to manipulate Intel GPU frequency

2015-01-14 Thread Ben Widawsky
-gfx] [PATCH] [v2] intel_frequency: A tool to manipulate Intel GPU frequency On Sun, Jan 11, 2015 at 07:35:21PM -0800, Ben Widawsky wrote: WARNING: very minimally tested In general you should not need this tool. It's primary purpose is for benchmarking

Re: [Intel-gfx] [PATCH] [v2] intel_frequency: A tool to manipulate Intel GPU frequency

2015-01-14 Thread O'Rourke, Tom
On Tue, Jan 13, 2015 at 02:36:56PM -0800, Ben Widawsky wrote: On Tue, Jan 13, 2015 at 09:19:04PM +, O'Rourke, Tom wrote: Sent: Sunday, January 11, 2015 7:48 PM To: Widawsky, Benjamin Cc: Intel GFX Subject: Re: [Intel-gfx] [PATCH] [v2] intel_frequency: A tool to manipulate Intel

Re: [Intel-gfx] [PATCH] [v2] intel_frequency: A tool to manipulate Intel GPU frequency

2015-01-13 Thread Ben Widawsky
On Tue, Jan 13, 2015 at 09:19:04PM +, O'Rourke, Tom wrote: Sent: Sunday, January 11, 2015 7:48 PM To: Widawsky, Benjamin Cc: Intel GFX Subject: Re: [Intel-gfx] [PATCH] [v2] intel_frequency: A tool to manipulate Intel GPU frequency On Sun, Jan 11, 2015 at 07:35:21PM -0800, Ben

Re: [Intel-gfx] [PATCH] [v2] intel_frequency: A tool to manipulate Intel GPU frequency

2015-01-13 Thread O'Rourke, Tom
Sent: Sunday, January 11, 2015 7:48 PM To: Widawsky, Benjamin Cc: Intel GFX Subject: Re: [Intel-gfx] [PATCH] [v2] intel_frequency: A tool to manipulate Intel GPU frequency On Sun, Jan 11, 2015 at 07:35:21PM -0800, Ben Widawsky wrote: WARNING: very minimally tested In general you should

Re: [Intel-gfx] [PATCH] [v2] intel_frequency: A tool to manipulate Intel GPU frequency

2015-01-11 Thread Ben Widawsky
On Sun, Jan 11, 2015 at 07:35:21PM -0800, Ben Widawsky wrote: WARNING: very minimally tested In general you should not need this tool. It's primary purpose is for benchmarking, and for debugging performance issues. I noticed the it's vs its on v1, but forgot to fix it. IT'S fixed locally

[Intel-gfx] [PATCH] [v2] intel_frequency: A tool to manipulate Intel GPU frequency

2015-01-11 Thread Ben Widawsky
WARNING: very minimally tested In general you should not need this tool. It's primary purpose is for benchmarking, and for debugging performance issues. For many kernel releases now sysfs has supported reading and writing the GPU frequency. Therefore, this tool provides no new functionality.