Re: [Intel-gfx] [PATCH] [v3] drm/i915/bdw: Reorganize PPGTT init

2014-02-19 Thread Ben Widawsky
On Wed, Feb 19, 2014 at 11:00:17PM +0200, Imre Deak wrote: > On Wed, 2014-02-19 at 12:06 -0800, Ben Widawsky wrote: > > Create 3 clear stages in PPGTT init. This will help with upcoming > > changes be more readable. The 3 stages are, allocation, dma mapping, and > > writing the P[DT]Es > > > > One

Re: [Intel-gfx] [PATCH] [v3] drm/i915/bdw: Reorganize PPGTT init

2014-02-19 Thread Imre Deak
On Wed, 2014-02-19 at 12:06 -0800, Ben Widawsky wrote: > Create 3 clear stages in PPGTT init. This will help with upcoming > changes be more readable. The 3 stages are, allocation, dma mapping, and > writing the P[DT]Es > > One nice benefit to the patches is that it makes 2 very clear error > poin

[Intel-gfx] [PATCH] [v3] drm/i915/bdw: Reorganize PPGTT init

2014-02-19 Thread Ben Widawsky
Create 3 clear stages in PPGTT init. This will help with upcoming changes be more readable. The 3 stages are, allocation, dma mapping, and writing the P[DT]Es One nice benefit to the patches is that it makes 2 very clear error points, allocation, and mapping, and avoids having to do any handling a