Re: [Intel-gfx] [PATCH] Revert "drm/shmem-helper: Switch to reservation lock"

2023-02-28 Thread Saarinen, Jani
.freedesktop.org; dri-de...@lists.freedesktop.org > Subject: Re: [Intel-gfx] [PATCH] Revert "drm/shmem-helper: Switch to > reservation lock" > > Hi > > Am 28.02.23 um 16:28 schrieb Dmitry Osipenko: > > On 2/28/23 18:26, Thomas Zimmermann wrote: > >> This reverts com

Re: [Intel-gfx] [PATCH] Revert "drm/shmem-helper: Switch to reservation lock"

2023-02-28 Thread Thomas Zimmermann
Hi Am 28.02.23 um 16:28 schrieb Dmitry Osipenko: On 2/28/23 18:26, Thomas Zimmermann wrote: This reverts commit 67b7836d4458790f1261e31fe0ce3250989784f0. The locking appears incomplete. A caller of SHMEM helper's pin function never acquires the dma-buf reservation lock. So we get WARNING:

Re: [Intel-gfx] [PATCH] Revert "drm/shmem-helper: Switch to reservation lock"

2023-02-28 Thread Dmitry Osipenko
On 2/28/23 18:26, Thomas Zimmermann wrote: > This reverts commit 67b7836d4458790f1261e31fe0ce3250989784f0. > > The locking appears incomplete. A caller of SHMEM helper's pin > function never acquires the dma-buf reservation lock. So we get > > WARNING: CPU: 3 PID: 967 at drivers/gpu/drm/drm_gem

[Intel-gfx] [PATCH] Revert "drm/shmem-helper: Switch to reservation lock"

2023-02-28 Thread Thomas Zimmermann
This reverts commit 67b7836d4458790f1261e31fe0ce3250989784f0. The locking appears incomplete. A caller of SHMEM helper's pin function never acquires the dma-buf reservation lock. So we get WARNING: CPU: 3 PID: 967 at drivers/gpu/drm/drm_gem_shmem_helper.c:243 drm_gem_shmem_pin+0x42/0x90 [drm_s