Re: [Intel-gfx] [PATCH] drm/damage_helper: Fix handling of cursor dirty buffers

2021-08-19 Thread Daniel Vetter
On Wed, Aug 18, 2021 at 04:44:44PM +, Souza, Jose wrote: > On Wed, 2021-08-18 at 11:54 +0200, Daniel Vetter wrote: > > On Tue, Aug 17, 2021 at 04:26:04PM -0700, José Roberto de Souza wrote: > > > Cursors don't have a framebuffer so the fb comparisson was always > > > failing and atomic state wa

Re: [Intel-gfx] [PATCH] drm/damage_helper: Fix handling of cursor dirty buffers

2021-08-18 Thread Souza, Jose
On Wed, 2021-08-18 at 11:54 +0200, Daniel Vetter wrote: > On Tue, Aug 17, 2021 at 04:26:04PM -0700, José Roberto de Souza wrote: > > Cursors don't have a framebuffer so the fb comparisson was always > > failing and atomic state was being committed without any plane state. > > > > So here checking

Re: [Intel-gfx] [PATCH] drm/damage_helper: Fix handling of cursor dirty buffers

2021-08-18 Thread Daniel Vetter
On Tue, Aug 17, 2021 at 04:26:04PM -0700, José Roberto de Souza wrote: > Cursors don't have a framebuffer so the fb comparisson was always > failing and atomic state was being committed without any plane state. > > So here checking if objects match when checking cursors. This looks extremely back

[Intel-gfx] [PATCH] drm/damage_helper: Fix handling of cursor dirty buffers

2021-08-17 Thread José Roberto de Souza
Cursors don't have a framebuffer so the fb comparisson was always failing and atomic state was being committed without any plane state. So here checking if objects match when checking cursors. Fixes: b9fc5e01d1ce ("drm: Add helper to implement legacy dirtyfb") Cc: Daniel Vetter Cc: Rob Clark Cc