Re: [Intel-gfx] [PATCH] drm/i915/BXT: Configure DSI after enabling DSI pll

2016-02-15 Thread Daniel Vetter
On Wed, Feb 03, 2016 at 02:59:11PM +0200, Mika Kahola wrote: > On Wed, 2016-02-03 at 11:28 +0200, Jani Nikula wrote: > > On Tue, 02 Feb 2016, Ramalingam C wrote: > > > We need to enable DSI PLL before configuring the DSI registers. > > > > > > Signed-off-by: Ramalingam C > > > --- > > > drivers/

[Intel-gfx] [PATCH] drm/i915/BXT: Configure DSI after enabling DSI pll

2016-02-03 Thread Ramalingam C
We need to enable DSI PLL before configuring the DSI registers. Signed-off-by: Ramalingam C --- drivers/gpu/drm/i915/intel_dsi.c |2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/gpu/drm/i915/intel_dsi.c b/drivers/gpu/drm/i915/intel_dsi.c index 91cef35..378f879 10064

Re: [Intel-gfx] [PATCH] drm/i915/BXT: Configure DSI after enabling DSI pll

2016-02-03 Thread Mika Kahola
On Wed, 2016-02-03 at 11:28 +0200, Jani Nikula wrote: > On Tue, 02 Feb 2016, Ramalingam C wrote: > > We need to enable DSI PLL before configuring the DSI registers. > > > > Signed-off-by: Ramalingam C > > --- > > drivers/gpu/drm/i915/intel_dsi.c |2 +- > > 1 file changed, 1 insertion(+), 1 d

Re: [Intel-gfx] [PATCH] drm/i915/BXT: Configure DSI after enabling DSI pll

2016-02-03 Thread Ramalingam C
On Wednesday 03 February 2016 05:25 PM, Jani Nikula wrote: On Wed, 03 Feb 2016, Jani Nikula wrote: On Wed, 03 Feb 2016, Mika Kahola wrote: On Wed, 2016-02-03 at 11:27 +0200, Jani Nikula wrote: On Wed, 03 Feb 2016, "Thulasimani, Sivakumar" wrote: just realized that intel_dsi_init is not c

Re: [Intel-gfx] [PATCH] drm/i915/BXT: Configure DSI after enabling DSI pll

2016-02-03 Thread Jani Nikula
On Wed, 03 Feb 2016, Jani Nikula wrote: > On Wed, 03 Feb 2016, Mika Kahola wrote: >> On Wed, 2016-02-03 at 11:27 +0200, Jani Nikula wrote: >>> On Wed, 03 Feb 2016, "Thulasimani, Sivakumar" >>> wrote: >>> > just realized that intel_dsi_init is not called from setup outputs for >>> > BXT. is thi

Re: [Intel-gfx] [PATCH] drm/i915/BXT: Configure DSI after enabling DSI pll

2016-02-03 Thread Jani Nikula
On Wed, 03 Feb 2016, Mika Kahola wrote: > On Wed, 2016-02-03 at 11:27 +0200, Jani Nikula wrote: >> On Wed, 03 Feb 2016, "Thulasimani, Sivakumar" >> wrote: >> > just realized that intel_dsi_init is not called from setup outputs for >> > BXT. is this expected ? >> > if so when is it expected to b

Re: [Intel-gfx] [PATCH] drm/i915/BXT: Configure DSI after enabling DSI pll

2016-02-03 Thread Mika Kahola
On Wed, 2016-02-03 at 11:27 +0200, Jani Nikula wrote: > On Wed, 03 Feb 2016, "Thulasimani, Sivakumar" > wrote: > > just realized that intel_dsi_init is not called from setup outputs for > > BXT. is this expected ? > > if so when is it expected to be added ? > > > > Again, the current code in int

Re: [Intel-gfx] [PATCH] drm/i915/BXT: Configure DSI after enabling DSI pll

2016-02-03 Thread Jani Nikula
On Tue, 02 Feb 2016, Ramalingam C wrote: > We need to enable DSI PLL before configuring the DSI registers. > > Signed-off-by: Ramalingam C > --- > drivers/gpu/drm/i915/intel_dsi.c |2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/drivers/gpu/drm/i915/intel_dsi.c > b/dr

Re: [Intel-gfx] [PATCH] drm/i915/BXT: Configure DSI after enabling DSI pll

2016-02-03 Thread Jani Nikula
On Wed, 03 Feb 2016, "Thulasimani, Sivakumar" wrote: > just realized that intel_dsi_init is not called from setup outputs for > BXT. is this expected ? > if so when is it expected to be added ? > > Again, the current code in intel_setup_outputs calls intel_dsi_init from > vlv/chv section so plea

Re: [Intel-gfx] [PATCH] drm/i915/BXT: Configure DSI after enabling DSI pll

2016-02-02 Thread Mika Kahola
This change is needed to enable DSI/MIPI display on BXT Reviewed-by: Mika Kahola On Tue, 2016-02-02 at 23:21 +0530, Ramalingam C wrote: > We need to enable DSI PLL before configuring the DSI registers. > > Signed-off-by: Ramalingam C > --- > drivers/gpu/drm/i915/intel_dsi.c |2 +- > 1 fil

Re: [Intel-gfx] [PATCH] drm/i915/BXT: Configure DSI after enabling DSI pll

2016-02-02 Thread Thulasimani, Sivakumar
just realized that intel_dsi_init is not called from setup outputs for BXT. is this expected ? if so when is it expected to be added ? Again, the current code in intel_setup_outputs calls intel_dsi_init from vlv/chv section so please confirm if this is needed for all platforms or just in BXT. O

[Intel-gfx] [PATCH] drm/i915/BXT: Configure DSI after enabling DSI pll

2016-02-02 Thread Ramalingam C
We need to enable DSI PLL before configuring the DSI registers. Signed-off-by: Ramalingam C --- drivers/gpu/drm/i915/intel_dsi.c |2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/gpu/drm/i915/intel_dsi.c b/drivers/gpu/drm/i915/intel_dsi.c index 91cef35..378f879 10064