Re: [Intel-gfx] [PATCH] drm/i915/audio: Skip the cdclk modeset if no pipes attached

2020-02-03 Thread Kai Vehmanen
Hey, On Mon, 3 Feb 2020, Ville Syrjälä wrote: > > /* need to hold at least one crtc lock for the global state */ > > - crtc = intel_get_crtc_for_pipe(dev_priv, PIPE_A); > > Was thinking a simple 'return 0' would do the trick, but maybe we > don't want to call this at all. OTOH not sure

Re: [Intel-gfx] [PATCH] drm/i915/audio: Skip the cdclk modeset if no pipes attached

2020-02-03 Thread Chris Wilson
Quoting Ville Syrjälä (2020-02-03 13:23:17) > On Sat, Feb 01, 2020 at 09:46:41AM +, Chris Wilson wrote: > > -static int glk_force_audio_cdclk_commit(struct intel_atomic_state *state, > > +static int glk_force_audio_cdclk_commit(struct intel_crtc *crtc, > > +

Re: [Intel-gfx] [PATCH] drm/i915/audio: Skip the cdclk modeset if no pipes attached

2020-02-03 Thread Ville Syrjälä
On Sat, Feb 01, 2020 at 09:46:41AM +, Chris Wilson wrote: > If the display is not driving any pipes, we cannot change the bclk and > doing so risks chasing NULL pointers: > > <6> [278.907105] snd_hda_intel :00:0e.0: DSP detected with PCI > class/subclass/prog-if info 0x040100 > <6>

Re: [Intel-gfx] [PATCH] drm/i915/audio: Skip the cdclk modeset if no pipes attached

2020-02-02 Thread Jani Nikula
On Sat, 01 Feb 2020, Chris Wilson wrote: > Quoting Jani Nikula (2020-02-01 12:36:46) >> On Sat, 01 Feb 2020, Chris Wilson wrote: >> > If the display is not driving any pipes, we cannot change the bclk and >> > doing so risks chasing NULL pointers: >> >> Does this mean we can't probe hda if

Re: [Intel-gfx] [PATCH] drm/i915/audio: Skip the cdclk modeset if no pipes attached

2020-02-01 Thread Chris Wilson
Quoting Jani Nikula (2020-02-01 12:36:46) > On Sat, 01 Feb 2020, Chris Wilson wrote: > > If the display is not driving any pipes, we cannot change the bclk and > > doing so risks chasing NULL pointers: > > Does this mean we can't probe hda if there are no displays attached at > boot on GLK? We

Re: [Intel-gfx] [PATCH] drm/i915/audio: Skip the cdclk modeset if no pipes attached

2020-02-01 Thread Jani Nikula
On Sat, 01 Feb 2020, Chris Wilson wrote: > If the display is not driving any pipes, we cannot change the bclk and > doing so risks chasing NULL pointers: Does this mean we can't probe hda if there are no displays attached at boot on GLK? BR, Jani. > > <6> [278.907105] snd_hda_intel

[Intel-gfx] [PATCH] drm/i915/audio: Skip the cdclk modeset if no pipes attached

2020-02-01 Thread Chris Wilson
If the display is not driving any pipes, we cannot change the bclk and doing so risks chasing NULL pointers: <6> [278.907105] snd_hda_intel :00:0e.0: DSP detected with PCI class/subclass/prog-if info 0x040100 <6> [278.909936] snd_hda_intel :00:0e.0: bound :00:02.0 (ops