Re: [Intel-gfx] [PATCH] drm/i915/chv: WaDisablePwrmtrEvent:chv on CHV only

2014-06-12 Thread Jani Nikula
On Tue, 10 Jun 2014, Jani Nikula jani.nik...@linux.intel.com wrote: On Tue, 10 Jun 2014, Ville Syrjälä ville.syrj...@linux.intel.com wrote: On Tue, Jun 10, 2014 at 06:34:18PM +0300, Jani Nikula wrote: On Tue, 10 Jun 2014, Jani Nikula jani.nik...@linux.intel.com wrote: On Mon, 09 Jun 2014,

Re: [Intel-gfx] [PATCH] drm/i915/chv: WaDisablePwrmtrEvent:chv on CHV only

2014-06-12 Thread Daniel Vetter
On Thu, Jun 12, 2014 at 01:33:32PM +0300, Jani Nikula wrote: On Tue, 10 Jun 2014, Jani Nikula jani.nik...@linux.intel.com wrote: On Tue, 10 Jun 2014, Ville Syrjälä ville.syrj...@linux.intel.com wrote: On Tue, Jun 10, 2014 at 06:34:18PM +0300, Jani Nikula wrote: On Tue, 10 Jun 2014, Jani

Re: [Intel-gfx] [PATCH] drm/i915/chv: WaDisablePwrmtrEvent:chv on CHV only

2014-06-10 Thread Jani Nikula
On Mon, 09 Jun 2014, Damien Lespiau damien.lesp...@intel.com wrote: On Mon, Jun 09, 2014 at 10:06:49AM -0700, Tom.O'rou...@intel.com wrote: From: Tom O'Rourke Tom.O'rou...@intel.com In gen8_enable_rps, don't write CHV registers unless IS_CHERRYVIEW. Signed-off-by: Tom O'Rourke

Re: [Intel-gfx] [PATCH] drm/i915/chv: WaDisablePwrmtrEvent:chv on CHV only

2014-06-10 Thread Jani Nikula
On Tue, 10 Jun 2014, Jani Nikula jani.nik...@linux.intel.com wrote: On Mon, 09 Jun 2014, Damien Lespiau damien.lesp...@intel.com wrote: On Mon, Jun 09, 2014 at 10:06:49AM -0700, Tom.O'rou...@intel.com wrote: From: Tom O'Rourke Tom.O'rou...@intel.com In gen8_enable_rps, don't write CHV

Re: [Intel-gfx] [PATCH] drm/i915/chv: WaDisablePwrmtrEvent:chv on CHV only

2014-06-10 Thread Ville Syrjälä
On Tue, Jun 10, 2014 at 06:34:18PM +0300, Jani Nikula wrote: On Tue, 10 Jun 2014, Jani Nikula jani.nik...@linux.intel.com wrote: On Mon, 09 Jun 2014, Damien Lespiau damien.lesp...@intel.com wrote: On Mon, Jun 09, 2014 at 10:06:49AM -0700, Tom.O'rou...@intel.com wrote: From: Tom O'Rourke

Re: [Intel-gfx] [PATCH] drm/i915/chv: WaDisablePwrmtrEvent:chv on CHV only

2014-06-10 Thread Jani Nikula
On Tue, 10 Jun 2014, Ville Syrjälä ville.syrj...@linux.intel.com wrote: On Tue, Jun 10, 2014 at 06:34:18PM +0300, Jani Nikula wrote: On Tue, 10 Jun 2014, Jani Nikula jani.nik...@linux.intel.com wrote: On Mon, 09 Jun 2014, Damien Lespiau damien.lesp...@intel.com wrote: On Mon, Jun 09, 2014 at

Re: [Intel-gfx] [PATCH] drm/i915/chv: WaDisablePwrmtrEvent:chv on CHV only

2014-06-10 Thread O'Rourke, Tom
This is just a merge mishap in one the chv patches. Someone just needs to send a patch that moves the misapplied stuff to the appropriate chv function. Right. So my first comment was correct, and my elaboration total bullcrap. This is not present in 3.15, but we've queued the screwup for 3.16.

Re: [Intel-gfx] [PATCH] drm/i915/chv: WaDisablePwrmtrEvent:chv on CHV only

2014-06-10 Thread Ville Syrjälä
On Tue, Jun 10, 2014 at 07:03:48PM +, O'Rourke, Tom wrote: This is just a merge mishap in one the chv patches. Someone just needs to send a patch that moves the misapplied stuff to the appropriate chv function. Right. So my first comment was correct, and my elaboration total bullcrap.

[Intel-gfx] [PATCH] drm/i915/chv: WaDisablePwrmtrEvent:chv on CHV only

2014-06-09 Thread Tom . O'Rourke
From: Tom O'Rourke Tom.O'rou...@intel.com In gen8_enable_rps, don't write CHV registers unless IS_CHERRYVIEW. Signed-off-by: Tom O'Rourke Tom.O'rou...@intel.com --- drivers/gpu/drm/i915/intel_pm.c |6 -- 1 file changed, 4 insertions(+), 2 deletions(-) diff --git

Re: [Intel-gfx] [PATCH] drm/i915/chv: WaDisablePwrmtrEvent:chv on CHV only

2014-06-09 Thread Damien Lespiau
On Mon, Jun 09, 2014 at 10:06:49AM -0700, Tom.O'rou...@intel.com wrote: From: Tom O'Rourke Tom.O'rou...@intel.com In gen8_enable_rps, don't write CHV registers unless IS_CHERRYVIEW. Signed-off-by: Tom O'Rourke Tom.O'rou...@intel.com A lovely catch. Reviewed-by: Damien Lespiau