Re: [Intel-gfx] [PATCH] drm/i915/cnl: Enable Audio Pin Buffer.

2018-02-07 Thread Guneshwor Singh
Hi Rodrigo, On Wed, Feb 07, 2018 at 04:37:33PM -0800, Rodrigo Vivi wrote: > Rodrigo Vivi writes: > > > Starting on CNL, we need to enable Audio Pin Buffer. > > Ok... I forgot to include ICL on this now. > But first let's check if this is working on CNL and later I sent a v5. > This does not w

Re: [Intel-gfx] [PATCH] drm/i915/cnl: Enable Audio Pin Buffer.

2018-02-07 Thread Rodrigo Vivi
Rodrigo Vivi writes: > Starting on CNL, we need to enable Audio Pin Buffer. Ok... I forgot to include ICL on this now. But first let's check if this is working on CNL and later I sent a v5. On top of that for CNL and ICL audio needs to know when we are switching cdclk. But for this work I'd lik

[Intel-gfx] [PATCH] drm/i915/cnl: Enable Audio Pin Buffer.

2018-02-07 Thread Rodrigo Vivi
Starting on CNL, we need to enable Audio Pin Buffer. v4: Throw the exclusive hook and everything else away and add set/unset bit along with codec awake. Based on few spec links that I was checking recently I now believe that on CNL we also need to keep the codec awake chicken bit along with P

Re: [Intel-gfx] [PATCH] drm/i915/cnl: Enable Audio Pin Buffer.

2017-08-17 Thread Pandiyan, Dhinakaran
On Thu, 2017-08-17 at 18:55 +, Vivi, Rodrigo wrote: > On Thu, 2017-08-17 at 09:26 +0530, Sanyog Kale wrote: > > On Wed, Aug 16, 2017 at 06:46:26PM -0500, Pandiyan, Dhinakaran wrote: > > > On Thu, 2017-07-06 at 14:03 -0700, Rodrigo Vivi wrote: > > > > Starting on CNL, we need to enable Audio Pin

Re: [Intel-gfx] [PATCH] drm/i915/cnl: Enable Audio Pin Buffer.

2017-08-17 Thread Vivi, Rodrigo
On Thu, 2017-08-17 at 09:26 +0530, Sanyog Kale wrote: > On Wed, Aug 16, 2017 at 06:46:26PM -0500, Pandiyan, Dhinakaran wrote: > > On Thu, 2017-07-06 at 14:03 -0700, Rodrigo Vivi wrote: > > > Starting on CNL, we need to enable Audio Pin Buffer. > > > > > > By the spec it seems that this is part of

Re: [Intel-gfx] [PATCH] drm/i915/cnl: Enable Audio Pin Buffer.

2017-08-16 Thread Sanyog Kale
On Wed, Aug 16, 2017 at 06:46:26PM -0500, Pandiyan, Dhinakaran wrote: > On Thu, 2017-07-06 at 14:03 -0700, Rodrigo Vivi wrote: > > Starting on CNL, we need to enable Audio Pin Buffer. > > > > By the spec it seems that this is part of audio programming, > > I am not very clear where the pin buffer

Re: [Intel-gfx] [PATCH] drm/i915/cnl: Enable Audio Pin Buffer.

2017-08-16 Thread Pandiyan, Dhinakaran
On Thu, 2017-07-06 at 14:03 -0700, Rodrigo Vivi wrote: > Starting on CNL, we need to enable Audio Pin Buffer. > > By the spec it seems that this is part of audio programming, I am not very clear where the pin buffer enabling/disabling step falls in the audio programming sequence. From what I unde

[Intel-gfx] [PATCH] drm/i915/cnl: Enable Audio Pin Buffer.

2017-07-06 Thread Rodrigo Vivi
Starting on CNL, we need to enable Audio Pin Buffer. By the spec it seems that this is part of audio programming, so let's give them the hability to set/unset this as needed. v2: With a hook so audio driver can control it. v3: Put back reg definition lost on v2. Cc: Dhinakaran Pandiyan Cc: Jani