On 12.1.2023 20.28, Ville Syrjälä wrote:
On Mon, Dec 26, 2022 at 10:53:24PM -0700, Drew Davenport wrote:
The error message suggests that the height of the src rect must be at
least 1. Reject source with height of 0.
Signed-off-by: Drew Davenport
---
I was investigating some divide-by-zero cra
On Mon, Dec 26, 2022 at 10:53:24PM -0700, Drew Davenport wrote:
> The error message suggests that the height of the src rect must be at
> least 1. Reject source with height of 0.
>
> Signed-off-by: Drew Davenport
>
> ---
> I was investigating some divide-by-zero crash reports on ChromeOS which
>
On Tue, Dec 27, 2022 at 05:55:17PM +, Teres Alexis, Alan Previn wrote:
> Is there a better place for this check higher up the intel specific
> atomic-check? (so the check won't be skl specific - i notice that
> intel_adjusted_rate is also called by
> ilk_foo as well and non-backend-specific f
On Tue, Jan 03, 2023 at 12:42:43PM +0200, Juha-Pekka Heikkila wrote:
> Hi Drew,
Hi Juha-Pekka, sorry for the late response since I was on vacation.
>
> this is good find. I went looking where the problem is in and saw what you
> probably also saw earlier.
>
> I was wondering if diff below would
Hi Drew,
this is good find. I went looking where the problem is in and saw what
you probably also saw earlier.
I was wondering if diff below would be better fix? I assume this would
end up with einval or erange in your case but code flow otherwise would
stay as is while fixing all future cal
Is there a better place for this check higher up the intel specific
atomic-check? (so the check won't be skl specific - i notice that
intel_adjusted_rate is also called by
ilk_foo as well and non-backend-specific functions). Else, perhaps
intel_adjusted_rate should add a check + WARN? (if we are
The error message suggests that the height of the src rect must be at
least 1. Reject source with height of 0.
Signed-off-by: Drew Davenport
---
I was investigating some divide-by-zero crash reports on ChromeOS which
pointed to the intel_adjusted_rate function. Further prodding showed
that I cou
