Re: [Intel-gfx] [PATCH] drm/i915/display: Defer application of initial chv_phy_control

2020-02-05 Thread Hans de Goede
Hi, On 2/3/20 2:12 PM, Ville Syrjälä wrote: On Sat, Feb 01, 2020 at 10:31:59AM +, Chris Wilson wrote: To write to the DISPLAY_PHY_CONTROL requires holding the powerwells, which during early resume we have not yet acquired until later in intel_display_power_init_hw(). So compute the initial

Re: [Intel-gfx] [PATCH] drm/i915/display: Defer application of initial chv_phy_control

2020-02-03 Thread Chris Wilson
Quoting Ville Syrjälä (2020-02-03 13:12:03) > On Sat, Feb 01, 2020 at 10:31:59AM +, Chris Wilson wrote: > What I don't undestand is what actually changed to cause this? Did we > reorganize something in the init/resume sequence that previously forced > the display power well on before this

Re: [Intel-gfx] [PATCH] drm/i915/display: Defer application of initial chv_phy_control

2020-02-03 Thread Ville Syrjälä
On Sat, Feb 01, 2020 at 10:31:59AM +, Chris Wilson wrote: > To write to the DISPLAY_PHY_CONTROL requires holding the powerwells, > which during early resume we have not yet acquired until later in > intel_display_power_init_hw(). So compute the initial chv_phy_control, > but leave the HW unset

[Intel-gfx] [PATCH] drm/i915/display: Defer application of initial chv_phy_control

2020-02-01 Thread Chris Wilson
To write to the DISPLAY_PHY_CONTROL requires holding the powerwells, which during early resume we have not yet acquired until later in intel_display_power_init_hw(). So compute the initial chv_phy_control, but leave the HW unset until we first acquire the powerwell. <7> [120.055984] i915