Re: [Intel-gfx] [PATCH] drm/i915/fbc: Avoid full proxy f_ops for FBC debug attributes

2023-01-09 Thread Deepak R Varma
On Mon, Jan 09, 2023 at 02:06:13PM -0500, Rodrigo Vivi wrote: > On Sun, Jan 08, 2023 at 01:33:41AM +0530, Deepak R Varma wrote: > > On Thu, Jan 05, 2023 at 09:13:35AM +0100, Julia Lawall wrote: > > > > Hi Julia, thanks for helping here. > > > > > > > > So, my question is why this > > > > > > > > ma

Re: [Intel-gfx] [PATCH] drm/i915/fbc: Avoid full proxy f_ops for FBC debug attributes

2023-01-09 Thread Rodrigo Vivi
On Sun, Jan 08, 2023 at 01:33:41AM +0530, Deepak R Varma wrote: > On Thu, Jan 05, 2023 at 09:13:35AM +0100, Julia Lawall wrote: > > > Hi Julia, thanks for helping here. > > > > > > So, my question is why this > > > > > > make coccicheck M=drivers/gpu/drm/i915/ MODE=context > > > COCCI=./scripts/co

Re: [Intel-gfx] [PATCH] drm/i915/fbc: Avoid full proxy f_ops for FBC debug attributes

2023-01-07 Thread Deepak R Varma
On Thu, Jan 05, 2023 at 09:13:35AM +0100, Julia Lawall wrote: > > Hi Julia, thanks for helping here. > > > > So, my question is why this > > > > make coccicheck M=drivers/gpu/drm/i915/ MODE=context > > COCCI=./scripts/coccinelle/api/debugfs/debugfs_simple_attr.cocci > > > > didn't catch this chunc

Re: [Intel-gfx] [PATCH] drm/i915/fbc: Avoid full proxy f_ops for FBC debug attributes

2023-01-05 Thread Julia Lawall
> Hi Julia, thanks for helping here. > > So, my question is why this > > make coccicheck M=drivers/gpu/drm/i915/ MODE=context > COCCI=./scripts/coccinelle/api/debugfs/debugfs_simple_attr.cocci > > didn't catch this chunck: > > - debugfs_create_file("i915_fbc_false_color", 0644, parent,

Re: [Intel-gfx] [PATCH] drm/i915/fbc: Avoid full proxy f_ops for FBC debug attributes

2023-01-04 Thread Julia Lawall
On Tue, 3 Jan 2023, Deepak R Varma wrote: > On Wed, Dec 28, 2022 at 06:18:12AM -0500, Rodrigo Vivi wrote: > > On Tue, Dec 27, 2022 at 11:36:13PM +0530, Deepak R Varma wrote: > > > On Tue, Dec 27, 2022 at 12:13:56PM -0500, Rodrigo Vivi wrote: > > > > On Tue, Dec 27, 2022 at 01:30:53PM +0530, Dee

Re: [Intel-gfx] [PATCH] drm/i915/fbc: Avoid full proxy f_ops for FBC debug attributes

2023-01-04 Thread Rodrigo Vivi
On Wed, Jan 04, 2023 at 06:51:37PM +0100, Julia Lawall wrote: > > > On Tue, 3 Jan 2023, Deepak R Varma wrote: > > > On Wed, Dec 28, 2022 at 06:18:12AM -0500, Rodrigo Vivi wrote: > > > On Tue, Dec 27, 2022 at 11:36:13PM +0530, Deepak R Varma wrote: > > > > On Tue, Dec 27, 2022 at 12:13:56PM -0500

Re: [Intel-gfx] [PATCH] drm/i915/fbc: Avoid full proxy f_ops for FBC debug attributes

2023-01-02 Thread Deepak R Varma
On Wed, Dec 28, 2022 at 06:18:12AM -0500, Rodrigo Vivi wrote: > On Tue, Dec 27, 2022 at 11:36:13PM +0530, Deepak R Varma wrote: > > On Tue, Dec 27, 2022 at 12:13:56PM -0500, Rodrigo Vivi wrote: > > > On Tue, Dec 27, 2022 at 01:30:53PM +0530, Deepak R Varma wrote: > > > > Using DEFINE_SIMPLE_ATTRIBU

Re: [Intel-gfx] [PATCH] drm/i915/fbc: Avoid full proxy f_ops for FBC debug attributes

2022-12-28 Thread Rodrigo Vivi
On Tue, Dec 27, 2022 at 11:36:13PM +0530, Deepak R Varma wrote: > On Tue, Dec 27, 2022 at 12:13:56PM -0500, Rodrigo Vivi wrote: > > On Tue, Dec 27, 2022 at 01:30:53PM +0530, Deepak R Varma wrote: > > > Using DEFINE_SIMPLE_ATTRIBUTE macro with the debugfs_create_file() > > > function adds the overhe

Re: [Intel-gfx] [PATCH] drm/i915/fbc: Avoid full proxy f_ops for FBC debug attributes

2022-12-27 Thread Deepak R Varma
On Tue, Dec 27, 2022 at 12:13:56PM -0500, Rodrigo Vivi wrote: > On Tue, Dec 27, 2022 at 01:30:53PM +0530, Deepak R Varma wrote: > > Using DEFINE_SIMPLE_ATTRIBUTE macro with the debugfs_create_file() > > function adds the overhead of introducing a proxy file operation > > functions to wrap the origi

Re: [Intel-gfx] [PATCH] drm/i915/fbc: Avoid full proxy f_ops for FBC debug attributes

2022-12-27 Thread Rodrigo Vivi
On Tue, Dec 27, 2022 at 01:30:53PM +0530, Deepak R Varma wrote: > Using DEFINE_SIMPLE_ATTRIBUTE macro with the debugfs_create_file() > function adds the overhead of introducing a proxy file operation > functions to wrap the original read/write inside file removal protection > functions. This adds s

[Intel-gfx] [PATCH] drm/i915/fbc: Avoid full proxy f_ops for FBC debug attributes

2022-12-27 Thread Deepak R Varma
Using DEFINE_SIMPLE_ATTRIBUTE macro with the debugfs_create_file() function adds the overhead of introducing a proxy file operation functions to wrap the original read/write inside file removal protection functions. This adds significant overhead in terms of introducing and managing the proxy facto