Re: [Intel-gfx] [PATCH] drm/i915/gem: Avoid iterating an empty list

2020-05-22 Thread Matthew Auld
On Fri, 22 May 2020 at 13:02, Chris Wilson wrote: > > Quoting Chris Wilson (2020-05-22 11:42:07) > > Our __sgt_iter assumes that the scattergather list has at least one > > element. But during construction we may fail in allocating the first > > page, and so mark the first element as the

Re: [Intel-gfx] [PATCH] drm/i915/gem: Avoid iterating an empty list

2020-05-22 Thread Chris Wilson
Quoting Chris Wilson (2020-05-22 11:42:07) > Our __sgt_iter assumes that the scattergather list has at least one > element. But during construction we may fail in allocating the first > page, and so mark the first element as the terminator. This is > unexpected! > > [22555.524752] RIP:

[Intel-gfx] [PATCH] drm/i915/gem: Avoid iterating an empty list

2020-05-22 Thread Chris Wilson
Our __sgt_iter assumes that the scattergather list has at least one element. But during construction we may fail in allocating the first page, and so mark the first element as the terminator. This is unexpected! [22555.524752] RIP: 0010:shmem_get_pages+0x506/0x710 [i915] [22555.524759] Code: 49