Re: [Intel-gfx] [PATCH] drm/i915/gem: Comment on inability to check args.pad for MMAP_OFFSET

2019-12-09 Thread Joonas Lahtinen
Quoting Chris Wilson (2019-12-08 00:26:44) > Since we didn't check and insist that args.pad must be zero for MMAP_GTT > historically, we cannot insert a check now as old userspace may be > feeding in garbage. As such the lack of check is enshrined into the ABI, > so add a comment to remind us we ca

[Intel-gfx] [PATCH] drm/i915/gem: Comment on inability to check args.pad for MMAP_OFFSET

2019-12-07 Thread Chris Wilson
Since we didn't check and insist that args.pad must be zero for MMAP_GTT historically, we cannot insert a check now as old userspace may be feeding in garbage. As such the lack of check is enshrined into the ABI, so add a comment to remind us we cannot add the check later. Signed-off-by: Chris Wil