Re: [Intel-gfx] [PATCH] drm/i915/gsc: GSC firmware loading

2022-12-07 Thread Ceraolo Spurio, Daniele
On 12/7/2022 2:16 AM, Teres Alexis, Alan Previn wrote: Diffed the patches and reviewed the changes -- i.e. the use of the worker for the gsc fw loading cmd submission. All looks good - just a few nits below. Reviewed-by: Alan Previn On Mon, 2022-12-05 at 21:15 -0800, Ceraolo Spurio, Daniel

Re: [Intel-gfx] [PATCH] drm/i915/gsc: GSC firmware loading

2022-12-07 Thread Teres Alexis, Alan Previn
Diffed the patches and reviewed the changes -- i.e. the use of the worker for the gsc fw loading cmd submission. All looks good - just a few nits below. Reviewed-by: Alan Previn On Mon, 2022-12-05 at 21:15 -0800, Ceraolo Spurio, Daniele wrote: > GSC FW is loaded by submitting a dedicated comman

[Intel-gfx] [PATCH] drm/i915/gsc: GSC firmware loading

2022-12-05 Thread Daniele Ceraolo Spurio
GSC FW is loaded by submitting a dedicated command via the GSC engine. The memory area used for loading the FW is then re-purposed as local memory for the GSC itself, so we use a separate allocation instead of using the one where we keep the firmware stored for reload. The GSC is not reset as part