Re: [Intel-gfx] [PATCH] drm/i915/guc: remove redundant GEM_BUG_ON check

2018-06-11 Thread Colin Ian King
On 11/06/18 17:25, Ville Syrjälä wrote: > On Mon, Jun 11, 2018 at 05:00:37PM +0100, Colin King wrote: >> From: Colin Ian King >> >> The check for level being less than zero is redundant as level >> is an unsigned u32 and hence will never be less than zero. >> Remove this redundant check. >> >>

Re: [Intel-gfx] [PATCH] drm/i915/guc: remove redundant GEM_BUG_ON check

2018-06-11 Thread Ville Syrjälä
On Mon, Jun 11, 2018 at 05:00:37PM +0100, Colin King wrote: > From: Colin Ian King > > The check for level being less than zero is redundant as level > is an unsigned u32 and hence will never be less than zero. > Remove this redundant check. > > Detected by CoverityScan, CID#1468363 ("Macro

[Intel-gfx] [PATCH] drm/i915/guc: remove redundant GEM_BUG_ON check

2018-06-11 Thread Colin King
From: Colin Ian King The check for level being less than zero is redundant as level is an unsigned u32 and hence will never be less than zero. Remove this redundant check. Detected by CoverityScan, CID#1468363 ("Macro compares unsigned to 0") Signed-off-by: Colin Ian King ---