Re: [Intel-gfx] [PATCH] drm/i915/huc: Fix error reported by I915_PARAM_HUC_STATUS

2020-02-28 Thread Michal Wajdeczko
On 28.02.2020 12:33, Joonas Lahtinen wrote: >>> --+-- >>>    HuC state   | option B >>> --+-- >>> no HuC hardware   | -ENODEV >>> GuC fw disabled   | -EOPNOTSUPP -> user decision, why error? >>> HuC fw disabled   |

Re: [Intel-gfx] [PATCH] drm/i915/huc: Fix error reported by I915_PARAM_HUC_STATUS

2020-02-28 Thread Joonas Lahtinen
> > --+-- > >    HuC state   | option B > > --+-- > > no HuC hardware   | -ENODEV > > GuC fw disabled   | -EOPNOTSUPP -> user decision, why error? > > HuC fw disabled   | -EOPNOTSUPP -> user decision, why error? > >

Re: [Intel-gfx] [PATCH] drm/i915/huc: Fix error reported by I915_PARAM_HUC_STATUS

2020-02-20 Thread Ye, Tony
On 2/12/2020 5:54 AM, Fosha, Robert M wrote: On 2/11/20 11:57 AM, Michal Wajdeczko wrote: On Tue, 11 Feb 2020 18:53:05 +0100, Fosha, Robert M wrote: On 2/4/20 4:43 PM, Ye, Tony wrote: On 1/27/2020 1:41 AM, Michal Wajdeczko wrote: On Thu, 23 Jan 2020 16:51:58 +0100, Chris Wilson

Re: [Intel-gfx] [PATCH] drm/i915/huc: Fix error reported by I915_PARAM_HUC_STATUS

2020-02-11 Thread Fosha, Robert M
On 2/11/20 11:57 AM, Michal Wajdeczko wrote: On Tue, 11 Feb 2020 18:53:05 +0100, Fosha, Robert M wrote: On 2/4/20 4:43 PM, Ye, Tony wrote: On 1/27/2020 1:41 AM, Michal Wajdeczko wrote: On Thu, 23 Jan 2020 16:51:58 +0100, Chris Wilson wrote: Quoting Michal Wajdeczko (2020-01-23

Re: [Intel-gfx] [PATCH] drm/i915/huc: Fix error reported by I915_PARAM_HUC_STATUS

2020-02-11 Thread Michal Wajdeczko
On Tue, 11 Feb 2020 18:53:05 +0100, Fosha, Robert M wrote: On 2/4/20 4:43 PM, Ye, Tony wrote: On 1/27/2020 1:41 AM, Michal Wajdeczko wrote: On Thu, 23 Jan 2020 16:51:58 +0100, Chris Wilson wrote: Quoting Michal Wajdeczko (2020-01-23 15:38:52) On Thu, 23 Jan 2020 16:02:17 +0100,

Re: [Intel-gfx] [PATCH] drm/i915/huc: Fix error reported by I915_PARAM_HUC_STATUS

2020-02-11 Thread Fosha, Robert M
On 2/4/20 4:43 PM, Ye, Tony wrote: On 1/27/2020 1:41 AM, Michal Wajdeczko wrote: On Thu, 23 Jan 2020 16:51:58 +0100, Chris Wilson wrote: Quoting Michal Wajdeczko (2020-01-23 15:38:52) On Thu, 23 Jan 2020 16:02:17 +0100, Chris Wilson wrote: > Quoting Daniele Ceraolo Spurio

Re: [Intel-gfx] [PATCH] drm/i915/huc: Fix error reported by I915_PARAM_HUC_STATUS

2020-02-04 Thread Ye, Tony
On 1/27/2020 1:41 AM, Michal Wajdeczko wrote: On Thu, 23 Jan 2020 16:51:58 +0100, Chris Wilson wrote: Quoting Michal Wajdeczko (2020-01-23 15:38:52) On Thu, 23 Jan 2020 16:02:17 +0100, Chris Wilson wrote: > Quoting Daniele Ceraolo Spurio (2020-01-22 23:52:33) >> >> >> On 1/22/20 11:48

Re: [Intel-gfx] [PATCH] drm/i915/huc: Fix error reported by I915_PARAM_HUC_STATUS

2020-01-26 Thread Michal Wajdeczko
On Thu, 23 Jan 2020 16:51:58 +0100, Chris Wilson wrote: Quoting Michal Wajdeczko (2020-01-23 15:38:52) On Thu, 23 Jan 2020 16:02:17 +0100, Chris Wilson wrote: > Quoting Daniele Ceraolo Spurio (2020-01-22 23:52:33) >> >> >> On 1/22/20 11:48 AM, Michal Wajdeczko wrote: >> > From commit

Re: [Intel-gfx] [PATCH] drm/i915/huc: Fix error reported by I915_PARAM_HUC_STATUS

2020-01-23 Thread Ye, Tony
On 1/23/2020 7:38 AM, Michal Wajdeczko wrote: On Thu, 23 Jan 2020 16:02:17 +0100, Chris Wilson wrote: Quoting Daniele Ceraolo Spurio (2020-01-22 23:52:33) On 1/22/20 11:48 AM, Michal Wajdeczko wrote: >  From commit 84b1ca2f0e68 ("drm/i915/uc: prefer intel_gt over i915 > in GuC/HuC

Re: [Intel-gfx] [PATCH] drm/i915/huc: Fix error reported by I915_PARAM_HUC_STATUS

2020-01-23 Thread Ye, Tony
On 1/23/2020 7:38 AM, Michal Wajdeczko wrote: On Thu, 23 Jan 2020 16:02:17 +0100, Chris Wilson wrote: Quoting Daniele Ceraolo Spurio (2020-01-22 23:52:33) On 1/22/20 11:48 AM, Michal Wajdeczko wrote: >  From commit 84b1ca2f0e68 ("drm/i915/uc: prefer intel_gt over i915 > in GuC/HuC

Re: [Intel-gfx] [PATCH] drm/i915/huc: Fix error reported by I915_PARAM_HUC_STATUS

2020-01-23 Thread Michal Wajdeczko
On Thu, 23 Jan 2020 19:26:58 +0100, Ye, Tony wrote: On 1/23/2020 7:38 AM, Michal Wajdeczko wrote: On Thu, 23 Jan 2020 16:02:17 +0100, Chris Wilson wrote: Quoting Daniele Ceraolo Spurio (2020-01-22 23:52:33) On 1/22/20 11:48 AM, Michal Wajdeczko wrote: > From commit 84b1ca2f0e68

Re: [Intel-gfx] [PATCH] drm/i915/huc: Fix error reported by I915_PARAM_HUC_STATUS

2020-01-23 Thread Ye, Tony
Acked-by: Tony Ye On 1/22/2020 11:48 AM, Michal Wajdeczko wrote: From commit 84b1ca2f0e68 ("drm/i915/uc: prefer intel_gt over i915 in GuC/HuC paths") we stopped using HUC_STATUS error -ENODEV only to indicate lack of HuC hardware and we started to use this error also for all other cases when

Re: [Intel-gfx] [PATCH] drm/i915/huc: Fix error reported by I915_PARAM_HUC_STATUS

2020-01-23 Thread Chris Wilson
Quoting Michal Wajdeczko (2020-01-23 15:38:52) > On Thu, 23 Jan 2020 16:02:17 +0100, Chris Wilson > wrote: > > > Quoting Daniele Ceraolo Spurio (2020-01-22 23:52:33) > >> > >> > >> On 1/22/20 11:48 AM, Michal Wajdeczko wrote: > >> > From commit 84b1ca2f0e68 ("drm/i915/uc: prefer intel_gt over

Re: [Intel-gfx] [PATCH] drm/i915/huc: Fix error reported by I915_PARAM_HUC_STATUS

2020-01-23 Thread Michal Wajdeczko
On Thu, 23 Jan 2020 16:02:17 +0100, Chris Wilson wrote: Quoting Daniele Ceraolo Spurio (2020-01-22 23:52:33) On 1/22/20 11:48 AM, Michal Wajdeczko wrote: > From commit 84b1ca2f0e68 ("drm/i915/uc: prefer intel_gt over i915 > in GuC/HuC paths") we stopped using HUC_STATUS error -ENODEV

Re: [Intel-gfx] [PATCH] drm/i915/huc: Fix error reported by I915_PARAM_HUC_STATUS

2020-01-23 Thread Chris Wilson
Quoting Daniele Ceraolo Spurio (2020-01-22 23:52:33) > > > On 1/22/20 11:48 AM, Michal Wajdeczko wrote: > > From commit 84b1ca2f0e68 ("drm/i915/uc: prefer intel_gt over i915 > > in GuC/HuC paths") we stopped using HUC_STATUS error -ENODEV only > > to indicate lack of HuC hardware and we started

Re: [Intel-gfx] [PATCH] drm/i915/huc: Fix error reported by I915_PARAM_HUC_STATUS

2020-01-22 Thread Daniele Ceraolo Spurio
On 1/22/20 11:48 AM, Michal Wajdeczko wrote: From commit 84b1ca2f0e68 ("drm/i915/uc: prefer intel_gt over i915 in GuC/HuC paths") we stopped using HUC_STATUS error -ENODEV only to indicate lack of HuC hardware and we started to use this error also for all other cases when HuC was not in use

[Intel-gfx] [PATCH] drm/i915/huc: Fix error reported by I915_PARAM_HUC_STATUS

2020-01-22 Thread Michal Wajdeczko
>From commit 84b1ca2f0e68 ("drm/i915/uc: prefer intel_gt over i915 in GuC/HuC paths") we stopped using HUC_STATUS error -ENODEV only to indicate lack of HuC hardware and we started to use this error also for all other cases when HuC was not in use or supported. Fix that by relying again on