On 11/2/22 8:32 AM, Joonas Lahtinen wrote:
Quoting Jani Nikula (2022-10-28 11:46:21)
On Fri, 28 Oct 2022, Gwan-gyeong Mun wrote:
Resend, because some content was accidentally omitted from the previous
reply.
Please ignore the previous email.
Hi all,
I should have written the original comm
Quoting Jani Nikula (2022-10-28 11:46:21)
> On Fri, 28 Oct 2022, Gwan-gyeong Mun wrote:
> > Resend, because some content was accidentally omitted from the previous
> > reply.
> > Please ignore the previous email.
> >
> > Hi all,
> >
> > I should have written the original commit message more accur
On Fri, 28 Oct 2022, Gwan-gyeong Mun wrote:
> Resend, because some content was accidentally omitted from the previous
> reply.
> Please ignore the previous email.
>
> Hi all,
>
> I should have written the original commit message more accurately, but
> it seems that it was written inaccurately.
>
Resend, because some content was accidentally omitted from the previous
reply.
Please ignore the previous email.
Hi all,
I should have written the original commit message more accurately, but
it seems that it was written inaccurately.
If the FIELD_PREP macro is expanded, the following macros
Hi all,
I should have written the commit message more accurately, but it seems
that it was written inaccurately.
If the FIELD_PREP macro is expanded, the following macros are used.
#define FIELD_PREP(_mask, _val) \
({
On Thu, 27 Oct 2022 10:16:47 -0700, Nick Desaulniers wrote:
>
Hi Nick,
> Thanks, I can repro now.
>
> I haven't detangled the macro soup, but I noticed:
>
> 1. FIELD_PREP is defined in include/linux/bitfield.h which has the
> following comment:
> 18 * Mask must be a compilation time constant.
On Thu, Oct 27, 2022 at 9:53 AM Dixit, Ashutosh
wrote:
>
> On Thu, 27 Oct 2022 09:35:24 -0700, Nick Desaulniers wrote:
> >
>
> Hi Nick,
>
> > On Tue, Oct 25, 2022 at 5:18 PM Andi Shyti
> > wrote:
> > >
> > > Hi Ashutosh,
> > >
> > > > But I'd wait to hear from clang/llvm folks first.
> > >
> > >
On Thu, 27 Oct 2022 09:35:24 -0700, Nick Desaulniers wrote:
>
Hi Nick,
> On Tue, Oct 25, 2022 at 5:18 PM Andi Shyti wrote:
> >
> > Hi Ashutosh,
> >
> > > But I'd wait to hear from clang/llvm folks first.
> >
> > Yeah! Looking forward to getting some ideas :)
>
> Gwan-gyeong, which tree and set o
On Tue, Oct 25, 2022 at 5:18 PM Andi Shyti wrote:
>
> Hi Ashutosh,
>
> > But I'd wait to hear from clang/llvm folks first.
>
> Yeah! Looking forward to getting some ideas :)
Gwan-gyeong, which tree and set of configs are necessary to reproduce
the observed warning?
Warnings are treated as errors
Hi Ashutosh,
> On Tue, 25 Oct 2022 02:25:06 -0700, Andi Shyti wrote:
> >
> > Hi Ashutosh,
>
> Hi Andi :)
>
> > > > If a non-constant variable is used as the first argument of the
> > > > FIELD_PREP
> > > > macro, a build error occurs when using the clang compiler.
>
> A "non-constant variable"
On Tue, 25 Oct 2022 07:30:49 -0700, Jani Nikula wrote:
>
> On Tue, 25 Oct 2022, Jani Nikula wrote:
> > On Tue, 25 Oct 2022, Gwan-gyeong Mun wrote:
> >> If a non-constant variable is used as the first argument of the FIELD_PREP
> >> macro, a build error occurs when using the clang compiler.
> >>
>
On Tue, 25 Oct 2022 02:25:06 -0700, Andi Shyti wrote:
>
> Hi Ashutosh,
Hi Andi :)
> > > If a non-constant variable is used as the first argument of the FIELD_PREP
> > > macro, a build error occurs when using the clang compiler.
A "non-constant variable" does not seem to be the cause of the compi
Start of lore thread for context:
https://lore.kernel.org/intel-gfx/20221024210953.1572998-1-gwan-gyeong@intel.com/
On Tue, Oct 25, 2022 at 2:25 AM Andi Shyti wrote:
>
> Hi Ashutosh,
>
> > > drivers/gpu/drm/i915/i915_hwmon.c:115:16: error: result of comparison of
> > > constant 1844674407370
On Tue, 25 Oct 2022, Jani Nikula wrote:
> On Tue, 25 Oct 2022, Gwan-gyeong Mun wrote:
>> If a non-constant variable is used as the first argument of the FIELD_PREP
>> macro, a build error occurs when using the clang compiler.
>>
>> Fix the following build error used with clang compiler:
>>
>> dri
On Tue, 25 Oct 2022, Gwan-gyeong Mun wrote:
> If a non-constant variable is used as the first argument of the FIELD_PREP
> macro, a build error occurs when using the clang compiler.
>
> Fix the following build error used with clang compiler:
>
> drivers/gpu/drm/i915/i915_hwmon.c:115:16: error: res
Hi Ashutosh,
> > drivers/gpu/drm/i915/i915_hwmon.c:115:16: error: result of comparison of
> > constant 18446744073709551615 with expression of type 'typeof
> > (_Generic((field_msk), char: (unsigned char)0, unsigned char: (unsigned
> > char)0, signed char: (unsigned char)0, unsigned short: (uns
On Tue, Oct 25, 2022 at 12:09:53AM +0300, Gwan-gyeong Mun wrote:
> If a non-constant variable is used as the first argument of the FIELD_PREP
> macro, a build error occurs when using the clang compiler.
good catch! FIELD_PREP wants indeed a constant as a first
paramenter, also for gcc.
Reviewed-b
On Mon, 24 Oct 2022 14:09:53 -0700, Gwan-gyeong Mun wrote:
>
Hi GG,
> If a non-constant variable is used as the first argument of the FIELD_PREP
> macro, a build error occurs when using the clang compiler.
>
> Fix the following build error used with clang compiler:
>
> drivers/gpu/drm/i915/i915_h
If a non-constant variable is used as the first argument of the FIELD_PREP
macro, a build error occurs when using the clang compiler.
Fix the following build error used with clang compiler:
drivers/gpu/drm/i915/i915_hwmon.c:115:16: error: result of comparison of
constant 18446744073709551615 wit
19 matches
Mail list logo
