Re: [Intel-gfx] [PATCH] drm/i915/mtl: Use int for entry setup frames

2023-11-16 Thread Kahola, Mika
> -Original Message- > From: Ville Syrjälä > Sent: Wednesday, November 15, 2023 11:58 PM > To: Kahola, Mika > Cc: intel-gfx@lists.freedesktop.org; Hogander, Jouni > > Subject: Re: [PATCH] drm/i915/mtl: Use int for entry setup frames > > On Mon, Nov 13, 2023 at 11:37:37AM +0200, Mika Ka

Re: [Intel-gfx] [PATCH] drm/i915/mtl: Use int for entry setup frames

2023-11-15 Thread Ville Syrjälä
On Mon, Nov 13, 2023 at 11:37:37AM +0200, Mika Kahola wrote: > At least one TGL had regression when using u8 types > for entry setup frames calculation. So, let's switch > to use ints instead. > > Signed-off-by: Mika Kahola > --- > drivers/gpu/drm/i915/display/intel_psr.c | 6 +++--- > 1 file ch

Re: [Intel-gfx] [PATCH] drm/i915/mtl: Use int for entry setup frames

2023-11-14 Thread Kahola, Mika
> -Original Message- > From: Hajda, Andrzej > Sent: Tuesday, November 14, 2023 12:22 PM > To: Kahola, Mika ; intel-gfx@lists.freedesktop.org > Subject: Re: [Intel-gfx] [PATCH] drm/i915/mtl: Use int for entry setup frames > > On 13.11.2023 10:37, Mika Kahola wrote:

Re: [Intel-gfx] [PATCH] drm/i915/mtl: Use int for entry setup frames

2023-11-14 Thread Andrzej Hajda
On 13.11.2023 10:37, Mika Kahola wrote: At least one TGL had regression when using u8 types for entry setup frames calculation. So, let's switch to use ints instead. This explanation is missing the most important part - why int? I guess it is because intel_psr_entry_setup_frames can return -ET

Re: [Intel-gfx] [PATCH] drm/i915/mtl: Use int for entry setup frames

2023-11-14 Thread Hogander, Jouni
On Mon, 2023-11-13 at 11:37 +0200, Mika Kahola wrote: > At least one TGL had regression when using u8 types > for entry setup frames calculation. So, let's switch > to use ints instead. I think you need to add Fixes tag here? With this change: Reviewed-by: Jouni Högander > > Signed-off-by: Mik

[Intel-gfx] [PATCH] drm/i915/mtl: Use int for entry setup frames

2023-11-13 Thread Mika Kahola
At least one TGL had regression when using u8 types for entry setup frames calculation. So, let's switch to use ints instead. Signed-off-by: Mika Kahola --- drivers/gpu/drm/i915/display/intel_psr.c | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/drivers/gpu/drm/i915/dis