Re: [Intel-gfx] [PATCH] drm/i915/perf: Mark up the racy use of perf->exclusive_stream

2020-02-25 Thread Lionel Landwerlin
Actually, what about drivers/gpu/drm/i915/gt/intel_sseu.c? -Lionel On 25/02/2020 15:23, Chris Wilson wrote: Inside the general i915_oa_init_reg_state() we avoid using the perf->mutex. However, we rely on perf->exclusive_stream being valid to access at that point, and for that we have to control

Re: [Intel-gfx] [PATCH] drm/i915/perf: Mark up the racy use of perf->exclusive_stream

2020-02-25 Thread Lionel Landwerlin
On 25/02/2020 15:23, Chris Wilson wrote: Inside the general i915_oa_init_reg_state() we avoid using the perf->mutex. However, we rely on perf->exclusive_stream being valid to access at that point, and for that we have to control the race with disabling perf. This relies on the disabling being a h

[Intel-gfx] [PATCH] drm/i915/perf: Mark up the racy use of perf->exclusive_stream

2020-02-25 Thread Chris Wilson
Inside the general i915_oa_init_reg_state() we avoid using the perf->mutex. However, we rely on perf->exclusive_stream being valid to access at that point, and for that we have to control the race with disabling perf. This relies on the disabling being a heavy barrier that inspects all active conte