Re: [Intel-gfx] [PATCH] drm/i915/pmu: Deprecate I915_PMU_LAST and optimize state tracking

2020-12-04 Thread Chris Wilson
Quoting Tvrtko Ursulin (2020-12-04 10:57:52) > > On 03/12/2020 22:33, Chris Wilson wrote: > > Quoting Tvrtko Ursulin (2020-11-26 16:47:03) > >> From: Tvrtko Ursulin > >> > >> Adding any kinds of "last" abi markers is usually a mistake which I > >> repeated when implementing the PMU because it

Re: [Intel-gfx] [PATCH] drm/i915/pmu: Deprecate I915_PMU_LAST and optimize state tracking

2020-12-04 Thread Tvrtko Ursulin
On 03/12/2020 22:33, Chris Wilson wrote: Quoting Tvrtko Ursulin (2020-11-26 16:47:03) From: Tvrtko Ursulin Adding any kinds of "last" abi markers is usually a mistake which I repeated when implementing the PMU because it felt convenient at the time. This patch marks I915_PMU_LAST as

Re: [Intel-gfx] [PATCH] drm/i915/pmu: Deprecate I915_PMU_LAST and optimize state tracking

2020-12-03 Thread Chris Wilson
Quoting Tvrtko Ursulin (2020-11-26 16:47:03) > From: Tvrtko Ursulin > > Adding any kinds of "last" abi markers is usually a mistake which I > repeated when implementing the PMU because it felt convenient at the time. > > This patch marks I915_PMU_LAST as deprecated and stops the internal >

Re: [Intel-gfx] [PATCH] drm/i915/pmu: Deprecate I915_PMU_LAST and optimize state tracking

2020-11-26 Thread Chris Wilson
Quoting Tvrtko Ursulin (2020-11-26 18:58:20) > > On 26/11/2020 16:56, Chris Wilson wrote: > > Quoting Tvrtko Ursulin (2020-11-26 16:47:03) > >> -static unsigned int config_enabled_bit(u64 config) > >> +static unsigned int is_tracked_config(const u64 config) > >> { > >> - if

Re: [Intel-gfx] [PATCH] drm/i915/pmu: Deprecate I915_PMU_LAST and optimize state tracking

2020-11-26 Thread Tvrtko Ursulin
On 26/11/2020 16:56, Chris Wilson wrote: Quoting Tvrtko Ursulin (2020-11-26 16:47:03) -static unsigned int config_enabled_bit(u64 config) +static unsigned int is_tracked_config(const u64 config) { - if (is_engine_config(config)) + unsigned int val; +/** + * Non-engine events

Re: [Intel-gfx] [PATCH] drm/i915/pmu: Deprecate I915_PMU_LAST and optimize state tracking

2020-11-26 Thread Chris Wilson
Quoting Tvrtko Ursulin (2020-11-26 16:47:03) > -static unsigned int config_enabled_bit(u64 config) > +static unsigned int is_tracked_config(const u64 config) > { > - if (is_engine_config(config)) > + unsigned int val; > +/** > + * Non-engine events that we need to track

[Intel-gfx] [PATCH] drm/i915/pmu: Deprecate I915_PMU_LAST and optimize state tracking

2020-11-26 Thread Tvrtko Ursulin
From: Tvrtko Ursulin Adding any kinds of "last" abi markers is usually a mistake which I repeated when implementing the PMU because it felt convenient at the time. This patch marks I915_PMU_LAST as deprecated and stops the internal implementation using it for sizing the event status bitmask and