Re: [Intel-gfx] [PATCH] drm/i915/psr: Clean-up intel_enable_source_psr1()

2017-04-03 Thread Jim Bride
On Mon, Apr 03, 2017 at 05:42:39PM +, Vivi, Rodrigo wrote: > On Mon, 2017-04-03 at 10:07 -0700, Jim Bride wrote: > > On SKL+ there is a bit in SRD_CTL that software is not supposed to > > modify, but we currently clobber that bit when we enable PSR. In > > order to preserve the value of that b

Re: [Intel-gfx] [PATCH] drm/i915/psr: Clean-up intel_enable_source_psr1()

2017-04-03 Thread Vivi, Rodrigo
On Mon, 2017-04-03 at 10:07 -0700, Jim Bride wrote: > On SKL+ there is a bit in SRD_CTL that software is not supposed to > modify, but we currently clobber that bit when we enable PSR. In > order to preserve the value of that bit, go ahead and read SRD_CTL and > do a field-wise setting of the vari

[Intel-gfx] [PATCH] drm/i915/psr: Clean-up intel_enable_source_psr1()

2017-04-03 Thread Jim Bride
On SKL+ there is a bit in SRD_CTL that software is not supposed to modify, but we currently clobber that bit when we enable PSR. In order to preserve the value of that bit, go ahead and read SRD_CTL and do a field-wise setting of the various bits that we need to initialize before writing the regis