Re: [Intel-gfx] [PATCH] drm/i915/psr: Get pipe id following atomic guidelines

2018-11-28 Thread Ville Syrjälä
On Tue, Nov 27, 2018 at 11:28:38PM -0800, José Roberto de Souza wrote: > As stated in struct drm_encoder, crtc field should only be used > by non-atomic drivers. > > So here caching the pipe id in intel_psr_enable() what is way more > simple and efficient than at every call to >

Re: [Intel-gfx] [PATCH] drm/i915/psr: Get pipe id following atomic guidelines

2018-11-28 Thread Rodrigo Vivi
On Wed, Nov 28, 2018 at 10:21:05AM -0800, Souza, Jose wrote: > On Wed, 2018-11-28 at 08:55 -0800, Rodrigo Vivi wrote: > > On Tue, Nov 27, 2018 at 11:28:38PM -0800, José Roberto de Souza > > wrote: > > > As stated in struct drm_encoder, crtc field should only be used > > > by non-atomic drivers. >

Re: [Intel-gfx] [PATCH] drm/i915/psr: Get pipe id following atomic guidelines

2018-11-28 Thread Souza, Jose
On Wed, 2018-11-28 at 08:55 -0800, Rodrigo Vivi wrote: > On Tue, Nov 27, 2018 at 11:28:38PM -0800, José Roberto de Souza > wrote: > > As stated in struct drm_encoder, crtc field should only be used > > by non-atomic drivers. > > > > So here caching the pipe id in intel_psr_enable() what is way

Re: [Intel-gfx] [PATCH] drm/i915/psr: Get pipe id following atomic guidelines

2018-11-28 Thread Rodrigo Vivi
On Tue, Nov 27, 2018 at 11:28:38PM -0800, José Roberto de Souza wrote: > As stated in struct drm_encoder, crtc field should only be used > by non-atomic drivers. > > So here caching the pipe id in intel_psr_enable() what is way more > simple and efficient than at every call to >

[Intel-gfx] [PATCH] drm/i915/psr: Get pipe id following atomic guidelines

2018-11-27 Thread José Roberto de Souza
As stated in struct drm_encoder, crtc field should only be used by non-atomic drivers. So here caching the pipe id in intel_psr_enable() what is way more simple and efficient than at every call to intel_psr_flush()/invalidate() get the drm.mode_config.connection_mutex lock to safely be able to