Re: [Intel-gfx] [PATCH] drm/i915/selftests: Always flush before unpining after writing

2020-05-11 Thread Mika Kuoppala
Chris Wilson writes: > Be consistent, and even when we know we had used a WC, flush the mapped > object after writing into it. The flush understands the mapping type and > will only clflush if !I915_MAP_WC, but will always insert a wmb [sfence] > so that we can be sure that all writes are visible

[Intel-gfx] [PATCH] drm/i915/selftests: Always flush before unpining after writing

2020-05-11 Thread Chris Wilson
Be consistent, and even when we know we had used a WC, flush the mapped object after writing into it. The flush understands the mapping type and will only clflush if !I915_MAP_WC, but will always insert a wmb [sfence] so that we can be sure that all writes are visible. v2: Add the unconditional wm