On Wed, 04 Mar 2020, Jani Nikula wrote:
> On Tue, 03 Mar 2020, Matt Roper wrote:
>> On Tue, Mar 03, 2020 at 05:25:21PM +0200, Jani Nikula wrote:
>>> On Tue, 03 Mar 2020, Aditya Swarup wrote:
>>> > - struct lrc_timestamp data;
>>> > + struct lrc_timestamp data = { 0 };
>>>
>>> {} is preferred ov
On Tue, 03 Mar 2020, Matt Roper wrote:
> On Tue, Mar 03, 2020 at 05:25:21PM +0200, Jani Nikula wrote:
>> On Tue, 03 Mar 2020, Aditya Swarup wrote:
>> > - struct lrc_timestamp data;
>> > + struct lrc_timestamp data = { 0 };
>>
>> {} is preferred over {0}.
>
> Is there a reference for this (e.g.
On Tue, Mar 03, 2020 at 05:25:21PM +0200, Jani Nikula wrote:
> On Tue, 03 Mar 2020, Aditya Swarup wrote:
> > Static code analysis tool identified struct lrc_timestamp data as being
> > uninitialized and then data.ce[] is being checked for NULL/negative
> > value in the error path. Initializing dat
On Tue, Mar 03, 2020 at 06:23:47AM -0800, Aditya Swarup wrote:
> Static code analysis tool identified struct lrc_timestamp data as being
> uninitialized and then data.ce[] is being checked for NULL/negative
> value in the error path. Initializing data variable fixes the issue.
>
> Cc: Matt Roper
On Tue, 03 Mar 2020, Aditya Swarup wrote:
> Static code analysis tool identified struct lrc_timestamp data as being
> uninitialized and then data.ce[] is being checked for NULL/negative
> value in the error path. Initializing data variable fixes the issue.
>
> Cc: Matt Roper
> Cc: Chris Wilson
>
Static code analysis tool identified struct lrc_timestamp data as being
uninitialized and then data.ce[] is being checked for NULL/negative
value in the error path. Initializing data variable fixes the issue.
Cc: Matt Roper
Cc: Chris Wilson
Signed-off-by: Aditya Swarup
---
drivers/gpu/drm/i915
On 04/24/2018 08:22 AM, Chris Wilson wrote:
Quoting Gustavo A. R. Silva (2018-04-24 14:15:45)
There is a potential execution path in which variable err is
returned without being properly initialized previously.
Fix this by initializing variable err to 0.
err is only returned along an error
Quoting Gustavo A. R. Silva (2018-04-24 14:30:58)
>
>
> On 04/24/2018 08:22 AM, Chris Wilson wrote:
> > Quoting Gustavo A. R. Silva (2018-04-24 14:15:45)
> >> There is a potential execution path in which variable err is
> >> returned without being properly initialized previously.
> >>
> >> Fix th
There is a potential execution path in which variable err is
returned without being properly initialized previously.
Fix this by initializing variable err to 0.
Addresses-Coverity-ID: 1468362 ("Uninitialized scalar variable")
Fixes: f4ecfbfc32ed ("drm/i915: Check whitelist registers across resets
Quoting Gustavo A. R. Silva (2018-04-24 14:15:45)
> There is a potential execution path in which variable err is
> returned without being properly initialized previously.
>
> Fix this by initializing variable err to 0.
err is only returned along an error path, returning 0 would not be
useful. Whi
10 matches
Mail list logo
