Re: [Intel-gfx] [PATCH] drm/i915/skl: replace csr_mutex by completion in csr firmware loading

2015-06-29 Thread Daniel Vetter
Quick summary of the tasks around dmc loader that we talked about in our mtg just now. - replace runtime_pm_get/put with display_power_get/put to make sure we prevent entering dc5/6 code while the firmware loading is in progress. Then remove the wait code in the skl power well code and replace it

Re: [Intel-gfx] [PATCH] drm/i915/skl: replace csr_mutex by completion in csr firmware loading

2015-06-15 Thread Dave Gordon
On 15/06/15 11:07, Daniel Vetter wrote: > On Thu, Jun 04, 2015 at 03:36:32PM +0100, Dave Gordon wrote: >> On 04/06/15 06:59, Sagar Arun Kamble wrote: >>> >>> Hi Daniel, >>> >>> We already are grabbing RPM reference before start of DMC FW load and >>> release post load completion. >>> >>> DC5/6 can

Re: [Intel-gfx] [PATCH] drm/i915/skl: replace csr_mutex by completion in csr firmware loading

2015-06-15 Thread Daniel Vetter
On Thu, Jun 04, 2015 at 03:36:32PM +0100, Dave Gordon wrote: > On 04/06/15 06:59, Sagar Arun Kamble wrote: > > > > Hi Daniel, > > > > We already are grabbing RPM reference before start of DMC FW load and > > release post load completion. > > > > DC5/6 can happen without Runtime PM as well. So we

Re: [Intel-gfx] [PATCH] drm/i915/skl: replace csr_mutex by completion in csr firmware loading

2015-06-15 Thread Daniel Vetter
On Thu, Jun 04, 2015 at 11:29:35AM +0530, Sagar Arun Kamble wrote: > On Thu, 2015-05-21 at 23:29 +0200, Daniel Vetter wrote: > > On Thu, May 21, 2015 at 10:35:07PM +0530, Animesh Manna wrote: > > > > > > > > > On 5/21/2015 5:41 PM, Daniel Vetter wrote: > > > >On Thu, May 21, 2015 at 03:49:52PM +0

Re: [Intel-gfx] [PATCH] drm/i915/skl: replace csr_mutex by completion in csr firmware loading

2015-06-04 Thread Dave Gordon
On 04/06/15 06:59, Sagar Arun Kamble wrote: > > Hi Daniel, > > We already are grabbing RPM reference before start of DMC FW load and > release post load completion. > > DC5/6 can happen without Runtime PM as well. So we need to wait for CSR > FW load for some time once we disable PW2. > > Havin

Re: [Intel-gfx] [PATCH] drm/i915/skl: replace csr_mutex by completion in csr firmware loading

2015-06-03 Thread Sagar Arun Kamble
On Thu, 2015-05-21 at 23:29 +0200, Daniel Vetter wrote: > On Thu, May 21, 2015 at 10:35:07PM +0530, Animesh Manna wrote: > > > > > > On 5/21/2015 5:41 PM, Daniel Vetter wrote: > > >On Thu, May 21, 2015 at 03:49:52PM +0530, Animesh Manna wrote: > > >>Before enabling dc5/dc6, used wait for completi

Re: [Intel-gfx] [PATCH] drm/i915/skl: replace csr_mutex by completion in csr firmware loading

2015-05-21 Thread Daniel Vetter
On Thu, May 21, 2015 at 10:35:07PM +0530, Animesh Manna wrote: > > > On 5/21/2015 5:41 PM, Daniel Vetter wrote: > >On Thu, May 21, 2015 at 03:49:52PM +0530, Animesh Manna wrote: > >>Before enabling dc5/dc6, used wait for completion instead of busy waiting. > >> > >>v1: > >>- Based on review comme

Re: [Intel-gfx] [PATCH] drm/i915/skl: replace csr_mutex by completion in csr firmware loading

2015-05-21 Thread Animesh Manna
On 5/21/2015 5:41 PM, Daniel Vetter wrote: On Thu, May 21, 2015 at 03:49:52PM +0530, Animesh Manna wrote: Before enabling dc5/dc6, used wait for completion instead of busy waiting. v1: - Based on review comment from Daniel replaced mutex and related implementation with completion. In current

Re: [Intel-gfx] [PATCH] drm/i915/skl: replace csr_mutex by completion in csr firmware loading

2015-05-21 Thread Daniel Vetter
On Thu, May 21, 2015 at 03:49:52PM +0530, Animesh Manna wrote: > Before enabling dc5/dc6, used wait for completion instead of busy waiting. > > v1: > - Based on review comment from Daniel replaced mutex and related > implementation with completion. In current patch not used power > domain lock, do

[Intel-gfx] [PATCH] drm/i915/skl: replace csr_mutex by completion in csr firmware loading

2015-05-21 Thread Animesh Manna
Before enabling dc5/dc6, used wait for completion instead of busy waiting. v1: - Based on review comment from Daniel replaced mutex and related implementation with completion. In current patch not used power domain lock, don't want to block runtime power management if dmc firmware failed to load.