Re: [Intel-gfx] [PATCH] drm/i915/slpc: Fix inconsistent locked return

2022-08-30 Thread Dixit, Ashutosh
On Tue, 30 Aug 2022 12:35:37 -0700, Rodrigo Vivi wrote: > > Fix for intel_guc_slpc_set_min_freq() warn: > inconsistent returns '>lock'. > > v2: Avoid with_intel_runtime_pm with the > internal goto/return. (Ashutosh) > Also standardize the 'ret' if this came from > the efficient setup.

[Intel-gfx] [PATCH] drm/i915/slpc: Fix inconsistent locked return

2022-08-30 Thread Rodrigo Vivi
Fix for intel_guc_slpc_set_min_freq() warn: inconsistent returns '>lock'. v2: Avoid with_intel_runtime_pm with the internal goto/return. (Ashutosh) Also standardize the 'ret' if this came from the efficient setup. And avoid the 'unlikely'. Fixes: 95ccf312a1e4 ("drm/i915/guc/slpc:

Re: [Intel-gfx] [PATCH] drm/i915/slpc: Fix inconsistent locked return

2022-08-30 Thread Dixit, Ashutosh
On Tue, 30 Aug 2022 08:02:29 -0700, Rodrigo Vivi wrote: > > diff --git a/drivers/gpu/drm/i915/gt/uc/intel_guc_slpc.c > b/drivers/gpu/drm/i915/gt/uc/intel_guc_slpc.c > index 9d49ccef03bb..f8a2bbcdf14f 100644 > --- a/drivers/gpu/drm/i915/gt/uc/intel_guc_slpc.c > +++

[Intel-gfx] [PATCH] drm/i915/slpc: Fix inconsistent locked return

2022-08-30 Thread Rodrigo Vivi
Fix for intel_guc_slpc_set_min_freq() warn: inconsistent returns '>lock'. Fixes: 95ccf312a1e4 ("drm/i915/guc/slpc: Allow SLPC to use efficient frequency") Reported-by: kernel test robot Reported-by: Dan Carpenter Cc: Ashutosh Dixit Signed-off-by: Rodrigo Vivi ---