Re: [Intel-gfx] [PATCH] drm/i915/tv: avoid possible division by zero

2023-07-19 Thread Su Hui
On 2023/7/18 19:28, Andrzej Hajda wrote: On 18.07.2023 12:10, Su Hui wrote: On 2023/7/18 13:39, Dan Carpenter wrote: On Mon, Jul 17, 2023 at 04:52:51PM +0200, Andrzej Hajda wrote: On 17.07.2023 08:22, Su Hui wrote: Clang warning: drivers/gpu/drm/i915/display/intel_tv.c: line 991, column 22

Re: [Intel-gfx] [PATCH] drm/i915/tv: avoid possible division by zero

2023-07-19 Thread Su Hui
On 2023/7/18 13:39, Dan Carpenter wrote: On Mon, Jul 17, 2023 at 04:52:51PM +0200, Andrzej Hajda wrote: On 17.07.2023 08:22, Su Hui wrote: Clang warning: drivers/gpu/drm/i915/display/intel_tv.c: line 991, column 22 Division by zero. Assuming tv_mode->oversample=1 and

Re: [Intel-gfx] [PATCH] drm/i915/tv: avoid possible division by zero

2023-07-19 Thread Su Hui
On 2023/7/17 22:52, Andrzej Hajda wrote: On 17.07.2023 08:22, Su Hui wrote: Clang warning: drivers/gpu/drm/i915/display/intel_tv.c: line 991, column 22 Division by zero. Assuming tv_mode->oversample=1 and (!tv_mode->progressive)=1, then division by zero will happen. Fixes: 1bba5543e4fe

Re: [Intel-gfx] [PATCH] drm/i915/tv: avoid possible division by zero

2023-07-18 Thread Andrzej Hajda
On 18.07.2023 12:10, Su Hui wrote: On 2023/7/18 13:39, Dan Carpenter wrote: On Mon, Jul 17, 2023 at 04:52:51PM +0200, Andrzej Hajda wrote: On 17.07.2023 08:22, Su Hui wrote: Clang warning: drivers/gpu/drm/i915/display/intel_tv.c: line 991, column 22 Division by zero. Assuming

Re: [Intel-gfx] [PATCH] drm/i915/tv: avoid possible division by zero

2023-07-17 Thread Dan Carpenter
On Mon, Jul 17, 2023 at 04:52:51PM +0200, Andrzej Hajda wrote: > > > On 17.07.2023 08:22, Su Hui wrote: > > Clang warning: drivers/gpu/drm/i915/display/intel_tv.c: > > line 991, column 22 Division by zero. > > Assuming tv_mode->oversample=1 and (!tv_mode->progressive)=1, > > then division by

Re: [Intel-gfx] [PATCH] drm/i915/tv: avoid possible division by zero

2023-07-17 Thread Andrzej Hajda
On 17.07.2023 08:22, Su Hui wrote: Clang warning: drivers/gpu/drm/i915/display/intel_tv.c: line 991, column 22 Division by zero. Assuming tv_mode->oversample=1 and (!tv_mode->progressive)=1, then division by zero will happen. Fixes: 1bba5543e4fe ("drm/i915: Fix TV encoder clock computation")

[Intel-gfx] [PATCH] drm/i915/tv: avoid possible division by zero

2023-07-17 Thread Su Hui
Clang warning: drivers/gpu/drm/i915/display/intel_tv.c: line 991, column 22 Division by zero. Assuming tv_mode->oversample=1 and (!tv_mode->progressive)=1, then division by zero will happen. Fixes: 1bba5543e4fe ("drm/i915: Fix TV encoder clock computation") Signed-off-by: Su Hui ---