Re: [Intel-gfx] [PATCH] drm/i915/userptr: Keep spin_lock/unlock in the same block

2014-07-25 Thread Daniel Vetter
On Thu, Jul 24, 2014 at 01:28:44PM +0100, Chris Wilson wrote: Move the code around in order to acquire and release the spinlock in the same function and in the same block. This keeps static analysers happy and the reader sane. Suggested-by: Julia Lawall julia.law...@lip6.fr Signed-off-by:

[Intel-gfx] [PATCH] drm/i915/userptr: Keep spin_lock/unlock in the same block

2014-07-24 Thread Chris Wilson
Move the code around in order to acquire and release the spinlock in the same function and in the same block. This keeps static analysers happy and the reader sane. Suggested-by: Julia Lawall julia.law...@lip6.fr Signed-off-by: Chris Wilson ch...@chris-wilson.co.uk Cc: Julia Lawall

Re: [Intel-gfx] [PATCH] drm/i915/userptr: Keep spin_lock/unlock in the same block

2014-07-24 Thread Julia Lawall
All of the NULL tests are a bit complicated but since they are there anyway, I guess it is reasonable to take advantage of them. julia On Thu, 24 Jul 2014, Chris Wilson wrote: Move the code around in order to acquire and release the spinlock in the same function and in the same block. This