Re: [Intel-gfx] [PATCH] drm/i915: Abstract display info away during probe

2023-10-03 Thread Jani Nikula
On Mon, 02 Oct 2023, Rodrigo Vivi wrote: > On Mon, Oct 02, 2023 at 07:58:30PM +0300, Jani Nikula wrote: >> On Mon, 02 Oct 2023, Rodrigo Vivi wrote: >> > On Mon, Oct 02, 2023 at 10:41:14AM +0300, Jani Nikula wrote: >> >> On Fri, 29 Sep 2023, Rodrigo Vivi wrote: >> >> > The goal is to have this

Re: [Intel-gfx] [PATCH] drm/i915: Abstract display info away during probe

2023-10-02 Thread Rodrigo Vivi
On Mon, Oct 02, 2023 at 07:58:30PM +0300, Jani Nikula wrote: > On Mon, 02 Oct 2023, Rodrigo Vivi wrote: > > On Mon, Oct 02, 2023 at 10:41:14AM +0300, Jani Nikula wrote: > >> On Fri, 29 Sep 2023, Rodrigo Vivi wrote: > >> > The goal is to have this function ready for Xe to use > >> > directly. So,

Re: [Intel-gfx] [PATCH] drm/i915: Abstract display info away during probe

2023-10-02 Thread Jani Nikula
On Mon, 02 Oct 2023, Rodrigo Vivi wrote: > On Mon, Oct 02, 2023 at 10:41:14AM +0300, Jani Nikula wrote: >> On Fri, 29 Sep 2023, Rodrigo Vivi wrote: >> > The goal is to have this function ready for Xe to use >> > directly. So, let's use the available macro. >> >> Seesm wrong to use

Re: [Intel-gfx] [PATCH] drm/i915: Abstract display info away during probe

2023-10-02 Thread Rodrigo Vivi
On Mon, Oct 02, 2023 at 10:41:14AM +0300, Jani Nikula wrote: > On Fri, 29 Sep 2023, Rodrigo Vivi wrote: > > The goal is to have this function ready for Xe to use > > directly. So, let's use the available macro. > > Seesm wrong to use DISPLAY_INFO() as an lvalue to be really honestly I don't

Re: [Intel-gfx] [PATCH] drm/i915: Abstract display info away during probe

2023-10-02 Thread Jani Nikula
On Fri, 29 Sep 2023, Rodrigo Vivi wrote: > The goal is to have this function ready for Xe to use > directly. So, let's use the available macro. Seesm wrong to use DISPLAY_INFO() as an lvalue, and I'm not sure why this wouldn't work as-is. But *shrug*. Reviewed-by: Jani Nikula for merging to

[Intel-gfx] [PATCH] drm/i915: Abstract display info away during probe

2023-09-29 Thread Rodrigo Vivi
The goal is to have this function ready for Xe to use directly. So, let's use the available macro. Cc: Jani Nikula Signed-off-by: Rodrigo Vivi --- drivers/gpu/drm/i915/display/intel_display_device.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git