Re: [Intel-gfx] [PATCH] drm/i915: Add missing 'else' to intel_digital_port_connected()

2016-02-12 Thread Jani Nikula
On Thu, 11 Feb 2016, ville.syrj...@linux.intel.com wrote: > From: Ville Syrjälä > > intel_digital_port_connected() lacks one 'else'. There's no > actual harm in not having it since each branch has an unconditional > return, so it can't accidentally end up in taking two branches instead > of just t

[Intel-gfx] [PATCH] drm/i915: Add missing 'else' to intel_digital_port_connected()

2016-02-11 Thread ville . syrjala
From: Ville Syrjälä intel_digital_port_connected() lacks one 'else'. There's no actual harm in not having it since each branch has an unconditional return, so it can't accidentally end up in taking two branches instead of just the one. But let's be consistent and add the 'else' anyway. Signed-of