Re: [Intel-gfx] [PATCH] drm/i915: Add missing ring_mask to Pineview

2016-08-03 Thread Daniel Vetter
On Tue, Aug 02, 2016 at 03:47:29PM +0100, Chris Wilson wrote: > On Tue, Aug 02, 2016 at 04:34:25PM +0200, Daniel Vetter wrote: > > On Fri, Jul 29, 2016 at 12:10:30PM +0100, Chris Wilson wrote: > > > On Fri, Jul 29, 2016 at 10:57:49AM +0200, Daniel Vetter wrote: > > > > On Fri, Jul 29, 2016 at 11:42

Re: [Intel-gfx] [PATCH] drm/i915: Add missing ring_mask to Pineview

2016-08-02 Thread Chris Wilson
On Tue, Aug 02, 2016 at 04:34:25PM +0200, Daniel Vetter wrote: > On Fri, Jul 29, 2016 at 12:10:30PM +0100, Chris Wilson wrote: > > On Fri, Jul 29, 2016 at 10:57:49AM +0200, Daniel Vetter wrote: > > > On Fri, Jul 29, 2016 at 11:42:24AM +0300, Joonas Lahtinen wrote: > > > > On pe, 2016-07-29 at 00:45

Re: [Intel-gfx] [PATCH] drm/i915: Add missing ring_mask to Pineview

2016-08-02 Thread Daniel Vetter
On Fri, Jul 29, 2016 at 12:10:30PM +0100, Chris Wilson wrote: > On Fri, Jul 29, 2016 at 10:57:49AM +0200, Daniel Vetter wrote: > > On Fri, Jul 29, 2016 at 11:42:24AM +0300, Joonas Lahtinen wrote: > > > On pe, 2016-07-29 at 00:45 +0100, Chris Wilson wrote: > > > > It appears that we never told Pinev

Re: [Intel-gfx] [PATCH] drm/i915: Add missing ring_mask to Pineview

2016-07-29 Thread Ben Widawsky
On Fri, Jul 29, 2016 at 12:10:30PM +0100, Chris Wilson wrote: > On Fri, Jul 29, 2016 at 10:57:49AM +0200, Daniel Vetter wrote: > > On Fri, Jul 29, 2016 at 11:42:24AM +0300, Joonas Lahtinen wrote: > > > On pe, 2016-07-29 at 00:45 +0100, Chris Wilson wrote: > > > > It appears that we never told Pinev

Re: [Intel-gfx] [PATCH] drm/i915: Add missing ring_mask to Pineview

2016-07-29 Thread Chris Wilson
On Fri, Jul 29, 2016 at 10:57:49AM +0200, Daniel Vetter wrote: > On Fri, Jul 29, 2016 at 11:42:24AM +0300, Joonas Lahtinen wrote: > > On pe, 2016-07-29 at 00:45 +0100, Chris Wilson wrote: > > > It appears that we never told Pineview it has a RENDER_RING. This was > > > all fine until we started usi

Re: [Intel-gfx] [PATCH] drm/i915: Add missing ring_mask to Pineview

2016-07-29 Thread Daniel Vetter
On Fri, Jul 29, 2016 at 11:42:24AM +0300, Joonas Lahtinen wrote: > On pe, 2016-07-29 at 00:45 +0100, Chris Wilson wrote: > > It appears that we never told Pineview it has a RENDER_RING. This was > > all fine until we started using the ring_mask for determining all the > > available rings to initial

Re: [Intel-gfx] [PATCH] drm/i915: Add missing ring_mask to Pineview

2016-07-29 Thread Joonas Lahtinen
On pe, 2016-07-29 at 00:45 +0100, Chris Wilson wrote: > It appears that we never told Pineview it has a RENDER_RING. This was > all fine until we started using the ring_mask for determining all the > available rings to initialise for legacy ringbuffer submission in commit > 88d2ba2e95c8 ("drm/i915:

[Intel-gfx] [PATCH] drm/i915: Add missing ring_mask to Pineview

2016-07-28 Thread Chris Wilson
It appears that we never told Pineview it has a RENDER_RING. This was all fine until we started using the ring_mask for determining all the available rings to initialise for legacy ringbuffer submission in commit 88d2ba2e95c8 ("drm/i915: Unify engine init loop"). Though really it is a latent bug si