Re: [Intel-gfx] [PATCH] drm/i915: Avoid pointer arithmetic in calculating plane surface offset

2015-11-09 Thread Ville Syrjälä
On Fri, Oct 30, 2015 at 11:40:46AM +, Tvrtko Ursulin wrote: > > On 30/10/15 11:26, Mika Kuoppala wrote: > > VMA offsets are 64 bits. Plane surface offsets are in ggtt and > > the hardware register to set this is thus 32 bits. Be explicit > > about these and convert carefully to from vma to fin

Re: [Intel-gfx] [PATCH] drm/i915: Avoid pointer arithmetic in calculating plane surface offset

2015-10-30 Thread Tvrtko Ursulin
On 30/10/15 11:26, Mika Kuoppala wrote: VMA offsets are 64 bits. Plane surface offsets are in ggtt and the hardware register to set this is thus 32 bits. Be explicit about these and convert carefully to from vma to final size. This will make sparse happy by not creating 32bit pointers out of 64

[Intel-gfx] [PATCH] drm/i915: Avoid pointer arithmetic in calculating plane surface offset

2015-10-30 Thread Mika Kuoppala
VMA offsets are 64 bits. Plane surface offsets are in ggtt and the hardware register to set this is thus 32 bits. Be explicit about these and convert carefully to from vma to final size. This will make sparse happy by not creating 32bit pointers out of 64bit vma offsets. Cc: Tvrtko Ursulin Signe