Re: [Intel-gfx] [PATCH] drm/i915: Avoid using ctx->file_priv during construction

2019-03-31 Thread Chris Wilson
Quoting Michal Wajdeczko (2019-03-31 10:12:52) > On Sat, 30 Mar 2019 11:03:49 +0100, Chris Wilson > wrote: > > > As we only set ctx->file_priv on registering the GEM context after > > construction, it is invalid to try and use it in the middle for setting > > Other option would be to set ctx->

Re: [Intel-gfx] [PATCH] drm/i915: Avoid using ctx->file_priv during construction

2019-03-31 Thread Jordan Justen
On 2019-03-31 00:32:52, Chris Wilson wrote: > Quoting Jordan Justen (2019-03-31 04:03:44) > > I think the change is focused mainly around setting the vm param, so > > perhaps the subject should mention that. Maybe something like: > > It's not just about that, it's the design in how create_ext is r

Re: [Intel-gfx] [PATCH] drm/i915: Avoid using ctx->file_priv during construction

2019-03-31 Thread Michal Wajdeczko
On Sat, 30 Mar 2019 11:03:49 +0100, Chris Wilson wrote: As we only set ctx->file_priv on registering the GEM context after construction, it is invalid to try and use it in the middle for setting Other option would be to set ctx->file_priv ahead of gem_context_register and use gem_context_re

Re: [Intel-gfx] [PATCH] drm/i915: Avoid using ctx->file_priv during construction

2019-03-31 Thread Chris Wilson
Quoting Jordan Justen (2019-03-31 04:03:44) > I think the change is focused mainly around setting the vm param, so > perhaps the subject should mention that. Maybe something like: It's not just about that, it's the design in how create_ext is run before registration which caters for more than just

Re: [Intel-gfx] [PATCH] drm/i915: Avoid using ctx->file_priv during construction

2019-03-30 Thread Jordan Justen
I think the change is focused mainly around setting the vm param, so perhaps the subject should mention that. Maybe something like: drm/i915: Avoid using ctx->file_priv for VM param during construction I guess a similar issue could arise if other context params are added later. Hopefully any issu

[Intel-gfx] [PATCH] drm/i915: Avoid using ctx->file_priv during construction

2019-03-30 Thread Chris Wilson
As we only set ctx->file_priv on registering the GEM context after construction, it is invalid to try and use it in the middle for setting various parameters. Indeed, we put the file_priv into struct create_ext so that we have the right file_private available without having to look at ctx->file_pri