Re: [Intel-gfx] [PATCH] drm/i915: BUG_ON when ggtt_view is NULL

2016-03-30 Thread Joonas Lahtinen
On to, 2016-03-24 at 15:54 +, Matthew Auld wrote: > Lets BUG_ON and don't bother with a WARN and returning an error, so we can > remove the need to pollute the code with error handling, after all it is > a programmer error to provide NULL view. Also while we're here remove > redundant NULL ggtt

Re: [Intel-gfx] [PATCH] drm/i915: BUG_ON when ggtt_view is NULL

2016-03-29 Thread Daniel Vetter
On Thu, Mar 24, 2016 at 03:54:20PM +, Matthew Auld wrote: > Lets BUG_ON and don't bother with a WARN and returning an error, so we can > remove the need to pollute the code with error handling, after all it is > a programmer error to provide NULL view. Also while we're here remove > redundant N

[Intel-gfx] [PATCH] drm/i915: BUG_ON when ggtt_view is NULL

2016-03-24 Thread Matthew Auld
Lets BUG_ON and don't bother with a WARN and returning an error, so we can remove the need to pollute the code with error handling, after all it is a programmer error to provide NULL view. Also while we're here remove redundant NULL ggtt_view check. Cc: Joonas Lahtinen Cc: Tvrtko Ursulin Signed-