Re: [Intel-gfx] [PATCH] drm/i915: Be defensive when cleaning up i915_gem_internal pages

2017-01-31 Thread Chris Wilson
On Tue, Jan 31, 2017 at 11:04:49AM +, Matthew Auld wrote: > On 31 January 2017 at 10:46, Chris Wilson wrote: > > If we abort the i915_gem_internal get_pages, we mark the failing sg as > > the last. However, that means we iterate upto and including the failing > > sg element and results us in t

Re: [Intel-gfx] [PATCH] drm/i915: Be defensive when cleaning up i915_gem_internal pages

2017-01-31 Thread Matthew Auld
On 31 January 2017 at 10:46, Chris Wilson wrote: > If we abort the i915_gem_internal get_pages, we mark the failing sg as > the last. However, that means we iterate upto and including the failing > sg element and results us in trying to free the unallocated sg_page(). s/us in/in us/ > > Signed-of

[Intel-gfx] [PATCH] drm/i915: Be defensive when cleaning up i915_gem_internal pages

2017-01-31 Thread Chris Wilson
If we abort the i915_gem_internal get_pages, we mark the failing sg as the last. However, that means we iterate upto and including the failing sg element and results us in trying to free the unallocated sg_page(). Signed-off-by: Chris Wilson --- drivers/gpu/drm/i915/i915_gem_internal.c | 7 +